Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: iZ+tEqI7ipHBPYD1rLMY2VWvgokfoaLwV4mTI/abRVawcQWIXeZytxh5yNMxu5AU3eIbB/qrg7
 ONszztyaBEBisJ/nVe1vEgUP9uXcF4ksbPLDdDy6zWvV0ov1X3y1IFmdTfJ6CL4V846rcNWoqK
 DZGkG+vhoAiKw5qj5PVo7i3on3jl1mAbeKBbXW8qCTgaqstMcOSAZ01FEGFjyhJxVxxy7BK0ua
 Ztc2BQ+aKH9m1b3P2t0sv/UEMTs0IPB2O0qW9F6DFdra+mZOaqc5JTB75VKcJpMzzPdF7wEkbD
 dFQ=
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     Minwoo Im <minwoo.im.dev@gmail.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Matias Bjorling <mb@lightnvm.io>
Subject: Re: [PATCH] lightnvm: introduce pr_fmt for the previx nvm
Thread-Topic: [PATCH] lightnvm: introduce pr_fmt for the previx nvm
Thread-Index: AQHVPtV93DLKyv14v0+ufvvuscZTLA==
Date:   Sat, 20 Jul 2019 21:27:37 +0000
Message-ID: <BYAPR04MB5749126EF9E68D94125BACB486CA0@BYAPR04MB5749.namprd04.prod.outlook.com>
References: <20190720083043.23387-1-minwoo.im.dev@gmail.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 302a9289-13fc-448e-3788-08d70d59162d
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2019 21:27:37.0247
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Chaitanya.Kulkarni@wdc.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB5286
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/20/2019 01:31 AM, Minwoo Im wrote:=0A=
> all the pr_() family can have this prefix by pr_fmt.=0A=
>=0A=
> Cc: Matias Bjorling <mb@lightnvm.io>=0A=
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>=0A=
> ---=0A=
>   drivers/lightnvm/core.c | 45 +++++++++++++++++++++--------------------=
=0A=
>   1 file changed, 23 insertions(+), 22 deletions(-)=0A=
>=0A=
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c=0A=
> index a600934fdd9c..ba2947083da1 100644=0A=
> --- a/drivers/lightnvm/core.c=0A=
> +++ b/drivers/lightnvm/core.c=0A=
> @@ -4,6 +4,7 @@=0A=
>    * Initial release: Matias Bjorling <m@bjorling.me>=0A=
>    */=0A=
>=0A=
> +#define pr_fmt(fmt) "nvm: " fmt=0A=
>   #include <linux/list.h>=0A=
>   #include <linux/types.h>=0A=
>   #include <linux/sem.h>=0A=
> @@ -74,7 +75,7 @@ static int nvm_reserve_luns(struct nvm_dev *dev, int lu=
n_begin, int lun_end)=0A=
>=0A=
>   	for (i =3D lun_begin; i <=3D lun_end; i++) {=0A=
>   		if (test_and_set_bit(i, dev->lun_map)) {=0A=
> -			pr_err("nvm: lun %d already allocated\n", i);=0A=
> +			pr_err("lun %d already allocated\n", i);=0A=
>   			goto err;=0A=
>   		}=0A=
>   	}=0A=
> @@ -264,7 +265,7 @@ static int nvm_config_check_luns(struct nvm_geo *geo,=
 int lun_begin,=0A=
>   				 int lun_end)=0A=
>   {=0A=
>   	if (lun_begin > lun_end || lun_end >=3D geo->all_luns) {=0A=
> -		pr_err("nvm: lun out of bound (%u:%u > %u)\n",=0A=
> +		pr_err("lun out of bound (%u:%u > %u)\n",=0A=
>   			lun_begin, lun_end, geo->all_luns - 1);=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
> @@ -297,7 +298,7 @@ static int __nvm_config_extended(struct nvm_dev *dev,=
=0A=
>   	if (e->op =3D=3D 0xFFFF) {=0A=
>   		e->op =3D NVM_TARGET_DEFAULT_OP;=0A=
>   	} else if (e->op < NVM_TARGET_MIN_OP || e->op > NVM_TARGET_MAX_OP) {=
=0A=
> -		pr_err("nvm: invalid over provisioning value\n");=0A=
> +		pr_err("invalid over provisioning value\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
> @@ -334,23 +335,23 @@ static int nvm_create_tgt(struct nvm_dev *dev, stru=
ct nvm_ioctl_create *create)=0A=
>   		e =3D create->conf.e;=0A=
>   		break;=0A=
>   	default:=0A=
> -		pr_err("nvm: config type not valid\n");=0A=
> +		pr_err("config type not valid\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
>   	tt =3D nvm_find_target_type(create->tgttype);=0A=
>   	if (!tt) {=0A=
> -		pr_err("nvm: target type %s not found\n", create->tgttype);=0A=
> +		pr_err("target type %s not found\n", create->tgttype);=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
>   	if ((tt->flags & NVM_TGT_F_HOST_L2P) !=3D (dev->geo.dom & NVM_RSP_L2P)=
) {=0A=
> -		pr_err("nvm: device is incompatible with target L2P type.\n");=0A=
> +		pr_err("device is incompatible with target L2P type.\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
>   	if (nvm_target_exists(create->tgtname)) {=0A=
> -		pr_err("nvm: target name already exists (%s)\n",=0A=
> +		pr_err("target name already exists (%s)\n",=0A=
>   							create->tgtname);=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
> @@ -367,7 +368,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct=
 nvm_ioctl_create *create)=0A=
>=0A=
>   	tgt_dev =3D nvm_create_tgt_dev(dev, e.lun_begin, e.lun_end, e.op);=0A=
>   	if (!tgt_dev) {=0A=
> -		pr_err("nvm: could not create target device\n");=0A=
> +		pr_err("could not create target device\n");=0A=
>   		ret =3D -ENOMEM;=0A=
>   		goto err_t;=0A=
>   	}=0A=
> @@ -686,7 +687,7 @@ static int nvm_set_rqd_ppalist(struct nvm_tgt_dev *tg=
t_dev, struct nvm_rq *rqd,=0A=
>   	rqd->nr_ppas =3D nr_ppas;=0A=
>   	rqd->ppa_list =3D nvm_dev_dma_alloc(dev, GFP_KERNEL, &rqd->dma_ppa_lis=
t);=0A=
>   	if (!rqd->ppa_list) {=0A=
> -		pr_err("nvm: failed to allocate dma memory\n");=0A=
> +		pr_err("failed to allocate dma memory\n");=0A=
>   		return -ENOMEM;=0A=
>   	}=0A=
>=0A=
> @@ -1048,7 +1049,7 @@ int nvm_set_chunk_meta(struct nvm_tgt_dev *tgt_dev,=
 struct ppa_addr *ppas,=0A=
>   		return 0;=0A=
>=0A=
>   	if (nr_ppas > NVM_MAX_VLBA) {=0A=
> -		pr_err("nvm: unable to update all blocks atomically\n");=0A=
> +		pr_err("unable to update all blocks atomically\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
> @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)=0A=
>   	int ret =3D -EINVAL;=0A=
>=0A=
>   	if (dev->ops->identity(dev)) {=0A=
> -		pr_err("nvm: device could not be identified\n");=0A=
> +		pr_err("device could not be identified\n");=0A=
>   		goto err;=0A=
>   	}=0A=
>=0A=
> -	pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",=0A=
> +	pr_debug("ver:%u.%u nvm_vendor:%x\n",=0A=
>   				geo->major_ver_id, geo->minor_ver_id,=0A=
>   				geo->vmnt);=0A=
The above last 2 lines can be squashed and pr_debug call can be made in =0A=
2 lines since you have removed the "nvm:" which shortens the first line.=0A=
>=0A=
>   	ret =3D nvm_core_init(dev);=0A=
>   	if (ret) {=0A=
> -		pr_err("nvm: could not initialize core structures.\n");=0A=
> +		pr_err("could not initialize core structures.\n");=0A=
>   		goto err;=0A=
>   	}=0A=
>=0A=
> -	pr_info("nvm: registered %s [%u/%u/%u/%u/%u]\n",=0A=
> +	pr_info("registered %s [%u/%u/%u/%u/%u]\n",=0A=
>   			dev->name, dev->geo.ws_min, dev->geo.ws_opt,=0A=
>   			dev->geo.num_chk, dev->geo.all_luns,=0A=
>   			dev->geo.num_ch);=0A=
>   	return 0;=0A=
>   err:=0A=
> -	pr_err("nvm: failed to initialize nvm\n");=0A=
> +	pr_err("failed to initialize nvm\n");=0A=
>   	return ret;=0A=
>   }=0A=
>=0A=
> @@ -1169,7 +1170,7 @@ int nvm_register(struct nvm_dev *dev)=0A=
>   	dev->dma_pool =3D dev->ops->create_dma_pool(dev, "ppalist",=0A=
>   						  exp_pool_size);=0A=
>   	if (!dev->dma_pool) {=0A=
> -		pr_err("nvm: could not create dma pool\n");=0A=
> +		pr_err("could not create dma pool\n");=0A=
>   		kref_put(&dev->ref, nvm_free);=0A=
>   		return -ENOMEM;=0A=
>   	}=0A=
> @@ -1214,7 +1215,7 @@ static int __nvm_configure_create(struct nvm_ioctl_=
create *create)=0A=
>   	up_write(&nvm_lock);=0A=
>=0A=
>   	if (!dev) {=0A=
> -		pr_err("nvm: device not found\n");=0A=
> +		pr_err("device not found\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
> @@ -1288,7 +1289,7 @@ static long nvm_ioctl_get_devices(struct file *file=
, void __user *arg)=0A=
>   		i++;=0A=
>=0A=
>   		if (i > 31) {=0A=
> -			pr_err("nvm: max 31 devices can be reported.\n");=0A=
> +			pr_err("max 31 devices can be reported.\n");=0A=
>   			break;=0A=
>   		}=0A=
>   	}=0A=
> @@ -1315,7 +1316,7 @@ static long nvm_ioctl_dev_create(struct file *file,=
 void __user *arg)=0A=
>=0A=
>   	if (create.conf.type =3D=3D NVM_CONFIG_TYPE_EXTENDED &&=0A=
>   	    create.conf.e.rsv !=3D 0) {=0A=
> -		pr_err("nvm: reserved config field in use\n");=0A=
> +		pr_err("reserved config field in use\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
> @@ -1331,7 +1332,7 @@ static long nvm_ioctl_dev_create(struct file *file,=
 void __user *arg)=0A=
>   			flags &=3D ~NVM_TARGET_FACTORY;=0A=
>=0A=
>   		if (flags) {=0A=
> -			pr_err("nvm: flag not supported\n");=0A=
> +			pr_err("flag not supported\n");=0A=
>   			return -EINVAL;=0A=
>   		}=0A=
>   	}=0A=
> @@ -1349,7 +1350,7 @@ static long nvm_ioctl_dev_remove(struct file *file,=
 void __user *arg)=0A=
>   	remove.tgtname[DISK_NAME_LEN - 1] =3D '\0';=0A=
>=0A=
>   	if (remove.flags !=3D 0) {=0A=
> -		pr_err("nvm: no flags supported\n");=0A=
> +		pr_err("no flags supported\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
> @@ -1365,7 +1366,7 @@ static long nvm_ioctl_dev_init(struct file *file, v=
oid __user *arg)=0A=
>   		return -EFAULT;=0A=
>=0A=
>   	if (init.flags !=3D 0) {=0A=
> -		pr_err("nvm: no flags supported\n");=0A=
> +		pr_err("no flags supported\n");=0A=
>   		return -EINVAL;=0A=
>   	}=0A=
>=0A=
>=0A=
=0A=