Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp5578121ybi; Sat, 20 Jul 2019 22:33:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqwzQCsEPHTVujLiRMxoDW3sTRwhpZ4nJ8EE1ej7wBCxMGvjwBav+9IXcZtyAvOCVclkMWYl X-Received: by 2002:a65:52c5:: with SMTP id z5mr50407109pgp.118.1563687226915; Sat, 20 Jul 2019 22:33:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563687226; cv=none; d=google.com; s=arc-20160816; b=zkfrTsb1IxEd6zr0RHIItT8iQw1uapNJvJkhCeBa9cMOmsA7zrxro5ylYvJxHDdCbK 7MwYLLMBf3rkWqLUUegVRxfCnddNwCBsghl23z0tPiLatqZ35gliCYNpiF9SfLuHu33H rVSnSQhqTQVnogOszctMzZyjw1j//hTonNIgUKCdl4oJqyyL2NkmybFdTb5oyN4kTbUl bIiPoJ8hakDp0D23JWL9DUZQ2FiOJ9d1jF9rvp+CrwFVVnpKvkdgtIbyjW9jenqWZbQl WwyprrKP/r7EhK+TKcwsu7Bk1GOzPfP76qVJ4Q37D2x6AICrlRGFPsJqSiWfBCd0tVlH 70Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=0Le7BqRT6Z0VrMYQMdMrccYxW568r9HQRKBhivo1yJg=; b=08EpJxVKqgvnIs9z2kwGnxulCHcNXCEC8HMKrzAktgJsH8Cu3J8jTMVHj/uLRtlx4l 863P8DNNcYKL/IubEKiF6EGT34kS0B+V7GpALfp3SYS5c+zOfXWeVK3HAO0dwJdVPL8C epK4ls8+mNvhm2Og+aMDFQZZnP7vBnOBlBgKseujotAdfmGdNW5gBzIySAj3AUFYJphx 56klowCn46EWFXqWUOJlCypzKrzBfxfY1opn7sE31LKg4D4qB4RMFD51X0/SfPMbX4HX /kImoDmjeSqFldNItomvee7L6I8m2E70jMe0eUeUEiQyfG21KcOJjhV4cJVEo6R0PF59 7lsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=I6f+R3oq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t23si5675418pjw.56.2019.07.20.22.33.30; Sat, 20 Jul 2019 22:33:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=I6f+R3oq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726179AbfGUFbY (ORCPT + 99 others); Sun, 21 Jul 2019 01:31:24 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:46944 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbfGUFbX (ORCPT ); Sun, 21 Jul 2019 01:31:23 -0400 Received: by mail-pl1-f196.google.com with SMTP id c2so17542417plz.13 for ; Sat, 20 Jul 2019 22:31:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=0Le7BqRT6Z0VrMYQMdMrccYxW568r9HQRKBhivo1yJg=; b=I6f+R3oqknatK1iJ86QwGrYUdJOvkd9qoPj1qFPvpbX8CZ2XUkdpP/UOZ4yWz/n1c2 X8WbLycy1TPVvPobwvAkMEz8K/7u1qn6fFx3mAeF3onx8Yxksxk7f9R7QgDLRySrGTVg R5gn8KyJiVzpAnt7xK9XSJMjCeTcgw1U2SCs1B4tOPp0X8V5eIHwNG0F9JpY8T7Ki4jz Vb4V2DrH42zxoNQU35vboGuRkONu3RuVqanw1W6o80A6E4gxFRYtR20loYVkbRIC0AUu NU5vC9vth9zv5iyUmy4AV+PbS6kRJZd76ElnUdD9BUM1OFNUVjjLOec2eUE3o+TZYm6G rsDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=0Le7BqRT6Z0VrMYQMdMrccYxW568r9HQRKBhivo1yJg=; b=kXvDQgDTkCxYcc8Yv2zRDwS1gm4NX5WbgVgRJnTWZvpD4IkBd7z08MQ56YGGWwlhAm PIO7pLO1RM5MqgGGEuwbTkklH/pMj4XdpV3LGvxGoWdftRXvOaRNDuiuvNYv2KkZpHez dVrDAy5Tml4dlO93PxtnehqwOtwlOwz+wu4otFSr7Kzla6A6p24DLI/8acIIVi4c4OPO 8CZVNu7qbsMSJOgcXbgoYfD0jZRDZg9vUhNAsWGavJMjigwCzJXp3XPS45+6+9lTNm/i ISEHOJSMrmwkpr/Ff/iN6WhxZdz2V8FRthnetMw6+Wy8vTMJGVyYZ5bMzEedm4KUt/V2 4I0Q== X-Gm-Message-State: APjAAAWW9kSGxn2+Y6wdnUknNoW2LK2E5ubHQfm+m3CHhSvjScn2s23u jG4b+AUpa6ucuFVBBUx3X/G+Ew== X-Received: by 2002:a17:902:aa95:: with SMTP id d21mr65141004plr.185.1563687078830; Sat, 20 Jul 2019 22:31:18 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id l4sm35574896pff.50.2019.07.20.22.31.17 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sat, 20 Jul 2019 22:31:18 -0700 (PDT) Date: Sat, 20 Jul 2019 22:31:17 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Waiman Long cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Roman Gushchin , Johannes Weiner , Shakeel Butt , Vladimir Davydov Subject: Re: [PATCH] mm, slab: Move memcg_cache_params structure to mm/slab.h In-Reply-To: <20190718180827.18758-1-longman@redhat.com> Message-ID: References: <20190718180827.18758-1-longman@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 18 Jul 2019, Waiman Long wrote: > The memcg_cache_params structure is only embedded into the kmem_cache > of slab and slub allocators as defined in slab_def.h and slub_def.h > and used internally by mm code. There is no needed to expose it in > a public header. So move it from include/linux/slab.h to mm/slab.h. > It is just a refactoring patch with no code change. > > In fact both the slub_def.h and slab_def.h should be moved into the mm > directory as well, but that will probably cause many merge conflicts. > > Signed-off-by: Waiman Long Acked-by: David Rientjes Thanks Waiman!