Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1562861865-23660-1-git-send-email-cai@lca.pw>
In-Reply-To: <1562861865-23660-1-git-send-email-cai@lca.pw>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun, 21 Jul 2019 09:58:04 -0700
Message-ID: <CAHk-=wgwd9vT1h7jKMU_E4ae2QLFFH69UxcXpO3J9YqEApdUNg@mail.gmail.com>
Subject: Re: [PATCH v2] iommu/amd: fix a crash in iova_magazine_free_pfns
To:     Qian Cai <cai@lca.pw>
Cc:     Joerg Roedel <jroedel@suse.de>, Christoph Hellwig <hch@lst.de>,
        iommu <iommu@lists.linux-foundation.org>,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 11, 2019 at 9:18 AM Qian Cai <cai@lca.pw> wrote:
>
> The commit b3aa14f02254 ("iommu: remove the mapping_error dma_map_ops
> method") incorrectly changed the checking from dma_ops_alloc_iova() in
> map_sg() causes a crash under memory pressure as dma_ops_alloc_iova()
> never return DMA_MAPPING_ERROR on failure but 0, so the error handling
> is all wrong.

This one seems to have fallen through the cracks.

Applied directly.

Maybe it's hiding in some fixes tree that I haven't gotten a pull
request for yet?

           Linus