Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751357AbVLFCje (ORCPT ); Mon, 5 Dec 2005 21:39:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751401AbVLFCje (ORCPT ); Mon, 5 Dec 2005 21:39:34 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:43162 "EHLO e3.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1751357AbVLFCje (ORCPT ); Mon, 5 Dec 2005 21:39:34 -0500 Subject: Re: [ckrm-tech] [RFC][PATCH] Add timestamp to process event connector message From: Dave Hansen To: Matt Helsley Cc: LKML , Andrew Morton , Jean-Pierre Dion , Guillaume Thouvenin , Badari Pulavarty , Ram Pai , CKRM-Tech , Erich Focht , elsa-devel , ay Lan , Erik Jacobson , Jack Steiner In-Reply-To: <1133835717.25202.1317.camel@stark> References: <1133835717.25202.1317.camel@stark> Content-Type: text/plain Date: Mon, 05 Dec 2005 18:39:23 -0800 Message-Id: <1133836764.6296.1.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.0.4 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1202 Lines: 34 On Mon, 2005-12-05 at 18:21 -0800, Matt Helsley wrote: > +static inline void get_timestamp(struct timespec *ts) > +{ > + unsigned int seq; > + struct timespec wall2mono; > + > + /* synchronize with settimeofday() changes */ > + do { > + seq = read_seqbegin(&xtime_lock); > + getnstimeofday(ts); > + wall2mono = wall_to_monotonic; > + } while(read_seqretry(&xtime_lock, seq)); > + > + /* adjust to monotonicaly-increasing values */ > + ts += wall2mono.tv_sec; > + ts += wall2mono.tv_nsec; > + while ((ts->tv_nsec - NSEC_PER_SEC) >= 0) { > + ts->tv_nsec -= NSEC_PER_SEC; > + ts->tv_sec++; > + } > +} This seems like something a bit too generic to have in your drivers/connector/cn_proc.c file. Is there a generic timekeeping function that should be used instead? Or, should this go into one of the timekeeping files? -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/