Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6423984ybi; Sun, 21 Jul 2019 17:41:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBjHXPhX0AN2dsqBb7K/Tr+Uyzr2knaHBGv7aIhext6HYlPMXtpLyN0csl4/YH7AakJPaL X-Received: by 2002:a17:90a:cb81:: with SMTP id a1mr72067937pju.81.1563756087518; Sun, 21 Jul 2019 17:41:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563756087; cv=none; d=google.com; s=arc-20160816; b=pmwGr85d/EFSxTQB0tsh8VlnrX9As2LFYPKKkZOkJK7pitvjV+Bi6dJr5xcCVCb/lS oTqdSO5dF3DMXhAws+rx6Gv4x/To4gjv9gMwTBTRdA3taHJp7gJt886UprzO++v3wnQF wfFzIYKqg7ZxqMrGQqPg8XbHNvlWSAVh8BcEguXfILWITg0B4z7yxfSkylP9ATRg0Rr0 rBOia5cmTYCZILYSL24fToAstVOeXh8pSrpBggF8nC9h3gsSNv1BMLfTw1o3Z3MkW/uq 9YHRgBRRQ+gb+Wh7jNh3a4+ryosJmWUyouH6SiPz6FRJXzyRm4bPu73G4ZBhuyTFfpuo 7Ndg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=60TYNH0hwVxrMOKDBgoWalRZn/KY6XzLLZo86nHK+LM=; b=rPUdYPEX/ZxIkdp4j+F2JN7CUTVfWVh7jFMrN4EcGLZG6Z6LVQtl7GQlgf1065VrJT s960/Szbwrsc/9lvqg3/7gAOIEi0fmIdRQLavR1/mXIjo5cUWMkiO1mgQxXSb9+pn10G noJKzzg0buNm2L6xyzXve0Q+PUuayYZE07zI/AGGrhWtRXhxNMksHNf1HnYd9LFgM0Br CIE3whoM6uycZX65UVR5tsyCC31BCuFdtp6IsJArE9CVFlDVOArWKe2WbKFyP1VMkwUG 8AA8pPzkgTMnVx3f64uFVcJgt1FH5ybtp0AXg1Z3poA3zOlY97iNhc2tGcxz/A22JScI h7eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lfo6EjXK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w20si8318320plp.394.2019.07.21.17.40.54; Sun, 21 Jul 2019 17:41:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lfo6EjXK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbfGVAjR (ORCPT + 99 others); Sun, 21 Jul 2019 20:39:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:48662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfGVAjR (ORCPT ); Sun, 21 Jul 2019 20:39:17 -0400 Received: from localhost (unknown [216.243.17.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1DDFF206BF; Mon, 22 Jul 2019 00:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563755956; bh=60TYNH0hwVxrMOKDBgoWalRZn/KY6XzLLZo86nHK+LM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lfo6EjXKW20c9vdPwQ/x+i/OsajsnIlxT+hvZhHcp1MKfFvwz35oJ0dNXe1d21t0S wcAWQs09moHV8rCicrYM7YclAYr144eTJFpweoYi9MOYnIbe1GgI7hfApJ7aTm9LUu OAcEG4TRq3uVgRwmfM6BoxXsOrXWRJw1ZdsIyNNQ= Date: Sun, 21 Jul 2019 20:39:15 -0400 From: Sasha Levin To: Daniel Drake Cc: Linux Kernel , stable@vger.kernel.org, Thomas Gleixner , Andy Lutomirski , Borislav Petkov , "H . Peter Anvin" , Linus Torvalds , Peter Zijlstra , Len Brown , Linux Upstreaming Team , "Wysocki, Rafael J" , Ingo Molnar Subject: Re: [PATCH AUTOSEL 5.1 013/219] x86/tsc: Use CPUID.0x16 to calculate missing crystal frequency Message-ID: <20190722003915.GB1607@sasha-vm> References: <20190715133811.2441-1-sashal@kernel.org> <20190715133811.2441-13-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 16, 2019 at 10:56:59AM +0800, Daniel Drake wrote: >Hi, > >On Mon, Jul 15, 2019 at 9:38 PM Sasha Levin wrote: >> From: Daniel Drake >> >> [ Upstream commit 604dc9170f2435d27da5039a3efd757dceadc684 ] > >In my opinion this is not stable kernel material. > >It alone does not solve a particular bug. It's part of a larger effort >to decrease usage of the 8254 PIT on modern platforms, which solves a >real problem (see "x86: skip PIT initialization on modern chipsets"), >but I'd conservatively recommend just leaving these patches out of the >stable tree. The problem has existed for a while without a >particularly wide impact, and there is a somewhat documented >workaround of changing BIOS settings. I've dropped it, thanks! -- Thanks, Sasha