Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Mime-Version: 1.0
Subject: Re: [PATCH] lightnvm: introduce pr_fmt for the previx nvm
Reply-To: minwoo.im@samsung.com
From:   Minwoo Im <minwoo.im@samsung.com>
To:     Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Minwoo Im <minwoo.im.dev@gmail.com>,
        Matias Bjorling <mb@lightnvm.io>,
        "javier@javigon.com" <javier@javigon.com>,
        "birkelund@gmail.com" <birkelund@gmail.com>
In-Reply-To: <BYAPR04MB5749126EF9E68D94125BACB486CA0@BYAPR04MB5749.namprd04.prod.outlook.com>
Message-ID: <20190722043101epcms2p2645d83b2c4aca7fc446f8d9109342327@epcms2p2>
Date:   Mon, 22 Jul 2019 13:31:01 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <BYAPR04MB5749126EF9E68D94125BACB486CA0@BYAPR04MB5749.namprd04.prod.outlook.com>
        <20190720083043.23387-1-minwoo.im.dev@gmail.com>
        <CGME20190720212747epcas1p4d3e17fefd1cbd2007a1a1a452dde9c55@epcms2p2>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)
> >   	int ret = -EINVAL;
> >
> >   	if (dev->ops->identity(dev)) {
> > -		pr_err("nvm: device could not be identified\n");
> > +		pr_err("device could not be identified\n");
> >   		goto err;
> >   	}
> >
> > -	pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",
> > +	pr_debug("ver:%u.%u nvm_vendor:%x\n",
> >   				geo->major_ver_id, geo->minor_ver_id,
> >   				geo->vmnt);
> The above last 2 lines can be squashed and pr_debug call can be made in
> 2 lines since you have removed the "nvm:" which shortens the first line.

Yeah Okay.  Will prepare V2 with this and also s/previx/prefix in the
title.

Thanks for the review.

Minwoo Im