Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1562917140-12035-1-git-send-email-wanpengli@tencent.com>
In-Reply-To: <1562917140-12035-1-git-send-email-wanpengli@tencent.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Mon, 22 Jul 2019 13:28:07 +0800
Message-ID: <CANRm+CwfjQfjS4SvUGnCLG-JNVyBLM=NB+Eu5u-=z1KiATjFKw@mail.gmail.com>
Subject: Re: [PATCH RESEND 1/2] KVM: LAPIC: Add pv ipi tracepoint
To:     LKML <linux-kernel@vger.kernel.org>, kvm <kvm@vger.kernel.org>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

ping,
On Fri, 12 Jul 2019 at 15:39, Wanpeng Li <kernellwp@gmail.com> wrote:
>
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Add pv ipi tracepoint.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Kr=C4=8Dm=C3=A1=C5=99 <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
>  arch/x86/kvm/lapic.c |  2 ++
>  arch/x86/kvm/trace.h | 25 +++++++++++++++++++++++++
>  2 files changed, 27 insertions(+)
>
> diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> index 42da7eb..403ae3f 100644
> --- a/arch/x86/kvm/lapic.c
> +++ b/arch/x86/kvm/lapic.c
> @@ -562,6 +562,8 @@ int kvm_pv_send_ipi(struct kvm *kvm, unsigned long ip=
i_bitmap_low,
>         irq.level =3D (icr & APIC_INT_ASSERT) !=3D 0;
>         irq.trig_mode =3D icr & APIC_INT_LEVELTRIG;
>
> +       trace_kvm_pv_send_ipi(irq.vector, min, ipi_bitmap_low, ipi_bitmap=
_high);
> +
>         if (icr & APIC_DEST_MASK)
>                 return -KVM_EINVAL;
>         if (icr & APIC_SHORT_MASK)
> diff --git a/arch/x86/kvm/trace.h b/arch/x86/kvm/trace.h
> index b5c831e..ce6ee34 100644
> --- a/arch/x86/kvm/trace.h
> +++ b/arch/x86/kvm/trace.h
> @@ -1462,6 +1462,31 @@ TRACE_EVENT(kvm_hv_send_ipi_ex,
>                   __entry->vector, __entry->format,
>                   __entry->valid_bank_mask)
>  );
> +
> +/*
> + * Tracepoints for kvm_pv_send_ipi.
> + */
> +TRACE_EVENT(kvm_pv_send_ipi,
> +       TP_PROTO(u32 vector, u32 min, unsigned long ipi_bitmap_low, unsig=
ned long ipi_bitmap_high),
> +       TP_ARGS(vector, min, ipi_bitmap_low, ipi_bitmap_high),
> +
> +       TP_STRUCT__entry(
> +               __field(u32, vector)
> +               __field(u32, min)
> +               __field(unsigned long, ipi_bitmap_low)
> +               __field(unsigned long, ipi_bitmap_high)
> +       ),
> +
> +       TP_fast_assign(
> +               __entry->vector =3D vector;
> +               __entry->min =3D min;
> +               __entry->ipi_bitmap_low =3D ipi_bitmap_low;
> +               __entry->ipi_bitmap_high =3D ipi_bitmap_high;
> +       ),
> +
> +       TP_printk("vector %d min 0x%x ipi_bitmap_low 0x%lx ipi_bitmap_hig=
h 0x%lx",
> +                 __entry->vector, __entry->min, __entry->ipi_bitmap_low,=
 __entry->ipi_bitmap_high)
> +);
>  #endif /* _TRACE_KVM_H */
>
>  #undef TRACE_INCLUDE_PATH
> --
> 2.7.4
>