Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6649216ybi; Sun, 21 Jul 2019 22:56:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7waYiMP8jhEtthe3Qg+RJrwFa4WInvZuYeCbsP9yTP2+OimRoK56gGRZh51IyPXD8sPw4 X-Received: by 2002:a63:60c1:: with SMTP id u184mr65880375pgb.275.1563774980434; Sun, 21 Jul 2019 22:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563774980; cv=none; d=google.com; s=arc-20160816; b=Su+km7y9Uch80d2MZRcnjk5FRGZPYCpuIT7UkEBEjBurSDMg7mmPXL43hvuX44C3al eMoU5uFD7/cHIlS0EnAR7MQiaOYmWmtbHz9gGa3I3dmVmXaZ3Kq3BImDTTncD7t0JYlg wVn57JZ0+L7Cu2RcZad5Z7GWAibHMEtM7X4/550u55AiASm+2yE9SIUiMsilCcR3kLQU GpH0lHZRZMDOr3CjIfZm29Brc4ZX5a8Ou/1jcCmKUctU/VnX4mB/YIbQibmB8BqFff5C JjUQo5YYuUz/Lx2MxRoOz3Ulu68wsnccLzQ8lw9bDxZ71bAxrYPieSaA5q1+ClrJ19Px Fjdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1ZZGpriDkfjat7kCBgBFRYCDd4cLAWDtCuZkaQFp9Yk=; b=MRVu+eZkyI2Hm2iCXlXukgxlzFylOGGh/ZvNMQOG3yx+wTGHW6EbIHzcpI490OK3jX E787ITjCH0VlmCoqL5ppuEEk0yAblf8terGRx3HlGr5ZfWsjVrG3UZ2WGzA4K1k957US HN7QKOVnDIW1oJx/BFGxsB/QATvqZjo9fueW0FK9bqa33xYpeQN9lZLNBn22iVmFug2O t8lDKCYEgHgsOgmyEeqBWvdCFeIR6k26fKoKSrRdUhrcYufR/TVoElDzwPmA1D3MNIHv 1TeB8Ldqy0YxCFFfs6uixDrGi3EDa1m6nGSMhg07bZG5ZgbbqFqz1vkUcL+e7E0/1FCd oJBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n184si7987494pgn.399.2019.07.21.22.56.04; Sun, 21 Jul 2019 22:56:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727795AbfGVEtt (ORCPT + 99 others); Mon, 22 Jul 2019 00:49:49 -0400 Received: from mga17.intel.com ([192.55.52.151]:61490 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfGVEtt (ORCPT ); Mon, 22 Jul 2019 00:49:49 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jul 2019 21:49:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,293,1559545200"; d="scan'208";a="170755148" Received: from iweiny-desk2.sc.intel.com ([10.3.52.157]) by fmsmga007.fm.intel.com with ESMTP; 21 Jul 2019 21:49:48 -0700 Date: Sun, 21 Jul 2019 21:49:48 -0700 From: Ira Weiny To: Bharath Vedartham Cc: arnd@arndb.de, sivanich@sgi.com, gregkh@linuxfoundation.org, jhubbard@nvidia.com, jglisse@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/3] sgi-gru: get_user_page changes Message-ID: <20190722044947.GA6157@iweiny-DESK2.sc.intel.com> References: <1563724685-6540-1-git-send-email-linux.bhar@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1563724685-6540-1-git-send-email-linux.bhar@gmail.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 21, 2019 at 09:28:02PM +0530, Bharath Vedartham wrote: > This patch series incorporates a few changes in the get_user_page usage > of sgi-gru. > > The main change is the first patch, which is a trivial one line change to > convert put_page to put_user_page to enable tracking of get_user_pages. > > The second patch removes an uneccessary ifdef of CONFIG_HUGETLB. > > The third patch adds __get_user_pages_fast in atomic_pte_lookup to retrive > a physical user page in an atomic context instead of manually walking up > the page tables like the current code does. This patch should be subject to > more review from the gup people. > > drivers/misc/sgi-gru/* builds after this patch series. But I do not have the > hardware to verify these changes. > > The first patch implements gup tracking in the current code. This is to be tested > as to check whether gup tracking works properly. Currently, in the upstream kernels > put_user_page simply calls put_page. But that is to change in the future. > Any suggestions as to how to test this code? > > The implementation of gup tracking is in: > https://github.com/johnhubbard/linux/tree/gup_dma_core > > We could test it by applying the first patch to the above tree and test it. > > More details are in the individual changelogs. > > Bharath Vedartham (3): I don't have an opinion on the second patch regarding any performance concerns since I'm not familiar with this hardware. But from a GUP POV For the series. Reviewed-by: Ira Weiny > sgi-gru: Convert put_page() to get_user_page*() > sgi-gru: Remove CONFIG_HUGETLB_PAGE ifdef > sgi-gru: Use __get_user_pages_fast in atomic_pte_lookup > > drivers/misc/sgi-gru/grufault.c | 50 +++++++---------------------------------- > 1 file changed, 8 insertions(+), 42 deletions(-) > > -- > 2.7.4 >