Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp6999543ybi; Mon, 22 Jul 2019 05:26:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/MDXLArchTJRoFWpBufUCfTgARQF279Y7gy7UBNp7ndPXhwm13Kg1PT/m5ruHeOpcOzKn X-Received: by 2002:a17:90a:1b4a:: with SMTP id q68mr76675879pjq.61.1563798398061; Mon, 22 Jul 2019 05:26:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563798398; cv=none; d=google.com; s=arc-20160816; b=RGIjUM0Nm5iORtnfcrRksmcAToZz1FSpjCNl9odzi9TdK27ITa8e/SG31irL/9aZzi bAqa658NkonuLQm1aGURhwOiFCheYnsteRHbr1jqv5TdnfcLQP0dZoLLzfx/q6EGTnZ3 hKumULgNf4w6tPFtINCNncc410BMV6KNikw0KTnukZQDwDEg2ZoE/eR1SRqrTnpotu2k lawHfpngDlTNl3ua1tz0iIs2uRs8kaMlsSIoY7W/IAH4ICiIhBYm1lrVHWawSJk9YhUO ELMh5cRkm2hi/ZkXfODN0KyfBsUY/A51vn0LLkE+zPlnJNjrRCdLHBGagOEN3Jc7H42A Pc6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=hvUQ4MT20tKEnT2pMZ7Qie/6Rn5UWcYUzvG9+P0UE/8=; b=WY9rjNIzc8DNDqFAqGD0P3nIs9kmd7N1IKc5i+CjzEDkKqRhjibdwTcK/Q189LaXER vFu2SJvGs28iyn6q739CL4f+1t70NfmjUEjQNzRz/D+y2XTzG8GqvqBVjIWL+VIjL3Ee vqAsm/aE3HNZodpoFButbKnLDvL1wZ7B74AD5f/qVrLPHoOIPyElzd060h3Ah1bWWzVu fixRFxaOJ8dgvdlOSPKlHQJQaEQTrYwjtQiXh1fFQDI7/f3DMSSpUYSeI8clWLSsap5B w+Bxgg85140A7QIKc/jbz4g7Dem28JF+bf1INqZSzhy3LO/Ahd9wkbA8zGDvUB3Lb7HB 1Tkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dYaKDwKp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f17si12871065pgh.552.2019.07.22.05.26.22; Mon, 22 Jul 2019 05:26:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=dYaKDwKp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729478AbfGVKVR (ORCPT + 99 others); Mon, 22 Jul 2019 06:21:17 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:35820 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729058AbfGVKVR (ORCPT ); Mon, 22 Jul 2019 06:21:17 -0400 Received: by mail-io1-f66.google.com with SMTP id m24so72739092ioo.2 for ; Mon, 22 Jul 2019 03:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hvUQ4MT20tKEnT2pMZ7Qie/6Rn5UWcYUzvG9+P0UE/8=; b=dYaKDwKpIZsV5pduCcPqszK2xafHORORi23hMrluYgXxvXwZ6dZdVL7FOzeTDVydXl 1lvWYU8fD2tG8tIKqdZ+U3AsXVUw4FkNt9pJpT73MzVSEhP+LLbyzGIA59mvQS18tOzx 2Ib0UEcbutKUUKnU5bMNa8VwuD2MwQEk3XouU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hvUQ4MT20tKEnT2pMZ7Qie/6Rn5UWcYUzvG9+P0UE/8=; b=LJdsS79Y8mRnfEtxmAjSf7siW1Lw8Cb83/Kti44vmpwp/aiKQ4XJOvk0Vg5tDoE7Sy DXrXyJKyel2UIy17329Ar4+j5Ad1Wsu1SpLtJ2myU+6W4lnap2m9wzpS7TeUSvsFL4vA JFE1nr9bzUsSg9mpzSTKhXqmeMugWCiQ1DV0GEuG8s703cZ4vv3DjFZLgHVDiYdJEXpZ R6FXsLeP941Ml6v/dwMudXTE8VRAymZCT4k57Splq9oNaSmPMAz3ABkrm3YK8KCh7nzZ t/H1FlWakYj91zsT3Gq68+nbp4/0dd0sfnfWEDmDUDTvXobhOW8bZ0mXdOuaDL99amlt B9ng== X-Gm-Message-State: APjAAAW+pqcg5ZFKCgqdPlE7y2v3aofnSBAJuUnieHp9sg1MPguVP6kf e6VT6EOhFkufuplIQllYbzlgURLbLytDrGnIfHY2Yw== X-Received: by 2002:a5d:83cd:: with SMTP id u13mr61250280ior.297.1563790876111; Mon, 22 Jul 2019 03:21:16 -0700 (PDT) MIME-Version: 1.0 References: <20190614142406.ybdiqfppo5mc5bgq@flea> <20190625144930.5hegt6bkzqzykjid@flea> <20190703114933.u3x4ej3v7ocewvif@flea> <20190711100100.cty3s6rs3w27low6@flea> <20190720065830.zn3txpyduakywcva@flea> <20190720093202.6fn6xmhvsgawscnu@flea> In-Reply-To: <20190720093202.6fn6xmhvsgawscnu@flea> From: Jagan Teki Date: Mon, 22 Jul 2019 15:51:04 +0530 Message-ID: Subject: Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI To: Maxime Ripard Cc: Michael Nazzareno Trimarchi , David Airlie , Daniel Vetter , Chen-Yu Tsai , Michael Turquette , Rob Herring , Mark Rutland , linux-arm-kernel , linux-kernel , linux-clk , dri-devel , devicetree , linux-amarula , linux-sunxi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, On Sat, Jul 20, 2019 at 3:02 PM Maxime Ripard wrote: > > On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote: > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard > > wrote: > > > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi wrote: > > > > > > tcon-pixel clock is the rate that you want to achive on display side > > > > > > and if you have 4 lanes 32bit or lanes and different bit number that > > > > > > you need to have a clock that is able to put outside bits and speed > > > > > > equal to pixel-clock * bits / lanes. so If you want a pixel-clock of > > > > > > 40 mhz and you have 32bits and 4 lanes you need to have a clock of > > > > > > 40 * 32 / 4 in no-burst mode. I think that this is done but most of > > > > > > the display. > > > > > > > > > > So this is what the issue is then? > > > > > > > > > > This one does make sense, and you should just change the rate in the > > > > > call to clk_set_rate in sun4i_tcon0_mode_set_cpu. > > > > > > > > > > I'm still wondering why that hasn't been brought up in either the > > > > > discussion or the commit log before though. > > > > > > > > > Something like this? > > > > > > > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 20 +++++++++++--------- > > > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 2 -- > > > > 2 files changed, 11 insertions(+), 11 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > index 64c43ee6bd92..42560d5c327c 100644 > > > > --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c > > > > @@ -263,10 +263,11 @@ static int sun4i_tcon_get_clk_delay(const struct > > > > drm_display_mode *mode, > > > > } > > > > > > > > static void sun4i_tcon0_mode_set_common(struct sun4i_tcon *tcon, > > > > - const struct drm_display_mode *mode) > > > > + const struct drm_display_mode *mode, > > > > + u32 tcon_mul) > > > > { > > > > /* Configure the dot clock */ > > > > - clk_set_rate(tcon->dclk, mode->crtc_clock * 1000); > > > > + clk_set_rate(tcon->dclk, mode->crtc_clock * tcon_mul * 1000); > > > > > > > > /* Set the resolution */ > > > > regmap_write(tcon->regs, SUN4I_TCON0_BASIC0_REG, > > > > @@ -335,12 +336,13 @@ static void sun4i_tcon0_mode_set_cpu(struct > > > > sun4i_tcon *tcon, > > > > u8 bpp = mipi_dsi_pixel_format_to_bpp(device->format); > > > > u8 lanes = device->lanes; > > > > u32 block_space, start_delay; > > > > - u32 tcon_div; > > > > + u32 tcon_div, tcon_mul; > > > > > > > > - tcon->dclk_min_div = SUN6I_DSI_TCON_DIV; > > > > - tcon->dclk_max_div = SUN6I_DSI_TCON_DIV; > > > > + tcon->dclk_min_div = 4; > > > > + tcon->dclk_max_div = 127; > > > > > > > > - sun4i_tcon0_mode_set_common(tcon, mode); > > > > + tcon_mul = bpp / lanes; > > > > + sun4i_tcon0_mode_set_common(tcon, mode, tcon_mul); > > > > > > > > /* Set dithering if needed */ > > > > sun4i_tcon0_mode_set_dithering(tcon, sun4i_tcon_get_connector(encoder)); > > > > @@ -366,7 +368,7 @@ static void sun4i_tcon0_mode_set_cpu(struct > > > > sun4i_tcon *tcon, > > > > */ > > > > regmap_read(tcon->regs, SUN4I_TCON0_DCLK_REG, &tcon_div); > > > > tcon_div &= GENMASK(6, 0); > > > > - block_space = mode->htotal * bpp / (tcon_div * lanes); > > > > + block_space = mode->htotal * tcon_div * tcon_mul; > > > > block_space -= mode->hdisplay + 40; > > > > > > > > regmap_write(tcon->regs, SUN4I_TCON0_CPU_TRI0_REG, > > > > @@ -408,7 +410,7 @@ static void sun4i_tcon0_mode_set_lvds(struct > > > > sun4i_tcon *tcon, > > > > > > > > tcon->dclk_min_div = 7; > > > > tcon->dclk_max_div = 7; > > > > - sun4i_tcon0_mode_set_common(tcon, mode); > > > > + sun4i_tcon0_mode_set_common(tcon, mode, 1); > > > > > > > > /* Set dithering if needed */ > > > > sun4i_tcon0_mode_set_dithering(tcon, sun4i_tcon_get_connector(encoder)); > > > > @@ -487,7 +489,7 @@ static void sun4i_tcon0_mode_set_rgb(struct > > > > sun4i_tcon *tcon, > > > > > > > > tcon->dclk_min_div = 6; > > > > tcon->dclk_max_div = 127; > > > > - sun4i_tcon0_mode_set_common(tcon, mode); > > > > + sun4i_tcon0_mode_set_common(tcon, mode, 1); > > > > > > > > /* Set dithering if needed */ > > > > sun4i_tcon0_mode_set_dithering(tcon, connector); > > > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > index 5c3ad5be0690..a07090579f84 100644 > > > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > > > @@ -13,8 +13,6 @@ > > > > #include > > > > #include > > > > > > > > -#define SUN6I_DSI_TCON_DIV 4 > > > > - > > > > struct sun6i_dsi { > > > > struct drm_connector connector; > > > > struct drm_encoder encoder; > > > > > > I had more something like this in mind: > > > http://code.bulix.org/nlp5a4-803511 > > > > Worth to look at it. was it working on your panel? meanwhile I will check it. > > I haven't tested it. > > > We have updated with below change [1], seems working on but is > > actually checking the each divider as before start with 4... till 127. > > > > This new approach, is start looking the best divider from 4.. based on > > the idea vs rounded it will ended up best divider like [2] > > But why? > > I mean, it's not like it's the first time I'm asking this... > > If the issue is what Micheal described, then the divider has nothing > to do with it. We've had that discussion over and over again. This is what Michael is mentioned in above mail "tcon-pixel clock is the rate that you want to achive on display side and if you have 4 lanes 32bit or lanes and different bit number that you need to have a clock that is able to put outside bits and speed equal to pixel-clock * bits / lanes. so If you want a pixel-clock of 40 mhz and you have 32bits and 4 lanes you need to have a clock of 40 * 32 / 4 in no-burst mode. " He is trying to manage the bpp/lanes into dclk_mul (in last mail) and it can multiply with pixel clock which is rate argument in sun4i_dclk_round_rate. The solution I have mentioned in dclk_min, max is bpp/lanes also multiple rate in dotclock sun4i_dclk_round_rate. In both cases the overall pll_rate depends on dividers, the one that I have on this patch is based on BSP and the Michael one is more generic way so-that it can not to touch other functionalities and looping dividers to find the best one. If dclk_min/max is bpp/lanes then dotclock directly using divider 6 (assuming 24-bit and 4 lanes) and return the pll_rate and divider 6 associated. if dclk_mul is bpp/lanes, on Michael new change, the dividers start with 4 and end with 127 but the constant ideal rate which rate * bpp/lanes but the loop from sun4i_dclk_round_rate computed the divider as 6 only, ie what I'm mentioned on the above mail. Jagan.