Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7021165ybi; Mon, 22 Jul 2019 05:50:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqxl/4IbMGgi8b0bsqc9dGUtlHWBUqEjTRqQh67gupwCAERBLnbwuyFWAOxRSKKj74DMvd4Y X-Received: by 2002:aa7:9359:: with SMTP id 25mr89893pfn.261.1563799844615; Mon, 22 Jul 2019 05:50:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563799844; cv=none; d=google.com; s=arc-20160816; b=tNJSD/9XzultycMY2kVkOT2AsusBBi7nwD5htJqqoKJ3B+tZGiiHhFKPHxPSfGNjfR 6ONqqRYISZ0XB+N12V54ydZyGsZxazHTlDp1ySt1nVXJlVZj307PcTocypaTwXt4Zr8e ingMXqP0pK2bRYldDMr8KY44RK7f5FSc4Pf/3fUw3CNor3yaywlRLuitZhh55IynVSxK OGj3oS4r3zW0kFyrVDf/JTF9bVsZcuFR2NelNan+JUWD5uyC5o0kKWe8WPE4bnTOcylQ XkZTt7zsktcQB6jsYgReqwnStzTrfqwXfNtB1Rue5/jVndbKlxVGZfwiq5inYFCJpQMh ZuYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=Wct+IzEygVqP6Q8TYVaAVumlDUN4cfz/yif6Gxo/tw8=; b=MLa2URtshJIfWztPp37A1bryr/z8FwtwFZq5k57z93L6xBC3OXd0YNeJhOTPUcqBJd Z0BPhXBbj6sd+7lMfihlwK5EjUa+wBdodJTtM6SQSm2MKTNVrLiCljf0GkuSYHen7gFG rDSpxEi5EmB6dvhE5JR/uwitcGSNTILg7I/9MSAAgmAHnboBsJ0rlx5p2ivTz6fzMuTs F4+HClbd+T4IUxji4Fuwlqp0wphgR8vAwlsz4YMuk3AFVKI2zUSrkKi05LacGB0K/ehG /pZREcEYITexnbEqcsjZrLKJtJOWsTvRND57vqjMO1ju7EjNE7FJIUuTJ1Drelyc8oKo tdcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=PNibAy43; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c19si10773496pfi.256.2019.07.22.05.50.28; Mon, 22 Jul 2019 05:50:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=PNibAy43; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730161AbfGVMFo (ORCPT + 99 others); Mon, 22 Jul 2019 08:05:44 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:17436 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728825AbfGVMFo (ORCPT ); Mon, 22 Jul 2019 08:05:44 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 22 Jul 2019 05:05:43 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 22 Jul 2019 05:05:43 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 22 Jul 2019 05:05:43 -0700 Received: from [10.21.132.148] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 22 Jul 2019 12:05:40 +0000 Subject: Re: [PATCH net-next 3/3] net: stmmac: Introducing support for Page Pool To: Jose Abreu , Lars Persson , Ilias Apalodimas CC: "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Maxime Coquelin , Maxime Ripard , Chen-Yu Tsai , linux-tegra References: <1b254bb7fc6044c5e6e2fdd9e00088d1d13a808b.1562149883.git.joabreu@synopsys.com> <29dcc161-f7c8-026e-c3cc-5adb04df128c@nvidia.com> <20190722101830.GA24948@apalos> From: Jon Hunter Message-ID: <11557fe0-0cba-cb49-0fb6-ad24792d4a53@nvidia.com> Date: Mon, 22 Jul 2019 13:05:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1563797144; bh=Wct+IzEygVqP6Q8TYVaAVumlDUN4cfz/yif6Gxo/tw8=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=PNibAy43DkOfCZXujQ+oIlkFaXMLgCtH1v+taBS8cGUIiU0evlUB7V9zOXN4sQOau HlQ4f4dK9AZN04vDcSvwaokfFbBvcHTcgrGaBQ2jBm6uoQiDS6Fa/lqKjLCWaRnNYb ZbQP59O2rdrAfbZZ5iYZozxEymBlIFVUaZb3A54R58A8Ank3/+p5eJ1IjTOOEJWqhf G5QiV1aLp0nAtT9itlBMwOopzCCwzrSn7M57P/jxyOdqI+oyUDuYGo1YeNrwNsA7C0 AHKsFt8bngZn0DkdDvzgxQSKQyrv/4GjvvIwuxX3fJfXB7GM4SCwLoARbh5u+/SVCD imJ38IlTHve3g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/2019 12:39, Jose Abreu wrote: > From: Lars Persson > Date: Jul/22/2019, 12:11:50 (UTC+00:00) > >> On Mon, Jul 22, 2019 at 12:18 PM Ilias Apalodimas >> wrote: >>> >>> On Thu, Jul 18, 2019 at 07:48:04AM +0000, Jose Abreu wrote: >>>> From: Jon Hunter >>>> Date: Jul/17/2019, 19:58:53 (UTC+00:00) >>>> >>>>> Let me know if you have any thoughts. >>>> >>>> Can you try attached patch ? >>>> >>> >>> The log says someone calls panic() right? >>> Can we trye and figure were that happens during the stmmac init phase? >>> >> >> The reason for the panic is hidden in this one line of the kernel logs: >> Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b >> >> The init process is killed by SIGSEGV (signal 11 = 0xb). >> >> I would suggest you look for data corruption bugs in the RX path. If >> the code is fetched from the NFS mount then a corrupt RX buffer can >> trigger a crash in userspace. >> >> /Lars > > > Jon, I'm not familiar with ARM. Are the buffer addresses being allocated > in a coherent region ? Can you try attached patch which adds full memory > barrier before the sync ? TBH I am not sure about the buffer addresses either. The attached patch did not help. Same problem persists. Jon -- nvpublic