Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7025739ybi; Mon, 22 Jul 2019 05:56:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqxj3/PFaIqBtM4HewQcPMRTjZWwwsNlMF5nPzPykLEqAMlOn/ta0mCgUBXzGy2jkDizQngQ X-Received: by 2002:a63:550e:: with SMTP id j14mr64977854pgb.302.1563800186879; Mon, 22 Jul 2019 05:56:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563800186; cv=none; d=google.com; s=arc-20160816; b=BdcVXNeieD6HtXu0kWC6qaAx20oFc+sXYNmcn+GqP0TFbysMiEw4VPeh8x/pZYCxw0 ylCYHc+hcSK8vNtwI1fX9Aova9Ti2bDSayuqGPOnz6yV/gLPEbC/OD4wwUhpkH+UxdY3 Q/az80K8OpAAQl3dMon01SHuq71mf43Khhwc7GUw8553jW/vgQXWWneO16eWj/qCRMvo 6NyRvTNtiih5wIgrTXCkG3bLXIz246FQNjjEPxTkBI4Cq9S8N/TZDKW9sGuEOncjz++H XrJThrBh9PH19+gSfvBIR1CbVOlsg9TSGdkigMRABWyt6SHjT/yj9TNQzozM1JqRhAL2 DOrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=IALTeLniVATet6Lo8hMBMp8eFWvstEO5L1iPMadI4Tk=; b=VgVxRPtB7px4VPy4cS9ppGErxFYwJhBYi0nt+AseGniLIc4RLhajH0fHGan6IrFWXX CapAt0BRQbD4q7ptlacYpEHVeZcd6ikjkVco5ePKE81LRHlmEkoO2Na65gNzYe8kMS58 Sz+RQNO9WOdt8jqMrqsErUN+17UPaCdHxtvE2LPgVxiOIXOnhDcsie8eyOaGDY529DnE mf3B9O07u2dDXZA3VEp3AzxLlW7yj6CIw2Oxon3FEYgL4c+aEb9qnAGcZzSKaRNmjhRg byzRpr84/Fsrx4Tf8AcTYvp1e7/ASOwwwAW3FSGwz1X3RPhHNnDDvo/OJYBNhT25FUEt rAIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=uHeYMiMO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 85si13846286pgb.583.2019.07.22.05.56.11; Mon, 22 Jul 2019 05:56:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=uHeYMiMO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730346AbfGVMWd (ORCPT + 99 others); Mon, 22 Jul 2019 08:22:33 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58920 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730306AbfGVMW1 (ORCPT ); Mon, 22 Jul 2019 08:22:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=IALTeLniVATet6Lo8hMBMp8eFWvstEO5L1iPMadI4Tk=; b=uHeYMiMOAL7x Vx6NS/y1Z7uUpYvC2KBO8HfZsE+HyS5/QaIGoT36h/ES2qZ4Uu76r+iYF4OGI0AZvMztU9JEP2v7q cDylvYUgmYFAby3kpjY103b4j/F1q2g4cSBS47Jvy/MEHAnPZNtGbzdRzGAfH0ly1bRoV3QiySGUU Zga+I=; Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hpXKT-0007dC-72; Mon, 22 Jul 2019 12:22:09 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 845DB2740463; Mon, 22 Jul 2019 13:22:08 +0100 (BST) From: Mark Brown To: Hariprasad Kelam Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Liam Girdwood , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Mark Brown , Matthias Brugger , Shunli Wang , Takashi Iwai , Tzung-Bi Shih Subject: Applied "sound: soc: codecs: mt6358: change return type of mt6358_codec_init_reg" to the asoc tree In-Reply-To: <20190709182543.GA6611@hari-Inspiron-1545> X-Patchwork-Hint: ignore Message-Id: <20190722122208.845DB2740463@ypsilon.sirena.org.uk> Date: Mon, 22 Jul 2019 13:22:08 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch sound: soc: codecs: mt6358: change return type of mt6358_codec_init_reg has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 1d3dd532883be6167da5df6117efd6d4e8790456 Mon Sep 17 00:00:00 2001 From: Hariprasad Kelam Date: Tue, 9 Jul 2019 23:55:43 +0530 Subject: [PATCH] sound: soc: codecs: mt6358: change return type of mt6358_codec_init_reg As mt6358_codec_init_reg function always returns 0 , change return type from int to void. fixes below issue reported by coccicheck sound/soc/codecs/mt6358.c:2260:5-8: Unneeded variable: "ret". Return "0" on line 2289 Signed-off-by: Hariprasad Kelam Acked-by: Tzung-Bi Shih Link: https://lore.kernel.org/r/20190709182543.GA6611@hari-Inspiron-1545 Signed-off-by: Mark Brown --- sound/soc/codecs/mt6358.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c index 50b3fc5457ea..c17250aab2d0 100644 --- a/sound/soc/codecs/mt6358.c +++ b/sound/soc/codecs/mt6358.c @@ -2255,10 +2255,8 @@ static struct snd_soc_dai_driver mt6358_dai_driver[] = { }, }; -static int mt6358_codec_init_reg(struct mt6358_priv *priv) +static void mt6358_codec_init_reg(struct mt6358_priv *priv) { - int ret = 0; - /* Disable HeadphoneL/HeadphoneR short circuit protection */ regmap_update_bits(priv->regmap, MT6358_AUDDEC_ANA_CON0, RG_AUDHPLSCDISABLE_VAUDP15_MASK_SFT, @@ -2285,8 +2283,6 @@ static int mt6358_codec_init_reg(struct mt6358_priv *priv) /* set gpio */ playback_gpio_reset(priv); capture_gpio_reset(priv); - - return ret; } static int mt6358_codec_probe(struct snd_soc_component *cmpnt) -- 2.20.1