Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7075314ybi; Mon, 22 Jul 2019 06:44:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEzTG7M6/btOvxcL/flN0xeGl7IUKq9tLH0y2YmxdfZkfQrhP+wUHYVe3hV8XThlMIdXdg X-Received: by 2002:a17:90a:bc0c:: with SMTP id w12mr45651825pjr.111.1563803072036; Mon, 22 Jul 2019 06:44:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563803072; cv=none; d=google.com; s=arc-20160816; b=XFNv/oIBjvU45VCk40BIYvGATgDmZo2402/FDc9tpq/HS8h8hhsLV6sem/pF2ayDha vea8FgH3DXfrO6rWuw3vS+/Ab8sIOu5g/K9ge9AtpRLzWPYDOboJ4cqZnh2nLNRyHG1t Sqd0fcE8cl7mYhJ/tUgorsNu6Su5SroTL9uevowDzZCPszgohEKHpTPmIC25yCBmL2cc iy9CwMUIcJOzEKWZWCpKGrZMrWpQDc3+uMayJyQJiQF+YN4gnC45uX2gq4zmeKvGg628 52X50ssaMFEWjN3M6ZQcX0+Fw2o7FUM7QvSjaGZTMhA4vDrLVzBr5/rVAWw1KanDChYG VrhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=JfWmDXv4BPNqOTEY9hU9q6gKX1IYDQYRoMyC7yt2MNI=; b=w+rTfBByfRac1+ce0yxW96iNst2uDsVZaLzBvHrEtNkULVzLRXb+XDMy8AI6zO1jzT z2KH/Xx7EaU2cI9X6yp2hWA0LiM+4RdSKhXDdsfJiK27nEMTCH6nvO2TZdk9XHC2mp+e 4C0FW5ADit5Dq6XxdTW7GlvH0bz4fImeg4MBE86WFk+Wk3XqJzkOVVYkp1EG/1vtc+9V jgU1RH8ATQmysYWFL3hJnhj2WENxlyCN7jkv151e0rrTAuOZdN6x3YyIOnz5OhB1ffxc l43robUhDIX+jQUvEQenbyxUl2dfos9/PqEKvtPsTKF1qP2JUtAL8rL8UAswAah7S+XJ JEjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="E/But+Yu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i26si479718pgm.250.2019.07.22.06.44.16; Mon, 22 Jul 2019 06:44:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="E/But+Yu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730589AbfGVNnn (ORCPT + 99 others); Mon, 22 Jul 2019 09:43:43 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:34072 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730575AbfGVNnm (ORCPT ); Mon, 22 Jul 2019 09:43:42 -0400 Received: by mail-vk1-f194.google.com with SMTP id v68so4107498vkd.1 for ; Mon, 22 Jul 2019 06:43:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JfWmDXv4BPNqOTEY9hU9q6gKX1IYDQYRoMyC7yt2MNI=; b=E/But+YuUKIzOcn6HUyy4svfKw8XGm9k9ye+AQjkaG9X/TWQ3EMinTa8z7xp3u05Ky JWLgAuxe+lrOiI6YgBbO1YHkcwMk6k9b1ZRdkUtPGe/4LwAz1LutDwQ5KqLZ7Z3lJ5Yv 6Aab+564w4FX4UBEEuWjzVfV67IBm1INTk5+0MvliPxcuFfyrM6BdfkDALKnY9IIkVKq qjRaHqKPO3eI5FFDdjleOVM/8YI/580dxzUMI/vSffxY/2VAgjXK7Azfvw9IQUmo+Ise qXJvgJTr3m1dzRR0XTuq6QeYuVikSCmxtlV7q25GKKMyCmReGzDEOYl/7YtUodEuC0UN UtOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JfWmDXv4BPNqOTEY9hU9q6gKX1IYDQYRoMyC7yt2MNI=; b=ozQTYBSCpHA2S0b34wj/YNnx8+dWEYm8o0mApfhoPowycgKvB8n2cYCErAorabFhf6 4LyT/JyPrz+G5rDmf0+CutcLmf67D8byRTiJL4hm9zlZqUlIZEA6w55eOSaxjTnDrqfq gkp0F+y6x2SgF5KGODhqNysZCtk2CUHvr+ghJPy0jaHqRpDqRBTTqtbsrwyuf6SXWKv9 KpVXR1S3pL58JLV2i/VNoGC0Gr8YBF9tvYlrleFdRh67WKvJQEVKEQtekfGlRIfmyb2Q +cQZ10F/f/V8s1FutK9oKAUiWvLY5SEPshUQ0PzVVLOG8gXrZKJXsehpMzPdFTvEb8+t +xVA== X-Gm-Message-State: APjAAAWnvDAtfPOzpYOFBXM6yoalsh6Oxzp12s7w045V0a2IkPBQL9uT yG3lYD8Wtpqu/8SSL6MVNrFkwVPmc7r2njqwdswOgQ== X-Received: by 2002:a1f:f282:: with SMTP id q124mr25220311vkh.4.1563803021647; Mon, 22 Jul 2019 06:43:41 -0700 (PDT) MIME-Version: 1.0 References: <94dcbeb13b08a67ae9f404aa590c1c1459bc5287.1562734889.git.joe@perches.com> In-Reply-To: <94dcbeb13b08a67ae9f404aa590c1c1459bc5287.1562734889.git.joe@perches.com> From: Ulf Hansson Date: Mon, 22 Jul 2019 15:43:05 +0200 Message-ID: Subject: Re: [PATCH 06/12] mmc: meson-mx-sdio: Fix misuse of GENMASK macro To: Joe Perches Cc: Andrew Morton , Kevin Hilman , "linux-mmc@vger.kernel.org" , Linux ARM , "open list:ARM/Amlogic Meson..." , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Jul 2019 at 07:04, Joe Perches wrote: > > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches Applied for fixes by adding a fixes+stable tag, thanks! Kind regards Uffe > --- > drivers/mmc/host/meson-mx-sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c > index 2d736e416775..ba9a63db73da 100644 > --- a/drivers/mmc/host/meson-mx-sdio.c > +++ b/drivers/mmc/host/meson-mx-sdio.c > @@ -73,7 +73,7 @@ > #define MESON_MX_SDIO_IRQC_IF_CONFIG_MASK GENMASK(7, 6) > #define MESON_MX_SDIO_IRQC_FORCE_DATA_CLK BIT(8) > #define MESON_MX_SDIO_IRQC_FORCE_DATA_CMD BIT(9) > - #define MESON_MX_SDIO_IRQC_FORCE_DATA_DAT_MASK GENMASK(10, 13) > + #define MESON_MX_SDIO_IRQC_FORCE_DATA_DAT_MASK GENMASK(13, 10) > #define MESON_MX_SDIO_IRQC_SOFT_RESET BIT(15) > #define MESON_MX_SDIO_IRQC_FORCE_HALT BIT(30) > #define MESON_MX_SDIO_IRQC_HALT_HOLE BIT(31) > -- > 2.15.0 >