Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7181620ybi; Mon, 22 Jul 2019 08:26:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqybpAou8xDI5Pwh5fKB3BVZaC8+w+gcKUtqO2qsFFrPlnd5Gc0TAoFfNRkYJ2m4mBmQWVXI X-Received: by 2002:a63:6110:: with SMTP id v16mr26137506pgb.81.1563809203701; Mon, 22 Jul 2019 08:26:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563809203; cv=none; d=google.com; s=arc-20160816; b=GgHknMiRkwGwCL3ymq9ytaw1GuCgUac8HhJVChC7DebMV4ReTxoiihQuvH1UOsvztt wEjymxd1jJZEEF9xZVwOm+PBtfXCMn+9nO8lnVcbsI+XIShUYn3n14Kmnb5yRmzia6dY u2wJrH7V8PQ0Ke2nDl9q/Ifq6l3bmbq9LWE70PY2KHt1fK0yI7eBz5Uu3KjjNQxefpJ3 4/UNoSJtE3lJerFex4Z/q1POmYD3Fz6/LsBBJ53IcI3muUXVMSAuG6CtxNlffqDtlHm5 9jPOsiU0IrrQ9D8HAoyB8ZHFtQtkuzjNsKMW24z5lSaVN01Ybw+LNdv0d0InHcT+xRfu TXFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=pxUJWhZ25yHUxPiSqRCgCdedu7AEcSBCRQ4DgPSgERA=; b=Jhh+aLLd28N+swyenuJasetusHlFjepllreto7QsjTSGwlP3Vo+EYRiL5I1FbIHD9S zkNPHDo3EKRLrzxO3X/v+s3qtKVmaWQXdKXas4h1EWhuVk78ap4+JdsbT57PyitpoOfN ZT+Jrsv5TFjejVvp8NhWYxgQetq+KSF9uUBRy11S6qmRmJtBOhyENalrpA4GO14y9Ged rVWXJbZJ4vgGJdz5YDGkxNO31KWy9G+cCUgwxTWBteNMzX775b8onW/zZlZ09VQqf4Ur UhQeMvOfYnjuzHUwrJSDpGvHlOTflJeU1dIvozXMyqbQZ+ZHNKBK2DKmQMmVUa3RgOLl SEBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=u9+rSVMB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y187si9375943pgd.66.2019.07.22.08.26.15; Mon, 22 Jul 2019 08:26:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=u9+rSVMB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730285AbfGVMWV (ORCPT + 99 others); Mon, 22 Jul 2019 08:22:21 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58606 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728802AbfGVMWT (ORCPT ); Mon, 22 Jul 2019 08:22:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=pxUJWhZ25yHUxPiSqRCgCdedu7AEcSBCRQ4DgPSgERA=; b=u9+rSVMBKZ1Y WaHP3zX4NIjP2JLNV2DivzNdfj8VmA2zcF181yPOgEYdW6mwBtnlkmf07ReTSbX9od0rV+q76P0wO UNYxxVOhSI2i3yaonUd4gVptifywcotkqyRadsCxouLYh+/SLmFxQXVFMMU25eQVk+lwZKO4qbXex d9v4A=; Received: from ypsilon.sirena.org.uk ([2001:470:1f1d:6b5::7]) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1hpXKS-0007cy-S9; Mon, 22 Jul 2019 12:22:08 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 1E4492742B67; Mon, 22 Jul 2019 13:22:08 +0100 (BST) From: Mark Brown To: Hariprasad Kelam Cc: alsa-devel@alsa-project.org, Dan Carpenter , Gen Zhang , Jaroslav Kysela , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Srinivas Kandagatla , Takashi Iwai , Vinod Koul Subject: Applied "sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag" to the asoc tree In-Reply-To: <20190710021627.GA13396@hari-Inspiron-1545> X-Patchwork-Hint: ignore Message-Id: <20190722122208.1E4492742B67@ypsilon.sirena.org.uk> Date: Mon, 22 Jul 2019 13:22:08 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 866e55ac49a8be478d89f23c941155721187be9a Mon Sep 17 00:00:00 2001 From: Hariprasad Kelam Date: Wed, 10 Jul 2019 07:46:27 +0530 Subject: [PATCH] sound: soc: codecs: wcd9335: add irqflag IRQF_ONESHOT flag Add IRQF_ONESHOT to ensure "Interrupt is not reenabled after the hardirq handler finished". fixes below issue reported by coccicheck sound/soc/codecs/wcd9335.c:4068:8-33: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Signed-off-by: Hariprasad Kelam Link: https://lore.kernel.org/r/20190710021627.GA13396@hari-Inspiron-1545 Signed-off-by: Mark Brown --- sound/soc/codecs/wcd9335.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c index 1bbbe421b999..956602788d0e 100644 --- a/sound/soc/codecs/wcd9335.c +++ b/sound/soc/codecs/wcd9335.c @@ -4062,7 +4062,8 @@ static int wcd9335_setup_irqs(struct wcd9335_codec *wcd) ret = devm_request_threaded_irq(wcd->dev, irq, NULL, wcd9335_irqs[i].handler, - IRQF_TRIGGER_RISING, + IRQF_TRIGGER_RISING | + IRQF_ONESHOT, wcd9335_irqs[i].name, wcd); if (ret) { dev_err(wcd->dev, "Failed to request %s\n", -- 2.20.1