Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 8BIT
Subject: RE: [git pull 02/14] Add Wistron driver
Date: Tue, 6 Dec 2005 16:57:17 +0800
Message-ID: <3ACA40606221794F80A5670F0AF15F840A53FD73@pdsmsx403>
Thread-Topic: [git pull 02/14] Add Wistron driver
thread-index: AcX6P0DnYk2ZDn5FStGa5YKZAuCjBwAA6oIQ
From: "Yu, Luming" <luming.yu@intel.com>
To: "Miloslav Trmac" <mitr@volny.cz>
Cc: "Dmitry Torokhov" <dtor_core@ameritech.net>,
       "Linus Torvalds" <torvalds@osdl.org>,
       "Vojtech Pavlik" <vojtech@suse.cz>, "Andrew Morton" <akpm@osdl.org>,
       "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
       "Brown, Len" <len.brown@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1226
Lines: 34

>Miloslav Trmac wrote:
>> Yu, Luming wrote:
>>>>> I just tested module wistron_btn on  one Acer Aspire laptop after 
>>>>> adding one dmi entry.  The wistron_btn found BIOS interfaces.
>
>>>>If your laptop provides the hotkey events via ACPI, simply don't use
>>>>wistron_btns.
>>>
>>>wistron driver should be disabled if acpi hotkey enabled.
>> 
>> It is implicitly disabled because it contains DMI ids of 
>known laptops,
>> and its module_init() fails with -ENODEV when used on other hardware,
>> before ever touching the BIOS.
>> 
>> I therefore can't see how it could break anything unless you have
>> explicitly supplied module parameters to override this check.
>On second thought, do you by "found BIOS interfaces" mean "found BIOS
>interfaces when asked to" or "matched the existing Aspire 1500 DMI ID"?

I found this in dmesg:

wistron_btns: BIOS signature found at c00f6920, entry point 000FDC10
input: Wistron laptop buttons as /class/input/input2

>
>Thanks,
>	Mirek
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/