Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 22 Jul 2019 20:16:58 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     Nadav Amit <namit@vmware.com>, Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v3 1/9] smp: Run functions concurrently in
 smp_call_function_many()
Message-ID: <20190722181658.GA6698@worktop.programming.kicks-ass.net>
References: <20190719005837.4150-1-namit@vmware.com>
 <20190719005837.4150-2-namit@vmware.com>
 <c02833c8-8c68-4331-03c7-d9e5eb2f285c@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c02833c8-8c68-4331-03c7-d9e5eb2f285c@intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 19, 2019 at 11:23:06AM -0700, Dave Hansen wrote:
> On 7/18/19 5:58 PM, Nadav Amit wrote:
> > @@ -624,16 +622,11 @@ EXPORT_SYMBOL(on_each_cpu);
> >  void on_each_cpu_mask(const struct cpumask *mask, smp_call_func_t func,
> >  			void *info, bool wait)
> >  {
> > -	int cpu = get_cpu();
> > +	preempt_disable();
> >  
> > -	smp_call_function_many(mask, func, info, wait);
> > -	if (cpumask_test_cpu(cpu, mask)) {
> > -		unsigned long flags;
> > -		local_irq_save(flags);
> > -		func(info);
> > -		local_irq_restore(flags);
> > -	}
> > -	put_cpu();
> > +	__smp_call_function_many(mask, func, func, info, wait);
> > +
> > +	preempt_enable();
> >  }
> 
> The get_cpu() was missing it too, but it would be nice to add some
> comments about why preempt needs to be off.  I was also thinking it
> might make sense to do:
> 
> 	cfd = get_cpu_var(cfd_data);
> 	__smp_call_function_many(cfd, ...);
> 	put_cpu_var(cfd_data);
> 	
> instead of the explicit preempt_enable/disable(), but I don't feel too
> strongly about it.

It is also required for cpu hotplug.