Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 22 Jul 2019 16:06:25 -0400
From:   Sean Paul <sean@poorly.run>
To:     Qian Cai <cai@lca.pw>
Cc:     daniel@ffwll.ch, maarten.lankhorst@linux.intel.com,
        maxime.ripard@bootlin.com, sean@poorly.run, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: silence variable 'conn' set but not used
Message-ID: <20190722200625.GJ104440@art_vandelay>
References: <1563822886-13570-1-git-send-email-cai@lca.pw>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1563822886-13570-1-git-send-email-cai@lca.pw>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 22, 2019 at 03:14:46PM -0400, Qian Cai wrote:
> The "struct drm_connector" iteration cursor from
> "for_each_new_connector_in_state" is never used in atomic_remove_fb()
> which generates a compilation warning,
> 
> drivers/gpu/drm/drm_framebuffer.c: In function 'atomic_remove_fb':
> drivers/gpu/drm/drm_framebuffer.c:838:24: warning: variable 'conn' set
> but not used [-Wunused-but-set-variable]
> 
> Silence it by marking "conn" __maybe_unused.
> 
> Signed-off-by: Qian Cai <cai@lca.pw>

Thanks for your patch! I've applied it to drm-misc-fixes

Sean

> ---
>  drivers/gpu/drm/drm_framebuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_framebuffer.c b/drivers/gpu/drm/drm_framebuffer.c
> index 0b72468e8131..57564318ceea 100644
> --- a/drivers/gpu/drm/drm_framebuffer.c
> +++ b/drivers/gpu/drm/drm_framebuffer.c
> @@ -835,7 +835,7 @@ static int atomic_remove_fb(struct drm_framebuffer *fb)
>  	struct drm_device *dev = fb->dev;
>  	struct drm_atomic_state *state;
>  	struct drm_plane *plane;
> -	struct drm_connector *conn;
> +	struct drm_connector *conn __maybe_unused;
>  	struct drm_connector_state *conn_state;
>  	int i, ret;
>  	unsigned plane_mask;
> -- 
> 1.8.3.1
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS