Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Andy Lutomirski <luto@kernel.org>,
        the arch/x86 maintainers <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [RFC 3/7] x86/percpu: Use C for percpu accesses when possible
Thread-Topic: [RFC 3/7] x86/percpu: Use C for percpu accesses when possible
Thread-Index: AQHVPc3X8iG4Nn7Ym0aTUC7TEdfgCabXIyGAgAAFmYA=
Date:   Mon, 22 Jul 2019 21:12:30 +0000
Message-ID: <ADDC5AFB-2E49-467C-937A-0171CEECBC42@vmware.com>
References: <20190718174110.4635-1-namit@vmware.com>
 <20190718174110.4635-4-namit@vmware.com>
 <20190722205227.GK6698@worktop.programming.kicks-ass.net>
In-Reply-To: <20190722205227.GK6698@worktop.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1BBE50E53B42424CB010DC637EA00CBF@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 71feacdb-5bc9-4b80-b54c-08d70ee94e86
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2019 21:12:30.2475
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: namit@vmware.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4744
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Jul 22, 2019, at 1:52 PM, Peter Zijlstra <peterz@infradead.org> wrote:
>=20
> On Thu, Jul 18, 2019 at 10:41:06AM -0700, Nadav Amit wrote:
>=20
>> diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preem=
pt.h
>> index 99a7fa9ab0a3..60f97b288004 100644
>> --- a/arch/x86/include/asm/preempt.h
>> +++ b/arch/x86/include/asm/preempt.h
>> @@ -91,7 +91,8 @@ static __always_inline void __preempt_count_sub(int va=
l)
>>  */
>> static __always_inline bool __preempt_count_dec_and_test(void)
>> {
>> -	return GEN_UNARY_RMWcc("decl", __preempt_count, e, __percpu_arg([var])=
);
>> +	return GEN_UNARY_RMWcc("decl", __my_cpu_var(__preempt_count), e,
>> +			       __percpu_arg([var]));
>> }
>=20
> Should this be in the previous patch?

Yes, it should.=