Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7804963ybi; Mon, 22 Jul 2019 21:11:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqz6mgCMw848lE6z2SHGa98jwymMD3fz54/vx/dSDeqQOzQZkSdKxZKVyd6FngkKRLKdcdvq X-Received: by 2002:a17:90b:95:: with SMTP id bb21mr81135273pjb.8.1563855060629; Mon, 22 Jul 2019 21:11:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563855060; cv=none; d=google.com; s=arc-20160816; b=lrd/WyNHJ7UL6oT0p5QxbkiMsmEHJNylGJfjbswstHXdJAk+av3KVjuRXuWAnL5MIb 9LMPE2rDgnfZC+MU7xwZD+Qd7xrrjjwKiE/OXcm6N4MQhZ3+UvVxq0aJLbcolRp+SU1j eMDk0p5Yt5zCJqB0h4Ly8XuTTmYSwDUdFx3CJes7wEExjY8ntq8dtpQwML1GM+FgoYt8 5JgeOanMa/NFCYHKjLpjYl7H1s3rfMDzln7GhVlNbY+56zdBBSf/EmEPYM1lCGzYQY6D o0rF5rZbBQ0NkIHzWFswjx804kumyIT1PIsO9p3O9lDKLQRz8zDSDnudOhyG1qAKSa0H 328Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:user-agent:from:cc:to :subject:references:in-reply-to:content-transfer-encoding :mime-version:dkim-signature; bh=4xF+pOR5lJBMkLHiI6NyL85JrOgWaKJJJXpxntFb6xY=; b=DQMJcoqA0pR+Isd7AzJsZ0CqaLMQlll1OLKfuaKDNh+ow3uxgAUsGuNwDFsdSLxt/A 18xPGsPZSAsLmjAYUU2F1PrUuPhdvVdB/HB+ZCD0/YR2RMtPTJuhN6HifyIdA7SF5TB9 j1pTKiPpMyS8IOBnvUv3Qhi5eH456quhqVkUkWdaOsx+jvRln5B720nCdazgSMFcVbjg kbgYVorILxF6PXGh1lRtyQBtwZvuEO1QXLiEQEuXpGq4/SYd6JiEfqnnUanY0boTulFV GYj5qvaepxglnRXh2iMvdAiArqDKUb9RIjOcKbIk/f1Ux2EfjDCBQ8UafYXFMZ406j+s boUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CfO6y/va"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 18si10573214pgf.457.2019.07.22.21.10.43; Mon, 22 Jul 2019 21:11:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="CfO6y/va"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732957AbfGVWFP (ORCPT + 99 others); Mon, 22 Jul 2019 18:05:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:52266 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727170AbfGVWFP (ORCPT ); Mon, 22 Jul 2019 18:05:15 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C53FE21951; Mon, 22 Jul 2019 22:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563833114; bh=6wCqVFLfAE5EJfHAjcadIprMjvR25gD3bmKgqCjUMOE=; h=In-Reply-To:References:Subject:To:Cc:From:Date:From; b=CfO6y/van+mSGWSA1XbY6Gu0BXxfvN5weJjudshmWAPFMBcjyeDEfoDeRUQDY3D/z qR3GIpxO0+H87UMITd3txerCPUlZuLa/VT+ODujO7vaZ4Ng+/ft7sV5ZfreEE3lPJE 2TPM3yNcT3yGlvGVuP8mrWFmocFgvriXO1gKdgJ4= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190711130359.1060-1-geert+renesas@glider.be> References: <20190711130359.1060-1-geert+renesas@glider.be> Subject: Re: [PATCH] clk: renesas: cpg-mssr: Fix reset control race condition To: Geert Uytterhoeven , Michael Turquette Cc: Yao Lihua , Yoshihiro Shimoda , Wolfram Sang , linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven From: Stephen Boyd User-Agent: alot/0.8.1 Date: Mon, 22 Jul 2019 15:05:13 -0700 Message-Id: <20190722220514.C53FE21951@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Geert Uytterhoeven (2019-07-11 06:03:59) > The module reset code in the Renesas CPG/MSSR driver uses > read-modify-write (RMW) operations to write to a Software Reset Register > (SRCRn), and simple writes to write to a Software Reset Clearing > Register (SRSTCLRn), as was mandated by the R-Car Gen2 and Gen3 Hardware > User's Manuals. >=20 > However, this may cause a race condition when two devices are reset in > parallel: if the reset for device A completes in the middle of the RMW > operation for device B, device A may be reset again, causing subtle > failures (e.g. i2c timeouts): >=20 > thread A thread B > -------- -------- Applied to clk-fixes