Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7851115ybi; Mon, 22 Jul 2019 22:10:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8KuvgH/RqMEPO6xtCKJopEFv1yA3E9vMxktiADNuDLaymcBWRPji/at3pmrIEKQAut9mO X-Received: by 2002:a17:90a:db44:: with SMTP id u4mr80396204pjx.52.1563858620724; Mon, 22 Jul 2019 22:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563858620; cv=none; d=google.com; s=arc-20160816; b=tdC6Egx0ETPnFLGDXVFcIp9cRejyPYZptngV9rf7+egsvG0Ldq5ceIxkFiaG07m3MV r+Gbe6AFvitgkGQL1ZkZdwlOXTN0WTb2m8x3XOKEoDxXKTSjunveunI5uE4uwpPw4PSE GxGtovbrhQdj+RMmmQ6pZiF9o93PwbARtoOrSg3xDyTnYQUnyfzSm+w0WOxt1AVHpjiM Mu7qdnIuZgXRqIEChT6BerIzQBArp/hl0VC0V/idxQj4ZxvMviUfUIR8lkbRVnhTunu/ nN4rJaZDZaRDi0AP34plOjgWGHA2Xv+hWXnFTey0ksupal0xTk+sU8aIPZBtsF6OC+mg y00w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=l9bRvGYH3XRPkQyhYau9cH//jdY+2RalVJi8pH2PNWQ=; b=VOGzvJC40UbYebnVf1tRyoxhiIOlIFf5Mv26EsqYRFxhRcfzmx3nGuYSnfC5Ybgo78 gP5ho4F/2XL86WMxe+OmRInMrxDSpnKk6InNmub565tYuzrYw+ziReRTZrMZ3UdBCak+ pxONMLCw39+beLS3F9vGd1fpvPUS5O6UX5VjcRUAFV5n3u0PNxxy0VQilgko0lnf5Y3P D8gHQqWafyjC/UZdlsrcTYG9GflsOXpLHjaU7BXsZ/MQflcN5zEpTNAg+mHlYgRXbXxT BAtuDoVkYu/ND8EHoKF+uc/4tWagE4nWZS8nB3Pd+e/6ea39//wH5TyQHBF/AESqlZ0/ QhWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=RDY2P7K0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m15si13455199pgt.495.2019.07.22.22.10.04; Mon, 22 Jul 2019 22:10:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=RDY2P7K0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729349AbfGVTBl (ORCPT + 99 others); Mon, 22 Jul 2019 15:01:41 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57016 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727646AbfGVTBk (ORCPT ); Mon, 22 Jul 2019 15:01:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=l9bRvGYH3XRPkQyhYau9cH//jdY+2RalVJi8pH2PNWQ=; b=RDY2P7K0jIgySjc7lVsmVFCdNv vtwKEMeZmbIp7a06wMD230HDZ07Xnb8TpWA6kP6XQ89GYTpn31gIKdJeDyjU0yR6ZR3LBJBBgiN2Y yWUa2KGE1AOsf4aQU81XHnFkQ8hsG1oNKeV51YEN/3h8mRrInpYqvDC/K2cadhoWxzTY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hpdYz-0004aS-Gq; Mon, 22 Jul 2019 21:01:33 +0200 Date: Mon, 22 Jul 2019 21:01:33 +0200 From: Andrew Lunn To: Matthias Kaehlcke Cc: Rob Herring , Florian Fainelli , "David S . Miller" , Mark Rutland , Heiner Kallweit , netdev , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , Douglas Anderson Subject: Re: [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode Message-ID: <20190722190133.GF8972@lunn.ch> References: <20190703193724.246854-1-mka@chromium.org> <20190703193724.246854-6-mka@chromium.org> <20190703232331.GL250418@google.com> <20190722171418.GV250418@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190722171418.GV250418@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 22, 2019 at 10:14:18AM -0700, Matthias Kaehlcke wrote: > I'm working on a generic binding. > > I wonder what is the best process for reviewing/landing it, I'm > doubting between two options: > > a) only post the binding doc and the generic PHY code that reads > the configuration from the DT. Post Realtek patches once > the binding/generic code has been acked. > > pros: no churn from Realtek specific patches > cons: initially no (real) user of the new binding > > b) post generic and Realtek changes together > > pros: the binding has a user initially > cons: churn from Realtek specific patches > > I can do either, depending on what maintainers/reviewers prefer. I'm > slightly inclined towards a) Hi Matthias It is normal to include one user of any generic API which is added, just to make is clear how an API should be used. Andrew