Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 22 Jul 2019 22:52:27 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Nadav Amit <namit@vmware.com>
Cc:     Andy Lutomirski <luto@kernel.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>
Subject: Re: [RFC 3/7] x86/percpu: Use C for percpu accesses when possible
Message-ID: <20190722205227.GK6698@worktop.programming.kicks-ass.net>
References: <20190718174110.4635-1-namit@vmware.com>
 <20190718174110.4635-4-namit@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190718174110.4635-4-namit@vmware.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jul 18, 2019 at 10:41:06AM -0700, Nadav Amit wrote:

> diff --git a/arch/x86/include/asm/preempt.h b/arch/x86/include/asm/preempt.h
> index 99a7fa9ab0a3..60f97b288004 100644
> --- a/arch/x86/include/asm/preempt.h
> +++ b/arch/x86/include/asm/preempt.h
> @@ -91,7 +91,8 @@ static __always_inline void __preempt_count_sub(int val)
>   */
>  static __always_inline bool __preempt_count_dec_and_test(void)
>  {
> -	return GEN_UNARY_RMWcc("decl", __preempt_count, e, __percpu_arg([var]));
> +	return GEN_UNARY_RMWcc("decl", __my_cpu_var(__preempt_count), e,
> +			       __percpu_arg([var]));
>  }

Should this be in the previous patch?