Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp7907302ybi; Mon, 22 Jul 2019 23:17:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzSmf6Lk8yUhGCQf/zEPZmhsXnqaHQuhUrVCzZqFRrTjxLe7TV1obpx3J4JYQf8mr4bxrUu X-Received: by 2002:a17:902:e613:: with SMTP id cm19mr74047788plb.299.1563862657832; Mon, 22 Jul 2019 23:17:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563862657; cv=none; d=google.com; s=arc-20160816; b=nhBTcKRNyYm22vp63IocuUqF3u7OVMExiDRzkni1DWUjMLvrgP9RZmAIv04qELoWZh UG5pafCaz8v/tErJ611KEimhZlYMnBu3VjjUWkds39Plu9aiYMoHs12NPLbDel3zR+c4 SgSLFWPwomi6/oCHIfJ5eKbQRMWnLXPq2AD6PEYeRpvSoif/qBjwu5AzxhzbRidIexM4 nqODzyF/cYg/dfTM1H+oFLV3ToP2Wti51Qv5sf7KtVI7nfmiBQyBSl3m+W92BZUFXZd1 LfQcymhGcCG4XlaJqp2KkomvrFEqnAv7uIP/jN9t+m3fiPqIotAhOLRQWiDxm2QImSic epTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=IFeU/0oltT0V+jaMXcs+mhIGLcUmo4eqxZamdwL0OoU=; b=uRFXSDOURaZXLrmMsp60Udku/+BnJxpGXx32224NY+OcoCjzk/fiGGURAVErpEvw9K qVyPKFkmSf9eW5Hk2ZkhIxjF7YdlGHSekfM2IFh/ohdL3fQZZNbw+FTYlTNxc5EVVkMZ AVKw6RI3FwAl7KtpG+MHwbjjcNECIYK0r58KDYF+YCFxbiEQPF1Xs7nqN11mF0ypG/q0 tvopl+oa53vYCNBSjl95LqOFeH/R6fv0qngTw+N9NWGraTsFBPnQ0WpaLITSsSceOZpE R+8Hw2G1d3tN9nn3zi70xeUXFxBDr+C2vSyE+S/haPGCTYqZ7cpionquf6KZ3zuDAEhZ aIeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MBmhPZcX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q187si10436355pfb.51.2019.07.22.23.17.22; Mon, 22 Jul 2019 23:17:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MBmhPZcX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729860AbfGVVHJ (ORCPT + 99 others); Mon, 22 Jul 2019 17:07:09 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40454 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727845AbfGVVHJ (ORCPT ); Mon, 22 Jul 2019 17:07:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IFeU/0oltT0V+jaMXcs+mhIGLcUmo4eqxZamdwL0OoU=; b=MBmhPZcX+btbne+QodGupnlko GTn2pfUZoL08+6pgExaN33JzkNmjSCbb3Hn7DxvEQcNIo5vfXtVuQjJNfRD86k+EEpIvX3VoMSOLz Jf7mIe51Wi9VN2yRsipoFsMqyvIKIlfXUo8ciU8YrL7JqI1Hdl6/92h1wIUYYwRlYgEUFfScbEzjJ TGoIH6VRh4KmJLu73yomnzZjXvwZ8W3/YpyaeYB8n1YrWTbUIa523+X9H8ZGEONJfGb3hbHQawCVY zSjT/mDncOGGsmKfFBm5a0yq28vpxUGi/e8KD96M1ys/nlUEwltc0tfbx+rildZ6xNdUOQgNksuPP YaPczcPDQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hpfWU-0003Hv-Fn; Mon, 22 Jul 2019 21:07:06 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 47455980D1F; Mon, 22 Jul 2019 23:07:04 +0200 (CEST) Date: Mon, 22 Jul 2019 23:07:04 +0200 From: Peter Zijlstra To: Nadav Amit Cc: Andy Lutomirski , x86@kernel.org, linux-kernel@vger.kernel.org, Dave Hansen , Thomas Gleixner , Ingo Molnar Subject: Re: [RFC 7/7] x86/current: Aggressive caching of current Message-ID: <20190722210704.GL6698@worktop.programming.kicks-ass.net> References: <20190718174110.4635-1-namit@vmware.com> <20190718174110.4635-8-namit@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190718174110.4635-8-namit@vmware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 18, 2019 at 10:41:10AM -0700, Nadav Amit wrote: > The current_task is supposed to be constant in each thread and therefore > does not need to be reread. There is already an attempt to cache it > using inline assembly, using this_cpu_read_stable(), which hides the > dependency on the read memory address. Is that what it does?!, I never quite could understand percpu_stable_op().