Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: multipart/signed;
        boundary="Apple-Mail=_8CF3AAB6-07CE-49A2-A597-846037581ABC";
        protocol="application/pgp-signature";
        micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: Re: [PATCH] lightnvm: introduce pr_fmt for the previx nvm
From:   =?utf-8?Q?Javier_Gonz=C3=A1lez?= <javier@javigon.com>
In-Reply-To: <20190722043101epcms2p2645d83b2c4aca7fc446f8d9109342327@epcms2p2>
Date:   Tue, 23 Jul 2019 07:47:15 +0200
Cc:     Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Minwoo Im <minwoo.im.dev@gmail.com>,
        =?utf-8?Q?Matias_Bj=C3=B8rling?= <mb@lightnvm.io>,
        Klaus Birkelund Jensen <birkelund@gmail.com>
Message-Id: <45E0A0E6-52B0-4BF9-B816-33F6ECDD0E5F@javigon.com>
References: <BYAPR04MB5749126EF9E68D94125BACB486CA0@BYAPR04MB5749.namprd04.prod.outlook.com>
 <20190720083043.23387-1-minwoo.im.dev@gmail.com>
 <CGME20190720212747epcas1p4d3e17fefd1cbd2007a1a1a452dde9c55@epcms2p2>
 <20190722043101epcms2p2645d83b2c4aca7fc446f8d9109342327@epcms2p2>
To:     minwoo.im@samsung.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Apple-Mail=_8CF3AAB6-07CE-49A2-A597-846037581ABC
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

> On 22 Jul 2019, at 06.31, Minwoo Im <minwoo.im@samsung.com> wrote:
>=20
>>> @@ -1111,27 +1112,27 @@ static int nvm_init(struct nvm_dev *dev)
>>>  	int ret =3D -EINVAL;
>>>=20
>>>  	if (dev->ops->identity(dev)) {
>>> -		pr_err("nvm: device could not be identified\n");
>>> +		pr_err("device could not be identified\n");
>>>  		goto err;
>>>  	}
>>>=20
>>> -	pr_debug("nvm: ver:%u.%u nvm_vendor:%x\n",
>>> +	pr_debug("ver:%u.%u nvm_vendor:%x\n",
>>>  				geo->major_ver_id, geo->minor_ver_id,
>>>  				geo->vmnt);
>> The above last 2 lines can be squashed and pr_debug call can be made =
in
>> 2 lines since you have removed the "nvm:" which shortens the first =
line.
>=20
> Yeah Okay.  Will prepare V2 with this and also s/previx/prefix in the
> title.
>=20
> Thanks for the review.
>=20
> Minwoo Im

Besides Chaitanya=E2=80=99s comments, looks good. You can add my review =
on V2.

Reviewed-by: Javier Gonz=C3=A1lez <javier@javigon.com>

--Apple-Mail=_8CF3AAB6-07CE-49A2-A597-846037581ABC
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEU1dMZpvMIkj0jATvPEYBfS0leOAFAl02n2MACgkQPEYBfS0l
eOAimBAAoRaQlUo+9zVTRoh3Xb2a+uWuwlxa2jeVXJLZ6GpUGNcibZrcSjas44L5
YN/tN59dr7/G0bsryzgOQ/X3TXPOIUZI2RloWrhxcihgylT+81dNJsd2qaoGfPnX
RbZQ7oRpvFmj0uN4QMD7TUqHhAXotvoh3HcXXmWlXWwO/hFeMZN8XqnN0JqJEIYn
1L3tWML1DuEbkkllm+QZMPedXyhCxYOqTRjnIziHTI9RCJtWYqmNdrgLxx7pbdlK
TNByGc6BxNU4rvJrsi7yDWH50EDYcIKDYjWnCM/jHYz8M0IjSq3/OxXtLvHVtBCO
LmTIy/6uOqBPdIDYPBc2IkwMhmT5ZSxE0BfL8ME/CWDua1KLaKfc+Nw5bK/Dllnn
+rqsRAE34ZlbGdANWY7pPiRSHPRlATh+2OWoIuqhgnhx90UPPC5NaceZrMZ9tlTQ
a4rYPENHHigD383kJ5EYCt9fShOKeEef0STFyTjiWlDGTVgPbny7hGc0SvKiU2mX
XVHL2n50YstjpSF6ZJFY9q51aYJvkINcG2Vte25cpFIw3vBKKBn+78LVs2W9yXco
VOdxXAu5kQiIFkcPoHioWVLJYX26FCpvJo2BTtkqqeE2OPCQU2i8DelIHEV38rpR
W4TXHgfKvowcirfzVUp3IEh3BL/1C0ENm0DPTQWRE/1uCa3C+hI=
=GMX1
-----END PGP SIGNATURE-----

--Apple-Mail=_8CF3AAB6-07CE-49A2-A597-846037581ABC--