Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8360070ybi; Tue, 23 Jul 2019 07:15:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwN32XR2yiiBgfk7xtIK0fNz81ZkEaND60kZakARcp5QlW5dVIqmnbPfnUx+0afSlcHFsFv X-Received: by 2002:a17:902:2ae7:: with SMTP id j94mr80760519plb.270.1563891352953; Tue, 23 Jul 2019 07:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563891352; cv=none; d=google.com; s=arc-20160816; b=MN7DeS8mxFeXtYMgS3USMV1H8ttkFyvzwod3fuUXZE4AXTrXksPvkRW3+O9knG1eeF sk7INLDSob8ZsFcZ6I6wjs5Ts0FV8QBkiOehesNB2VnZT8KHjyLK8/c8/Nb+iYCfdjVo VnUbQ6G13ygRvfJMOuIVdLwMSUXWA1UzaxIKk0LAy/cprMgNVdvdkzRtNMEPa7Cw7ZhN mUFCOrclZQEUFbw3ByJUZzOufC/MmaRW20BaQuSkSzS2uf81qWqIN3IQTEHCK4Pdg53f Ye8QR+QJA864JLkdMpIfSb0VTy61yVsJgGQQjVcsXY41lvpzQQO49jTetmdBPPlvnHzh qC1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from; bh=szvDy5HPEMCfuSGHY8zhtT0jeAzz8jB2Fy7082Ow1XQ=; b=V9s0oiRV43JGCACQD8T0CzUSgCW0wl2kKsJ1OViFYAYn5CMks7IDrmE8M4K5HJGJe2 TXzqMgv+gsBnExFNYfLslPhmka77MvyLt+dE6TFoBuHA3xC/rYG8PrMoEIAn7+3lWoHn RZLNg3dk93aSuKYU/qScYHhScBPMHGSco3pjPQ/P4v4ikn/HV1bik+uxLeHd2E2xmvka NTKo2GdTY93km4CxTVVsbsDmRuPirBdkSD28JgpOBCjbUbHxKp8Eqh5c/HGMJFcb8vgf 2AlVZyAmdoyVcXp+lM9OMaeCxndndRnp41CslwyR7ctX7WHUjcIcqs3uE1zDzem/dmSH MA7A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d15si12697056pgv.90.2019.07.23.07.15.36; Tue, 23 Jul 2019 07:15:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387981AbfGWGHv (ORCPT + 99 others); Tue, 23 Jul 2019 02:07:51 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:34751 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729098AbfGWGHv (ORCPT ); Tue, 23 Jul 2019 02:07:51 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R941e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04446;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0TXc-Eyt_1563862068; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TXc-Eyt_1563862068) by smtp.aliyun-inc.com(127.0.0.1); Tue, 23 Jul 2019 14:07:48 +0800 From: Alex Shi Cc: Alex Shi , Ingo Molnar , Peter Zijlstra , Frederic Weisbecker , Wanpeng Li , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: [RFC PATCH 1/3] cputime: fix a account error of softirq Date: Tue, 23 Jul 2019 14:01:40 +0800 Message-Id: <20190723060142.145747-1-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.856.g8858448bb MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According the comments before this line: * ksoftirqd time do not get accounted in cpu_softirq_time. And process in irqtime_account_irq() I guess the original attempt is to account ksoftirqd into system time instead of softirq time. Signed-off-by: Alex Shi Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Frederic Weisbecker Cc: Wanpeng Li Cc: Thomas Gleixner Cc: linux-kernel@vger.kernel.org --- kernel/sched/cputime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index 2305ce89a26c..d78aee140957 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c @@ -378,7 +378,7 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick, * So, we have to handle it separately here. * Also, p->stime needs to be updated for ksoftirqd. */ - account_system_index_time(p, cputime, CPUTIME_SOFTIRQ); + account_system_index_time(p, cputime, CPUTIME_SYSTEM); } else if (user_tick) { account_user_time(p, cputime); } else if (p == rq->idle) { -- 2.19.1.856.g8858448bb