Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     =?iso-8859-2?Q?Ond=F8ej_Jirman?= <megi@xff.cz>,
        Jose Abreu <Jose.Abreu@synopsys.com>
CC:     Andrew Lunn <andrew@lunn.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        Joao Pinto <Joao.Pinto@synopsys.com>,
        "David S . Miller" <davem@davemloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Russell King <linux@armlinux.org.uk>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "Heiner Kallweit" <hkallweit1@gmail.com>
Subject: RE: [PATCH net-next 0/3] net: stmmac: Convert to phylink
Thread-Topic: [PATCH net-next 0/3] net: stmmac: Convert to phylink
Thread-Index: AQHVIGkCReoXsI1ev0mBbW+MAvwZAqbW1RMAgAALU8CAAATNgIAAAL0ggAAKQYCAAAF88IAABCiAgAE8+mA=
Date:   Tue, 23 Jul 2019 09:36:42 +0000
Message-ID: <BYAPR12MB32694541534ED0ABA3C55BE6D3C70@BYAPR12MB3269.namprd12.prod.outlook.com>
References: <cover.1560266175.git.joabreu@synopsys.com>
 <20190722124240.464e73losonwb356@core.my.home>
 <BN8PR12MB32660B12F8E2617ED42249BBD3C40@BN8PR12MB3266.namprd12.prod.outlook.com>
 <20190722134023.GD8972@lunn.ch>
 <BN8PR12MB3266678A3ABD0EBF429C9766D3C40@BN8PR12MB3266.namprd12.prod.outlook.com>
 <20190722141943.GE8972@lunn.ch>
 <BN8PR12MB3266BEC39374BE3E9CD2647DD3C40@BN8PR12MB3266.namprd12.prod.outlook.com>
 <20190722143955.uwzvcmhc4bdr2zr5@core.my.home>
In-Reply-To: <20190722143955.uwzvcmhc4bdr2zr5@core.my.home>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: synopsys.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3942a70b-4934-4505-01b5-08d70f51458e
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2019 09:36:42.9476
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: joabreu@synopsys.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2998
X-OriginatorOrg: synopsys.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Ond=F8ej Jirman <megi@xff.cz>
Date: Jul/22/2019, 15:39:55 (UTC+00:00)

> On Mon, Jul 22, 2019 at 02:26:45PM +0000, Jose Abreu wrote:
> > From: Andrew Lunn <andrew@lunn.ch>
> > Date: Jul/22/2019, 15:19:43 (UTC+00:00)
> >=20
> > > On Mon, Jul 22, 2019 at 01:58:20PM +0000, Jose Abreu wrote:
> > > > From: Andrew Lunn <andrew@lunn.ch>
> > > > Date: Jul/22/2019, 14:40:23 (UTC+00:00)
> > > >=20
> > > > > Does this mean that all stmmac variants support 1G? There are non=
e
> > > > > which just support Fast Ethernet?
> > > >=20
> > > > This glue logic drivers sometimes reflect a custom IP that's Synops=
ys=20
> > > > based but modified by customer, so I can't know before-hand what's =
the=20
> > > > supported max speed. There are some old versions that don't support=
 1G=20
> > > > but I expect that PHY driver limits this ...
> > >=20
> > > If a Fast PHY is used, then yes, it would be limited. But sometimes a
> > > 1G PHY is used because they are cheaper than a Fast PHY.
> > > =20
> > > > > I'm also not sure the change fits the problem. Why did it not
> > > > > negotiate 100FULL rather than 10Half? You are only moving the 1G
> > > > > speeds around, so 100 speeds should of been advertised and select=
ed.
> > > >=20
> > > > Hmm, now that I'm looking at it closer I agree with you. Maybe link=
=20
> > > > partner or PHY doesn't support 100M ?
> > >=20
> > > In the working case, ethtool shows the link partner supports 10, 100,
> > > and 1G. So something odd is going on here.
> > >=20
> > > You fix does seems reasonable, and it has been reported to fix the
> > > issue, but it would be good to understand what is going on here.
> >=20
> > Agreed!
> >=20
> > Ondrej, can you please share dmesg log and ethtool output with the fixe=
d=20
> > patch ?
>=20
> See the attachment, or this link:

So, I've removed all 1G link modes from stmmac and run it on an ARM=20
based board. My link status resolves to 100M/Full using Generic PHY so=20
maybe something is wrong with the PHY driver that Ondrej is using=20
("RTL8211E Gigabit Ethernet") ?

---
Thanks,
Jose Miguel Abreu