Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8828589ybi; Tue, 23 Jul 2019 16:11:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDn11MOM3Qvh0zRVxQGGWYJSvRAvaH1xfBsCJhkjiNZX2zlNDHOlD5nErOwq4iOEIbfqhK X-Received: by 2002:a17:902:d20a:: with SMTP id t10mr32472864ply.226.1563923472507; Tue, 23 Jul 2019 16:11:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563923472; cv=none; d=google.com; s=arc-20160816; b=FsYfDE5/OmrIayj2U8iXSOpRZavGcDFb/cLCUKtRhECbzkzUf0gT1tCFzH6T+bMAML Qc0BYIr1SeroLEMLpwCgQ1dco31RFwOwy6xLAuJlmLo1I4SYoET1a6wCckdGGj0ssogq os9zr7DBy/xQbtoyDYEbDRJgQ8L8EguUQPj/rYX913y0ozRhyTccZRT+I1vSmMF3Nyue mmQiDhWFbgxEtGyZ9h90JGCuPCyioSP3Av/MyRECBHpPSTcAg+2M6DBBPrpEiEYdXvxp CIYKMrNTmvma1CG3bFebeyDHVzpmQ/uA6+FxCUEAXpdX80dZaWE6X5eRHneS/tVhoo8g 3BaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:message-id :date:subject:cc:to:from; bh=vnUMhGHFntFjRCg50dKxkbAv1jtTZ2lFJW7TPW4MlWE=; b=s/DuiS0Rm8qSBLGYULZYi7Qp8cNRXBbSTaDfNreJY0iHHeA5IMiHotPIsktgMCWdam r2pxaZoyIEIhYO9+J2a6WGQYVQc53z7pX3KPxyNca0n1sfje4ioWD9XDEjmNzWwhKP0c +kDIpyUpcqzDcAljXSAE/VVgUGqAtSeU3iga1SEmu0EpvC6EgZmbUYq8gYNnulOZvP7X LhaTQO+V98eTorkoAPX/yQTrNZ54/UQqYeULLNLMrb2DL/dY/JalvwOW5mHKUVx4AAPJ DvX1Q1Nio6FuQ4ShogUzPGbhOvfsKHq0AjcspxVb52RJ/UoQh3pCj4wjiIi0uf1N2ZW9 1D9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BBFi9+pI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cl13si11921809plb.97.2019.07.23.16.10.56; Tue, 23 Jul 2019 16:11:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=BBFi9+pI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731469AbfGWMkT (ORCPT + 99 others); Tue, 23 Jul 2019 08:40:19 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:17865 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726638AbfGWMkS (ORCPT ); Tue, 23 Jul 2019 08:40:18 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 23 Jul 2019 05:40:18 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 23 Jul 2019 05:40:17 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 23 Jul 2019 05:40:17 -0700 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 23 Jul 2019 12:40:17 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 23 Jul 2019 12:40:17 +0000 Received: from viswanathl-pc.nvidia.com (Not Verified[10.24.34.161]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Tue, 23 Jul 2019 05:40:17 -0700 From: Viswanath L To: , , , CC: , , , Viswanath L , Subject: [PATCH v3] drm/tegra: sor: Enable HDA interrupts at plug-in Date: Tue, 23 Jul 2019 18:10:10 +0530 Message-ID: <1563885610-27198-1-git-send-email-viswanathl@nvidia.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1563885618; bh=vnUMhGHFntFjRCg50dKxkbAv1jtTZ2lFJW7TPW4MlWE=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type; b=BBFi9+pINJlcbCbMk3Ue+WDikjwc8qnvNr6wz/l0ep+fGOMDIByfvx54x9zncg50F kTSB7lNswhIkdH7bTrNS+1ijAN6LAJn+uGLqA2vrNKHlshm1RLUPhhcdgr/QBihY25 epAJB73dNVrt5bMJq4DduZjXolzRif9pU87hAtRPalrl9iDcJTOQNlv2SF2O63qLLe B2SaiQMUrKv/xc6eZhbYOBJrHa/5fTQYj93GLAkr6m4Y9hh4Vu6z555A6Wfp21HqpO Of1Rm0TIOU+q1PE5kPJx6utVT+sjqojafp0G4vt0SLrtfUDr3wKbmHlVwDfM06UmN4 hfhuyWQIpQl9g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org HDMI plugout calls runtime suspend, which clears interrupt registers and causes audio functionality to break on subsequent plug-in; setting interrupt registers in sor_audio_prepare() solves the issue. Signed-off-by: Viswanath L Fixes: 8e2988a76c26 ("drm/tegra: sor: Support for audio over HDMI") Cc: --- drivers/gpu/drm/tegra/sor.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index 5be5a08..0470cfe 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -2164,6 +2164,15 @@ static void tegra_sor_audio_prepare(struct tegra_sor *sor) value = SOR_AUDIO_HDA_PRESENSE_ELDV | SOR_AUDIO_HDA_PRESENSE_PD; tegra_sor_writel(sor, value, SOR_AUDIO_HDA_PRESENSE); + + /* + * Enable and unmask the HDA codec SCRATCH0 register interrupt. This + * is used for interoperability between the HDA codec driver and the + * HDMI/DP driver. + */ + value = SOR_INT_CODEC_SCRATCH1 | SOR_INT_CODEC_SCRATCH0; + tegra_sor_writel(sor, value, SOR_INT_ENABLE); + tegra_sor_writel(sor, value, SOR_INT_MASK); } static void tegra_sor_audio_unprepare(struct tegra_sor *sor) @@ -2913,15 +2922,6 @@ static int tegra_sor_init(struct host1x_client *client) if (err < 0) return err; - /* - * Enable and unmask the HDA codec SCRATCH0 register interrupt. This - * is used for interoperability between the HDA codec driver and the - * HDMI/DP driver. - */ - value = SOR_INT_CODEC_SCRATCH1 | SOR_INT_CODEC_SCRATCH0; - tegra_sor_writel(sor, value, SOR_INT_ENABLE); - tegra_sor_writel(sor, value, SOR_INT_MASK); - return 0; } -- 2.7.4