Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8942080ybi; Tue, 23 Jul 2019 18:33:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzrhakd5wsdSMZ8f8Mp4BP/4A6MkUxmuZToUzf3piQsyQ7usF761XruzqpTirVENAQcHmuU X-Received: by 2002:a17:902:4283:: with SMTP id h3mr80970825pld.15.1563931982173; Tue, 23 Jul 2019 18:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563931982; cv=none; d=google.com; s=arc-20160816; b=OJ9HYSOiCCrW/HqkaxMpzZ+y+WLgfpN19vKtACRbDiapo+46h+Hr0rb2Zr16Pg7/0y NRJDc1bWeHt19+xVGlkVv6HXUCjbIqvjy/RuEgZPlEPQ3pujxngPw5Uhq2RmO8qfPYmy EU+T6ve1LPBNhpoz9ezTLdWzEQWWhrlAWXoR2VmhmClirWu+hWhAq70XPguek3Tfw8Bl kckIU3we6OrlwJKZSkVj7/GXoPT0BtNmkYxP+AAEIT+L59zu7ht3cFvZYfZk+dmed/2k Z6wFZINnNNRjg3Geclx+KG1l9mFXmgJRwmMt0Wj5/ROxxDArxbMgKp7p8P2NpPnM2Q3L bVkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:user-agent:message-id :references:cc:in-reply-to:from:to:content-transfer-encoding :mime-version; bh=tHFg3Usj6I/PJaRvNhAfbWGjddyGAemt1lsQtn57Fu0=; b=iZIuh6g99HfmsNKoGXumOlePJ3IiLFoystitQzuIN4RwzxPGUT3ov6IRc2jnuNTmuf gu4LhwFEUeHCFhpjqmxTWJk0bvvUQBW6JARyq5zIn75OgXUsLv4wTV361f2mpMA95gY+ cSGIx8eoB7J1x0hDn466j5CSO8b37CbiBOTORDg6cZ5gtkHysksOWBTXQ3WleoxSUn5F MarTdqaaGWAZeZ/Z8TwSjXCHIuGkvZWpyZpsAenfKBMI2dr0X7xNmK5wwVZuVI8Wcmhu c/jcrWweKOCharCrbQKbofHX/9ZsRyGxaZH4+vWwwvhJTGwv4E+qoLKDgEzeFfdItVep 1EGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o71si14515783pjb.8.2019.07.23.18.32.46; Tue, 23 Jul 2019 18:33:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388216AbfGWQZ0 convert rfc822-to-8bit (ORCPT + 99 others); Tue, 23 Jul 2019 12:25:26 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:51627 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732643AbfGWQZ0 (ORCPT ); Tue, 23 Jul 2019 12:25:26 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 17539619-1500050 for multiple; Tue, 23 Jul 2019 17:25:19 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Chuhong Yuan From: Chris Wilson In-Reply-To: <20190723103915.3964-1-hslester96@gmail.com> Cc: David Airlie , intel-gfx@lists.freedesktop.org, Chuhong Yuan , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20190723103915.3964-1-hslester96@gmail.com> Message-ID: <156389911703.31349.2020385253528691635@skylake-alporthouse-com> User-Agent: alot/0.6 Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use dev_get_drvdata Date: Tue, 23 Jul 2019 17:25:17 +0100 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Chuhong Yuan (2019-07-23 11:39:16) > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan That cuts out some circumlocution, Reviewed-by: Chris Wilson -Chris