Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8942711ybi; Tue, 23 Jul 2019 18:33:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqy4RGdstx3sYqQ+0ZFmDDZAj/2HLuhUIgdzddRX8psoykZlUSkYEprU20WYhIOrlMZYuCwh X-Received: by 2002:a17:90a:d791:: with SMTP id z17mr80802474pju.40.1563932033402; Tue, 23 Jul 2019 18:33:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563932033; cv=none; d=google.com; s=arc-20160816; b=yydZJ8opDcKWwmpK+xkCnNZjRUg1uyjPAPkkbMH7+cENjVOmuJYJ2uNrRHxRa9R7IX 8Scr15196Z6rP8EeOmndv0AMPxQvUWpY5M+20wDMk0I0nGAcTVgGBGLxb2fOCAR92Fe1 B4uBbkbh0PxjoqDHGzxs/Cf+dFYApDLvy0+gHhaRAfzS+0jfI61qkK6IxTIydTPmlNDd 0jPCsA8DU3rKnt2lon3UswdwNirBXZOSkaz1rQtn8IlSOjmL995JJnAh5M/0GrHmrdiQ ehRnnzGuRHeJ0bVxqqgPCWSFz3tzg0WkQ0zDlZhniWFUBdn8ecqEyX2wQ2w6V46d3pPd 3y7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vguCE5RDmchM6NCjw3HSB279/xZwy1WJs2bCsAtPW88=; b=Cq021nsBs4/wNCzj9P2BT9XsbhBTiqpFYKLQXaavDRPHDcbGMlS9APaZDdOEqJq++U BG8Wd6LmwhuFEMS2wnSTrupxbrLn0ej4qo4Cj/+zMRoEQJoX729Bf46rSQFzZ0zbetdz 76SGrVW/7HYWER4HYQlbQfQXaTmFFhem7XBgoT8XJzhXID6uguUFVwRFo0werAMymQp7 uMymMoAXRUttTzsKjnd9xE3dkc4vBZuiSDizfxdN3AW5CfzLzXYc04oHkROtAx+ZapIV ehAZdbK75P0RPVpw7+1x4I7FLPT/vVFUUf6/QWteiTQE/OgsfEmCdRRrjhG1Sme3emx3 Zsng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i9si13433566plt.387.2019.07.23.18.33.37; Tue, 23 Jul 2019 18:33:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390868AbfGWQcr (ORCPT + 99 others); Tue, 23 Jul 2019 12:32:47 -0400 Received: from verein.lst.de ([213.95.11.211]:43200 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731167AbfGWQcr (ORCPT ); Tue, 23 Jul 2019 12:32:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 1084268B02; Tue, 23 Jul 2019 18:32:45 +0200 (CEST) Date: Tue, 23 Jul 2019 18:32:44 +0200 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , =?iso-8859-1?B?Suly9G1l?= Glisse , Ben Skeggs , Ralph Campbell , "linux-mm@kvack.org" , "nouveau@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: hmm_range_fault related fixes and legacy API removal v2 Message-ID: <20190723163244.GE1655@lst.de> References: <20190722094426.18563-1-hch@lst.de> <20190723152737.GO15331@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723152737.GO15331@mellanox.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 03:27:41PM +0000, Jason Gunthorpe wrote: > Ignoring the STAGING issue I've tried to use the same guideline as for > -stable for -rc .. > > So this is a real problem, we definitely hit the locking bugs if we > retry/etc under stress, so I would be OK to send it to Linus for > early-rc. > > However, it doesn't look like the 1st patch is fixing a current bug > though, the only callers uses blocking = true, so just the middle > three are -rc? nonblocking isn't used anywher, but it is a major, major API bug. Your call, but if it was my tree I'd probably send it to Linus.