Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190723124608.24617-1-hslester96@gmail.com>
In-Reply-To: <20190723124608.24617-1-hslester96@gmail.com>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Tue, 23 Jul 2019 21:24:18 +0300
Message-ID: <CAFCwf11Y_wxeWdjy_838+Br_vPmMh-dZ0++TKapa6ib_swwbOA@mail.gmail.com>
Subject: Re: [PATCH v2] habanalabs: Use dev_get_drvdata
To:     Chuhong Yuan <hslester96@gmail.com>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 23, 2019 at 3:46 PM Chuhong Yuan <hslester96@gmail.com> wrote:
>
> Instead of using to_pci_dev + pci_get_drvdata,
> use dev_get_drvdata to make code simpler.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> Changes in v2:
>   - Split v1 into different subsystems
>
>  drivers/misc/habanalabs/habanalabs_drv.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/habanalabs_drv.c b/drivers/misc/habanalabs/habanalabs_drv.c
> index 6f6dbe93f1df..678f61646ca9 100644
> --- a/drivers/misc/habanalabs/habanalabs_drv.c
> +++ b/drivers/misc/habanalabs/habanalabs_drv.c
> @@ -295,8 +295,7 @@ void destroy_hdev(struct hl_device *hdev)
>
>  static int hl_pmops_suspend(struct device *dev)
>  {
> -       struct pci_dev *pdev = to_pci_dev(dev);
> -       struct hl_device *hdev = pci_get_drvdata(pdev);
> +       struct hl_device *hdev = dev_get_drvdata(dev);
>
>         pr_debug("Going to suspend PCI device\n");
>
> @@ -310,8 +309,7 @@ static int hl_pmops_suspend(struct device *dev)
>
>  static int hl_pmops_resume(struct device *dev)
>  {
> -       struct pci_dev *pdev = to_pci_dev(dev);
> -       struct hl_device *hdev = pci_get_drvdata(pdev);
> +       struct hl_device *hdev = dev_get_drvdata(dev);
>
>         pr_debug("Going to resume PCI device\n");
>
> --
> 2.20.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
And pushed to -next

Thanks,
Oded