Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8986970ybi; Tue, 23 Jul 2019 19:31:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8eqjAuadyXCLKmUVFNWH66/CzYEw4qsnXggZLuSn9M0U93A3A0rsWvzyqROgVTGT3UkFB X-Received: by 2002:a17:90a:29c5:: with SMTP id h63mr81660793pjd.83.1563935483376; Tue, 23 Jul 2019 19:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935483; cv=none; d=google.com; s=arc-20160816; b=okWOYZbXLGO6msKAz9auNGkcqLAZgt9vY9KmVjQM0ZwMyIVj6NztM1w888Zy0BFb9v PMBbAYjG9jQbbsi6jCKH19YZw7916sWzLEmOS2UsWG/Pty017/dBMuAzHS2Q0MhkOkmL bDPhBJokg9ZafiyJaLuqKuu4Tva+zpZc2P+uhF+uu3DHKO+t/vqE3P+HNWVfI4S04fxd zFjP9SsYIXmp9YHNNhgf+xUTSUnU5eJNXCXWazq5WvIQlkL44c/1Z3Yv8FdnctI5KayO LTC/YReVYVnLDVYGpdkjxvm9Ot2OVQVj/3SWeKCVrPWc5Re817RdpwalV5jv9ER/bGVZ yGSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=KVIKc0QF6eM8X37FVggMKLiF87kuZep3PwOVZN534D8=; b=dOkDAlwLxeQKWL+xYdVNNZ1zW3tGptx6pxPtrKUcC6nyQETnjJiRbL4hYVz3k5aiiP R6AeGbaig1fytHXl3/PYgZOFOVg6vbnaG8NywZa1Kkq5ciqcXFXA2GXxn06TtAKzfwfN fXmCzhxmE5Z5v8NGtJVj2wuV98RnBmlvFWfDVyO9vGRyATe4Q848l/F2IAI7vu83E1Sm fPEn+RqtJWQWZwiGOIzVNhBekXWfFCv+yKc4OLlfVPUmQSUPKbuLtrj1EJOWgH4MJFsB iCUYnB2c9cGWgv+7rF+7I1KIa70gFBjT/OLZq1Np82d8KHPIZ5TMVch+TvgLpH2L+2Cq pzqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11si17919703pgk.384.2019.07.23.19.31.07; Tue, 23 Jul 2019 19:31:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391964AbfGWVGs (ORCPT + 99 others); Tue, 23 Jul 2019 17:06:48 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:36780 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729542AbfGWVGr (ORCPT ); Tue, 23 Jul 2019 17:06:47 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D3B69153BF123; Tue, 23 Jul 2019 14:06:46 -0700 (PDT) Date: Tue, 23 Jul 2019 14:06:46 -0700 (PDT) Message-Id: <20190723.140646.505566792140054611.davem@davemloft.net> To: skunberg.kelsey@gmail.com Cc: iyappan@os.amperecomputing.com, keyur@os.amperecomputing.com, quan@os.amperecomputing.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn@helgaas.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v2] drivers: net: xgene: Remove acpi_has_method() calls From: David Miller In-Reply-To: <20190723185811.8548-1-skunberg.kelsey@gmail.com> References: <20190722030401.69563-1-skunberg.kelsey@gmail.com> <20190723185811.8548-1-skunberg.kelsey@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 23 Jul 2019 14:06:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kelsey Skunberg Date: Tue, 23 Jul 2019 12:58:11 -0600 > acpi_evaluate_object will already return an error if the needed method > does not exist. Remove unnecessary acpi_has_method() calls and check the > returned acpi_status for failure instead. > > Signed-off-by: Kelsey Skunberg > --- > Changes in v2: > - Fixed white space warnings and errors Applied to net-next.