Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8987222ybi; Tue, 23 Jul 2019 19:31:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzWDoTNpcmzF0OG1r6fPt62Yecu2LTsPM0PUZa03B/MXLlE1gdq5uQ2M/aBA4c0FVEYP7es X-Received: by 2002:a63:9e43:: with SMTP id r3mr54648796pgo.148.1563935500830; Tue, 23 Jul 2019 19:31:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935500; cv=none; d=google.com; s=arc-20160816; b=XZP6zcKER0xZEA6RWR5odeih9xFaDC/cT9TiTramKN7Jz6XzhKTbNY343MCkTr1zce Ml2M14M0D0M/wTnrP/O7YUF2LiWAfkWXwMGqICNtULMHPQ9SQtnXFuc133Q+gryydgAS LUaM0eb6DfMgCybbDyFzPHBDuJai46VQyAfy8V30mt4MD5KYAV9oSdz8zQPT/r69W5ED FHm38MBWDRftUCTj4wTQEg1E1h+ZGFEtyi07Dx3BqL+9lz41kHl3QudVfCSRdU7pCkMN /eEQ7W/DlGuQh3F91eI33NWUAp6/+r8zQXW3gx2AsxMF5od+Ihnpf/tp/6Dp8TBWB1+O R2hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=T3n4sx2EKv2z0ZT8YFW3rZFAL1dZ7fJfAFdssIIILyQ=; b=Uw6m9wzyXKtyyw/rKpi4+IIMUq4m/kjyuGYc+mlv0xlblT5PhHPIzdtFyRbq+g9iV0 6z02K3cFtixCJDzYhckMzvMPyMFNooUymUzThoea9yrzMNeFCuOBmBNMP5B+k+WkfKP6 2ofPuyRbwlH6l/tF9hUMo9X7G5XBH6eFjKeEgKWBzEaDMK0k7X0xC4pOdePkbiG36G3m xPrmv3snpWOy/K3DfdwMRr2SymRQiHJHjqUhvwBfmAzY6koHeYWTucbEt5STF9BOnxQu 51HidoRkvmCG9/yhUYKANt5o1jvwffmbAz+mt2nuVKM6h37BJx9wWR+ULFvXoOrsUD4a Ml8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j17si13345309pfa.198.2019.07.23.19.31.24; Tue, 23 Jul 2019 19:31:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388989AbfGWUhm (ORCPT + 99 others); Tue, 23 Jul 2019 16:37:42 -0400 Received: from hostingweb31-40.netsons.net ([89.40.174.40]:51566 "EHLO hostingweb31-40.netsons.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732479AbfGWUhk (ORCPT ); Tue, 23 Jul 2019 16:37:40 -0400 Received: from [88.149.224.16] (port=34022 helo=melee.fritz.box) by hostingweb31.netsons.net with esmtpa (Exim 4.92) (envelope-from ) id 1hq1XU-007idA-Tw; Tue, 23 Jul 2019 22:37:37 +0200 From: Luca Ceresoli To: linux-media@vger.kernel.org, linux-i2c@vger.kernel.org Cc: Luca Ceresoli , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Mark Rutland , Wolfram Sang , Sakari Ailus , Hans Verkuil , Laurent Pinchart , Kieran Bingham , Jacopo Mondi , Vladimir Zapolskiy , Peter Rosin Subject: [RFC,v2 1/6] i2c: core: let adapters be notified of client attach/detach Date: Tue, 23 Jul 2019 22:37:18 +0200 Message-Id: <20190723203723.11730-2-luca@lucaceresoli.net> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190723203723.11730-1-luca@lucaceresoli.net> References: <20190723203723.11730-1-luca@lucaceresoli.net> X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - hostingweb31.netsons.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lucaceresoli.net X-Get-Message-Sender-Via: hostingweb31.netsons.net: authenticated_id: luca+lucaceresoli.net/only user confirmed/virtual account not confirmed X-Authenticated-Sender: hostingweb31.netsons.net: luca@lucaceresoli.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org An adapter might need to know when a new device is about to be added. This will soon bee needed to implement an "I2C address translator" (ATR for short), a device that propagates I2C transactions with a different slave address (an "alias" address). An ATR driver needs to know when a slave is being added to find a suitable alias and program the device translation map. Add an attach/detach callback pair to allow adapter drivers to be notified of clients being added and removed. Signed-off-by: Luca Ceresoli --- Changes RFCv1 -> RFCv2: - Document struct i2c_attach_operations --- drivers/i2c/i2c-core-base.c | 16 ++++++++++++++++ include/linux/i2c.h | 16 ++++++++++++++++ 2 files changed, 32 insertions(+) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index f26ed495d384..c08ca4bca9c1 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -776,6 +776,11 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf } } + if (adap->attach_ops && + adap->attach_ops->attach_client && + adap->attach_ops->attach_client(adap, info, client) != 0) + goto err_attach_client; + status = device_register(&client->dev); if (status) goto out_free_props; @@ -786,6 +791,9 @@ i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *inf return client; out_free_props: + if (adap->attach_ops && adap->attach_ops->detach_client) + adap->attach_ops->detach_client(adap, client); +err_attach_client: if (info->properties) device_remove_properties(&client->dev); out_err_put_of_node: @@ -832,9 +840,17 @@ EXPORT_SYMBOL_GPL(i2c_new_device); */ void i2c_unregister_device(struct i2c_client *client) { + struct i2c_adapter *adap; + if (!client) return; + adap = client->adapter; + + if (adap->attach_ops && + adap->attach_ops->detach_client) + adap->attach_ops->detach_client(adap, client); + if (client->dev.of_node) { of_node_clear_flag(client->dev.of_node, OF_POPULATED); of_node_put(client->dev.of_node); diff --git a/include/linux/i2c.h b/include/linux/i2c.h index fa5552c2307b..ebc372a0e537 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -567,6 +567,21 @@ struct i2c_lock_operations { void (*unlock_bus)(struct i2c_adapter *adapter, unsigned int flags); }; +/** + * struct i2c_attach_operations - callbacks to notify client attach/detach + * @attach_client: Notify of new client being attached + * @detach_client: Notify of new client being detached + * + * Both ops are optional. + */ +struct i2c_attach_operations { + int (*attach_client)(struct i2c_adapter *adapter, + const struct i2c_board_info *info, + const struct i2c_client *client); + void (*detach_client)(struct i2c_adapter *adapter, + const struct i2c_client *client); +}; + /** * struct i2c_timings - I2C timing information * @bus_freq_hz: the bus frequency in Hz @@ -690,6 +705,7 @@ struct i2c_adapter { /* data fields that are valid for all devices */ const struct i2c_lock_operations *lock_ops; + const struct i2c_attach_operations *attach_ops; struct rt_mutex bus_lock; struct rt_mutex mux_lock; -- 2.17.1