Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8989442ybi; Tue, 23 Jul 2019 19:34:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqw5Ms0iFfRzn0zRHcT/KLPhdWRD2ONVJ7fu+r7tcNJrTlPsqBZbetf0oimd6a0ztpk7P3i6 X-Received: by 2002:a62:2a4d:: with SMTP id q74mr8863942pfq.86.1563935645837; Tue, 23 Jul 2019 19:34:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935645; cv=none; d=google.com; s=arc-20160816; b=cn9KRLEBtR+XAjfp5y+9a5yWk58MKqlSHxNOptjkajz2Gu6+GhzY6CyLyL+qOuSt1B tLDQ4Gyal/B2HOHqegIQkqbFAPvUgYcgw2DliP+3BBi9NIS/u6Z5HFjIbQ65mRA6WK+l vyg8DxMc+dZHSD0dPUwUPCGe7d3u8LNGHvoTQRL+fTU9VunmKFKa3/d6nz/i5b6guxk4 2mrpe5o31iEsIC3jXKlHhUi5O1u6bytMeQidhdWomu745fkLCkLjhJL2LS7WZVjBEkNQ fbpEYCmnkM2is5TcM/f1IHhi8tqKlvFhkY+/ftV8MKZc/iy3ibcfrCC1oVuzn4UH/DLn ds7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature; bh=DiRfhMAnLE+U451154UtajcfiwBNZxW1Y8uvhCpml8A=; b=i0hdCU/iDf+XE2S0St5p9nGD9izO1BAz4oD3vo2dO15jxiwRROlgj1/oxZm9P4jGA0 qUjM0TiNY4yCXE5AHYP+lKJLmjAU1rrVmB03e2eAry1OlL+w9Y3Mi742eHMSIz/sJ6ZY ZLWsDKHEYcaofiYssb09ksckhJwvtEcOPy4jwsFQX2On6iyAfjmZSXxjYLFi4+pO+ENt h6r6LKYzGkYAR44DmaskNMp0Xgwq0GiPBMF4dw+PdFw9OML8U+YK2fwUJka+sN/LLn7B 2vCcJvmTOshhotY4T8Jz6iEACPXBdyw8vVDzZOHgcqW6p8dSOhK/Cx387foY0kBcBp+o zrng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EsXqCRtQ; dkim=pass header.i=@codeaurora.org header.s=default header.b=EsXqCRtQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h65si15263730pfe.216.2019.07.23.19.33.50; Tue, 23 Jul 2019 19:34:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=EsXqCRtQ; dkim=pass header.i=@codeaurora.org header.s=default header.b=EsXqCRtQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392252AbfGWVwf (ORCPT + 99 others); Tue, 23 Jul 2019 17:52:35 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:58132 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbfGWVwf (ORCPT ); Tue, 23 Jul 2019 17:52:35 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7B3C4615BF; Tue, 23 Jul 2019 21:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563918754; bh=RSyzP7VuwcQnmyMg0sztV95p9t97Vsc4pA9J0mnzN7U=; h=Date:From:To:Cc:Subject:From; b=EsXqCRtQp1rf1jr4V+cmLTUrlSbrf275bHrvQuYMmePO+GQyVPUzeXKrOQt+P09ij PAMcGcX5UX1dzHH2ctaWxWjcq8lS7qH0FRvI0F7MNYNEJUWQ83NvM65lQX8iD85HpK 3OFy9z1Wpt1HshIrKf+to8EF+UCeZPvmZ2+VreMo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 34AAC61157; Tue, 23 Jul 2019 21:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563918754; bh=RSyzP7VuwcQnmyMg0sztV95p9t97Vsc4pA9J0mnzN7U=; h=Date:From:To:Cc:Subject:From; b=EsXqCRtQp1rf1jr4V+cmLTUrlSbrf275bHrvQuYMmePO+GQyVPUzeXKrOQt+P09ij PAMcGcX5UX1dzHH2ctaWxWjcq8lS7qH0FRvI0F7MNYNEJUWQ83NvM65lQX8iD85HpK 3OFy9z1Wpt1HshIrKf+to8EF+UCeZPvmZ2+VreMo= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 23 Jul 2019 14:52:34 -0700 From: pheragu@codeaurora.org To: marc.zyngier@arm.com, Linux Kernel , Linux-arm Msm Cc: psodagud@codeaurora.org, Tsoni , rananta@codeaurora.org, mnalajal@codeaurora.org Subject: Warning seen when removing a module using irqdomain framework Message-ID: X-Sender: pheragu@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I have been working on a interrupt controller driver that uses tree based mapping for its domain (irq_domain_add_tree(..)). If I understand correctly, the clients get a mapping when they call platform_get_irq(..). However, after these clients are removed (rmmod), when I try to remove the interrupt controller driver where it calls irq_domain_remove(..), I hit this warning from kernel/kernel/irq/irqdomain.c:: irq_domain_remove(..) [WARN_ON(!radix_tree_empty(&domain->revmap_tree));]- WARNING: CPU: 0 PID: 238 at /kernel/kernel/irq/irqdomain.c:246 irq_domain_remove+0x84/0x98 Also, I see that the requested IRQs by the clients are still present (in /proc/interrupts) even after they had been removed. Hence, I just wanted to know how to handle this warning. Should the client clean up by calling irq_dispose_mapping(..) or is it the responsibility of the interrupt controller driver to dispose the mappings one by one? Regards, Prakruthi Deepak Heragu