Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8991175ybi; Tue, 23 Jul 2019 19:36:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxxYrIBvUXsmJfm6MqbQI2KS5vPZ1x46/Tf1inIbY2DHRfXR5Ioa0R/onFnU0M5OJKqG2fS X-Received: by 2002:a17:90a:ca11:: with SMTP id x17mr86010400pjt.107.1563935767506; Tue, 23 Jul 2019 19:36:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935767; cv=none; d=google.com; s=arc-20160816; b=OzjGSUh/hPx/7Cgvef2wjvAFFVcFee1TJRSbyDAQfk7SYtSFkWHZDRf39A+tIyiizR KLB5ZmFDwd9lOwv88UC4kk5gtB2VMv+oE/FqRZGj1jVduZ7shx/kos6tVDe4zgtKz7cD qEFFmKmbvg4xiOXKeVf2LpQg9o38HPz2bYv2/DZtaMu+GH2RBsVWBJ129K/EplpgU/BR e4sOiEizFeDiVCRPMYdEaw98PspHsV6twEWjVGSnISZC74kx8AjSZmWheIyvZK9dyQrT WTqd6WQhlMYVoG+OBJltOv89czI4E0GYe7NDaXj1MehOrkgBCk358amIrGbjRtCUq1xr tiCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iLlQsDOePU2uDxSgfc3DkH3aQwgn1RD+p0l1lOjUX1Q=; b=wckPEvGDyKPBrTRayW+ykmWv8i1pmVDbzb3IigT41NFThPiAC+5bHrV+AT5eP6n22s VTTGoq1Myk0NfkjefCLN7FlN8kU4Dj7+E1fY6Wx64WrxYwPhfG6gjap6BWBJuUAGaklV kdvFudCWLxr0nF0apaULcgfAqTINj4wODcr+5OFqKzxooaNwfLwkkKZcigBTRNGjUAIR 8EdivkoIuVjtyoNFY6v6oc/7XuBekXMVDRABKM5k1hzxEL9DhMezJTUOZ9BX59MpckSY ovjQUV72hQ9r5XzG5p8546T8j3nzSrA55avJAYH73zfBdGVAoPldRVZLjE0zZDLKA9A3 tQYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e7W+2qpI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j69si11762894pgd.589.2019.07.23.19.35.52; Tue, 23 Jul 2019 19:36:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e7W+2qpI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbfGWXHF (ORCPT + 99 others); Tue, 23 Jul 2019 19:07:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:34602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbfGWXHD (ORCPT ); Tue, 23 Jul 2019 19:07:03 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC0CD2238C; Tue, 23 Jul 2019 23:07:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563923223; bh=pp3VeEKDhtsJD2D+h2rq5js+joCttLYr+igNbqENd4k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e7W+2qpIRb1joAjtfWlNBJt/KSOtXyWnBvuA8+0Q7F1Oq+WLZRZP8dK4gGOVmPlYj abs7IEOWcH4Z/ohf4Ne+Wi6o8APJuPEs+F/ubqOSUpXTVC8MvfW6gCqj7NztM9C57u aoJqKu6PGegI5vf3zrlMe5SIJYnJEOa1dL68TZJw= Date: Tue, 23 Jul 2019 18:07:01 -0500 From: Bjorn Helgaas To: Kelsey Skunberg Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH 00/11] PCI: Move symbols to drivers/pci/pci.h Message-ID: <20190723230701.GA47047@google.com> References: <20190711222341.111556-1-skunberg.kelsey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190711222341.111556-1-skunberg.kelsey@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 11, 2019 at 04:23:30PM -0600, Kelsey Skunberg wrote: > Move symbols defined in include/linux/pci.h that are only used in > drivers/pci/ to drivers/pci/pci.h. > > Symbols only used in drivers/pci/ do not need to be visible to the rest of > the kernel. > > Kelsey Skunberg (11): > PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h > PCI: Move PME declarations to drivers/pci/pci.h > PCI: Move *_host_bridge_device() declarations to drivers/pci.pci.h > PCI: Move PCI Virtual Channel declarations to drivers/pci/pci.h > PCI: Move pci_hotplug_*_size declarations to drivers/pci/pci.h > PCI: Move pci_bus_* declarations to drivers/pci/pci.h > PCI: Move pcie_update_link_speed() to drivers/pci/pci.h > PCI: Move pci_ats_init() to drivers/pci/pci.h > PCI: Move ECRC declarations to drivers/pci/pci.h > PCI: Move PTM declaration to drivers/pci/pci.h > PCI: Move pci_*_node() declarations to drivers/pci/pci.h > > drivers/pci/pci.h | 48 ++++++++++++++++++++++++++++++++++++++++++--- > include/linux/pci.h | 47 -------------------------------------------- > 2 files changed, 45 insertions(+), 50 deletions(-) Hi Kelsey, I didn't get these applied before v5.3-rc1, so now they don't apply cleanly. Would you mind refreshing them and posting a v2 that does apply to my "master" branch (v5.3-rc1)? Bjorn