Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8991234ybi; Tue, 23 Jul 2019 19:36:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwwAmArpTwKEvm0zT8hkcRP4dGk85RVvY5qIOFC7GQfk6gMkUtKrGT6G5hgUrWWJi+aoamz X-Received: by 2002:a17:902:2ac7:: with SMTP id j65mr84224805plb.242.1563935772232; Tue, 23 Jul 2019 19:36:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935772; cv=none; d=google.com; s=arc-20160816; b=clV3f51dv6w1mpaUeU2eTNrbyW6Q/8gCRWk9/IdLehZ58c24uAkiTZ/Wd23XlG3LUp IyuvaTFb3lEYqG62pSqGezLUrUYZzeDNztP0AIGaN4Y7QBef7s/pWBcPi7GXmMk2400B WFGkT11qQ5ZZiSRSQXOdifWUwo1f6fj/U5ARp4kOnoOIIBJ3LZdKa2w+jYilwYkUXL7O IsQS5XJGCdoIpeFJbD/HoB6vex7n3UngcKzGZmXp8+xX2aNWFO5XiZ4fbQGNolV4qBWr t6s/Fz1Mrlo5+0fnhw9uj6e1ROmXtBbr0s7gj+MgP8FMlm9t89GqJHbET6ihKqC/zkeQ GPrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OKl/UO0N722owerZ7uvxTX5GkSBg77fwKXsdJcJ89jw=; b=y31ws6Skl7preyHxJcDbETfr53tH8EGzYlVgak3V12hNfsmNs2ypIcL1a5li2y1XDc NrprvqLaMJtATFAMP2YyZqinQV0+BSLiRf4FSIPbTJzPTf3Y6T9WjMhwpMrD4OrEIztl Ei6tMd+cQe0hUx53v87sfPGjK4gT56jzf6O0AF5XNKNGrV8uBK0w0McYdfXO0kH00ssz WO+opuLHJ6AKlPr8v7AL0piwqKrPJJQrr+Nt2ZLcbuzxCM5tSO8p3Zys7s9E0+s2GEa3 ke/EsHrrTO96b9bHEv7eT7YPJrpxpWtcD07epwvBiEQpQIGE5WttujyEvzcw/+JpGfKc sIbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="W/azuwYc"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si12419564plu.126.2019.07.23.19.35.58; Tue, 23 Jul 2019 19:36:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="W/azuwYc"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbfGWXYS (ORCPT + 99 others); Tue, 23 Jul 2019 19:24:18 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:34031 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbfGWXYR (ORCPT ); Tue, 23 Jul 2019 19:24:17 -0400 Received: by mail-io1-f67.google.com with SMTP id k8so85604789iot.1; Tue, 23 Jul 2019 16:24:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OKl/UO0N722owerZ7uvxTX5GkSBg77fwKXsdJcJ89jw=; b=W/azuwYc5RF0CLl2tNylYs96mx//cO/dqpDHVSi7Tx5ZOsQpKCKderAm4PQFHc0Wlo CA5ArjI4C7GISOF1gvZGapcPsBoiGrJOBC+Hhg+kEbHGOkqJwf7WmqohdzXTMSFD4asg F6J9p+jkhfqSQTcRZWUIaMENq/j+pKJ+jSImB11LK7FMkGbjQP6eKY96aTkBo+aRrj0G E+KI0xJHmHtf5Y32Fi5SvSZzpRUKwPLlGaZgi1exYiopX5P0DSZGynbyT1+s+bHOq+3Y ZlSyTX7uG1STgviFa2wV6W6P2JmZpuODDmKO/5Mv5vrX6vSqd/fzi+zmaeVL1AYKEOHC AhRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OKl/UO0N722owerZ7uvxTX5GkSBg77fwKXsdJcJ89jw=; b=g4CWHeznJBgIRZIaiiD/7YGe/1ClqlUuh9UrElpvoCyk7HhORCHsmcYHoLDlEZdo8A YKWJueS9bX8Ro3IQUQdKUhLEScSkPrUtEy4C69A1YZb3Frz38PG8c31rehfIBRrwDfy3 nwuRmfFXOtS1Pe9RxvDNCZsVA4npylp7QXdOa7EJvcilCxV4RUAu/Dh9kijrFpk4MTTw N8RVClfisOZNm637gPIMxqSN5+gajpp155xVmc7ywDkj5iHQ5FI2aXdOYLR7rt5/elmH i6bpGvWiJdsrrSQrpikPNQTZZZXdReiGeImJSW9xmruDtAt5GEDdrItgDoWG4wQhPeiJ /37g== X-Gm-Message-State: APjAAAXAJ812OQeQLHBaT+7OwC9j4wXDFM42jX7rULmAVqfqShxyWC3b YDLH/+qHs+BpAmKZ5U5rnrg= X-Received: by 2002:a02:5ec9:: with SMTP id h192mr79609871jab.25.1563924257148; Tue, 23 Jul 2019 16:24:17 -0700 (PDT) Received: from JATN (c-73-243-191-173.hsd1.co.comcast.net. [73.243.191.173]) by smtp.gmail.com with ESMTPSA id s10sm106218264iod.46.2019.07.23.16.24.15 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 23 Jul 2019 16:24:16 -0700 (PDT) Date: Tue, 23 Jul 2019 17:24:14 -0600 From: Kelsey Skunberg To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH 00/11] PCI: Move symbols to drivers/pci/pci.h Message-ID: <20190723232414.GB16776@JATN> References: <20190711222341.111556-1-skunberg.kelsey@gmail.com> <20190723230701.GA47047@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190723230701.GA47047@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 23, 2019 at 06:07:01PM -0500, Bjorn Helgaas wrote: > On Thu, Jul 11, 2019 at 04:23:30PM -0600, Kelsey Skunberg wrote: > > Move symbols defined in include/linux/pci.h that are only used in > > drivers/pci/ to drivers/pci/pci.h. > > > > Symbols only used in drivers/pci/ do not need to be visible to the rest of > > the kernel. > > > > Kelsey Skunberg (11): > > PCI: Move #define PCI_PM_* lines to drivers/pci/pci.h > > PCI: Move PME declarations to drivers/pci/pci.h > > PCI: Move *_host_bridge_device() declarations to drivers/pci.pci.h > > PCI: Move PCI Virtual Channel declarations to drivers/pci/pci.h > > PCI: Move pci_hotplug_*_size declarations to drivers/pci/pci.h > > PCI: Move pci_bus_* declarations to drivers/pci/pci.h > > PCI: Move pcie_update_link_speed() to drivers/pci/pci.h > > PCI: Move pci_ats_init() to drivers/pci/pci.h > > PCI: Move ECRC declarations to drivers/pci/pci.h > > PCI: Move PTM declaration to drivers/pci/pci.h > > PCI: Move pci_*_node() declarations to drivers/pci/pci.h > > > > drivers/pci/pci.h | 48 ++++++++++++++++++++++++++++++++++++++++++--- > > include/linux/pci.h | 47 -------------------------------------------- > > 2 files changed, 45 insertions(+), 50 deletions(-) > > Hi Kelsey, > > I didn't get these applied before v5.3-rc1, so now they don't apply > cleanly. Would you mind refreshing them and posting a v2 that does > apply to my "master" branch (v5.3-rc1)? > > Bjorn Hi Bjorn, I can absolutely do that. I'll have v2 sent out soon. -Kelsey