Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8991860ybi;
        Tue, 23 Jul 2019 19:36:55 -0700 (PDT)
X-Google-Smtp-Source: APXvYqxzRtv0xovt4xk55bfkYpQMB+9M7UMHAD+w4t04YUcUUz/Fj4ueemscFJt1ojN6VXMI/eMo
X-Received: by 2002:a17:90a:fa07:: with SMTP id cm7mr82845382pjb.138.1563935815638;
        Tue, 23 Jul 2019 19:36:55 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1563935815; cv=none;
        d=google.com; s=arc-20160816;
        b=M7bjNVcGcAhWCMXPK0hYlhFxMUBtvcXFsn9FtDByxixc8phGAuY+Cox7DLj96aVl07
         CneG2YQMpXQpBPFaJNNPnLynRMIjv+hEft8/lCU+1JogK8eFKqLFwcNTaGq3NP9TX5Y/
         ffq0Kwxks4r8mfly+K7S0mvr6wpw0pEpUd3bpjvQkgRuYUKt0sfO/oDFylEJ5pOaX4G4
         JkZ7KSoyhZkjPE7QgPafL6mzK7TbywYPxzFwEhZUAgJDd8bEjXBdKzq9HWDhDeFXJxEp
         BXyCrU+GJuExOfULQYzLLVH3MYEgm+SlzNCY0bgpUMD5tmbQxlR0XWf6bxtHp65QMq3T
         hoSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=81R/Z2rovzmAa3O7DCJ8y2Mm5lAz4O2B1wbIdVhO0d8=;
        b=EOaU+Y9fExeLS5ie2HOON3r9p56GxteU7bZ9wzMBB3xB0Vo9dS5kJlzST1E27wHksy
         nMeC56JtydZIH1GAtc7mzvqnO6bR2z5Dlaik0VtCh8B4LdZ+shB0jhCWcATwdrhakNOs
         6eV8LCiiZFM9PPFDOPx+bIvdaoKgKCbuHaQ9acY55Gq6Wlhqbut/q9yeey80U3tkU4oX
         DCf8DTOCxZqnKNTcjshIhLCGrD7pdcA/opT5OiE4b9Qii/I8WCl9UpQZX0aOt68OyhbS
         fdc4bsidv6PODZLNiaKMrEn8j//XqZGtBJyY96sOR5sWvLCnMjxOHqLOqJSdFUC+t6Ll
         HwWw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=L8+8TSTf;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id y10si12481023plp.117.2019.07.23.19.36.41;
        Tue, 23 Jul 2019 19:36:55 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=L8+8TSTf;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728273AbfGXBbn (ORCPT <rfc822;chenl.lei@gmail.com> + 99 others);
        Tue, 23 Jul 2019 21:31:43 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:5085 "EHLO
        hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725837AbfGXBbn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 Jul 2019 21:31:43 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d37b5040000>; Tue, 23 Jul 2019 18:31:48 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Tue, 23 Jul 2019 18:31:41 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Tue, 23 Jul 2019 18:31:41 -0700
Received: from [10.110.48.28] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 24 Jul
 2019 01:31:40 +0000
Subject: Re: [PATCH v2 1/3] mm/gup: add make_dirty arg to
 put_user_pages_dirty_lock()
To:     <john.hubbard@gmail.com>, Andrew Morton <akpm@linux-foundation.org>
CC:     Alexander Viro <viro@zeniv.linux.org.uk>,
        =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@intel.com>,
        Boaz Harrosh <boaz@plexistor.com>,
        Christoph Hellwig <hch@lst.de>,
        Daniel Vetter <daniel@ffwll.ch>,
        Dan Williams <dan.j.williams@intel.com>,
        Dave Chinner <david@fromorbit.com>,
        David Airlie <airlied@linux.ie>,
        "David S . Miller" <davem@davemloft.net>,
        Ilya Dryomov <idryomov@gmail.com>, Jan Kara <jack@suse.cz>,
        Jason Gunthorpe <jgg@ziepe.ca>, Jens Axboe <axboe@kernel.dk>,
        =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= <jglisse@redhat.com>,
        Johannes Thumshirn <jthumshirn@suse.de>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Ming Lei <ming.lei@redhat.com>, Sage Weil <sage@redhat.com>,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        Yan Zheng <zyan@redhat.com>, <netdev@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, <linux-mm@kvack.org>,
        <linux-rdma@vger.kernel.org>, <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Ira Weiny <ira.weiny@intel.com>
References: <20190724012606.25844-1-jhubbard@nvidia.com>
 <20190724012606.25844-2-jhubbard@nvidia.com>
From:   John Hubbard <jhubbard@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <5c303c80-57fd-d278-44d5-942597051c9b@nvidia.com>
Date:   Tue, 23 Jul 2019 18:31:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190724012606.25844-2-jhubbard@nvidia.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1563931908; bh=81R/Z2rovzmAa3O7DCJ8y2Mm5lAz4O2B1wbIdVhO0d8=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=L8+8TSTfHtIkC1xowWnZPPItlJoP+leFf6ucvU5E2owqzMuOQ9jIZ8vvOAmRE48gG
         nJc2BkzeiefBvFmLrdVIpofi+FqWCxnLVVCD8Km+TEsxK75nMF86BzzMDvJhOtd4Sv
         tv/oBJtf5JB77EfsmMmPFfjUqHdF8FrA9NTbWBGktbrAYnfNv/v7rTGnTIY6IQINWA
         7KWjSbQNfLlkpCFtMta3TS57pn2JgRvHM6UCjTP01IAnW414t4BHJWGwnR2xyxPuNo
         ve66cppddE8vW2LUpVK1xyY3WfDsi+6f6NZZzv7rod362wLBdY3VFm9CgxAGyrUul/
         iXE/3sT5XunbA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/23/19 6:26 PM, john.hubbard@gmail.com wrote:
> From: John Hubbard <jhubbard@nvidia.com>
...
> +		 * 2) This code sees the page as clean, so it calls
> +		 * set_page_dirty(). The page stays dirty, despite being
> +		 * written back, so it gets written back again in the
> +		 * next writeback cycle. This is harmless.
> +		 */
> +		if (!PageDirty(page))
> +			set_page_dirty_lock(page);
> +		break;

ahem, the above "break" should not be there, it's an artifact, sorry about 
that. Will correct on the next iteration.

thanks,
-- 
John Hubbard
NVIDIA


> +		put_user_page(page);
> +	}
>  }
>  EXPORT_SYMBOL(put_user_pages_dirty_lock);
>  
>