Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Jul 2019 11:40:00 +1000
From:   Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH] kbuild: clean compressed initramfs image
To:     Andrew Morton <akpm@linux-foundation.org>,
        Greg Thelen <gthelen@google.com>
Cc:     linux-kernel@vger.kernel.org
References: <20190722063251.55541-1-gthelen@google.com>
In-Reply-To: <20190722063251.55541-1-gthelen@google.com>
MIME-Version: 1.0
User-Agent: astroid/0.14.0 (https://github.com/astroidmail/astroid)
Message-Id: <1563932322.lqg59sj895.astroid@bobo.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Greg Thelen's on July 22, 2019 4:32 pm:
> Since commit 9e3596b0c653 ("kbuild: initramfs cleanup, set target from
> Kconfig") "make clean" leaves behind compressed initramfs images.
> Example:
>   $ make defconfig
>   $ sed -i 's|CONFIG_INITRAMFS_SOURCE=3D""|CONFIG_INITRAMFS_SOURCE=3D"/tm=
p/ir.cpio"|' .config
>   $ make olddefconfig
>   $ make -s
>   $ make -s clean
>   $ git clean -ndxf | grep initramfs
>   Would remove usr/initramfs_data.cpio.gz
>=20
> clean rules do not have CONFIG_* context so they do not know which
> compression format was used.  Thus they don't know which files to
> delete.
>=20
> Tell clean to delete all possible compression formats.
>=20
> Once patched usr/initramfs_data.cpio.gz and friends are deleted by
> "make clean".
>=20
> Fixes: 9e3596b0c653 ("kbuild: initramfs cleanup, set target from Kconfig"=
)
> Signed-off-by: Greg Thelen <gthelen@google.com>

Thanks for that, looks good to me.

Thanks,
Nick
=