Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8992220ybi; Tue, 23 Jul 2019 19:37:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyvneuFMe7wVjxekks3CS3HvPsbn98AHeWxz+mlqhriOmPmN8nT7arm8MqnLK9YorDNfg4u X-Received: by 2002:a17:902:9b81:: with SMTP id y1mr86816223plp.194.1563935840874; Tue, 23 Jul 2019 19:37:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935840; cv=none; d=google.com; s=arc-20160816; b=s2JgFB49ZbgLeNzfjKtQz34TAMabb7FvqDao3AFWp53d1+lyn1G/cfhhUozqL3sxIW g6H3N8J03SURw2lN/vZrtOabsWO/7i/Ape3I3Cj4xCrtvPljEyWP1lmoQhdHfm6xWDgF 4lwWR0ggrtI1aIATkwqwVwfKE2Ktj1mZYEKHSiZpFtDtlXlXRrzj99FReXgxL3avmwTc vO1RzgQphmJ1twn2o500dHGGjskGVYjCR4qmeyZTVXurjBYcH9iZiNpmoFeAtfu9Bmb0 3/UyGXLsO7Jiv4R7NAZsK+w+um+2kyHzDocaVWQeh5J210nlTCpr3DowLRSiJfLUaFIX zwug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=ookzW0jHoh9jRaU8lF/IhvTsxSlTrEZhE6haD/yI3AE=; b=tDwMvkShPk6Q0+twEj7nklNBRW6ZC8Ot6C7P/BNSWvRfrHIJEM1WwfSx/yGUh0veUI eqZLUgcEkNzQR+Arlwr0PoqL1ugwVrNa9w+IoAiDPhg4YU/VwBqe/+OpyN7Mk02YFKqI n5jfQDt70uAwgktSJQTCSkQsm2UXbCbezJ8QzgegVfkYP0jgSCJpiGWGiLiesy0coEEd 9BnFSPwfwcBlOy7up8pqHchbOv0n1XucnSAQg9tHCDK6C8I5DVJkCPzzhNBCBdvdLWjR VKvRT7VuuX6ExF6TDszfVn8LcP/DPlgoW9Iync9pXYji4OUZFT3jZOTPd12l7mSKRDHu VIWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=V4pFJ9lw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k13si12883132pgj.525.2019.07.23.19.37.06; Tue, 23 Jul 2019 19:37:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=V4pFJ9lw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727497AbfGXALH (ORCPT + 99 others); Tue, 23 Jul 2019 20:11:07 -0400 Received: from mail-vk1-f202.google.com ([209.85.221.202]:48659 "EHLO mail-vk1-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbfGXALG (ORCPT ); Tue, 23 Jul 2019 20:11:06 -0400 Received: by mail-vk1-f202.google.com with SMTP id x71so11024865vkd.15 for ; Tue, 23 Jul 2019 17:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=ookzW0jHoh9jRaU8lF/IhvTsxSlTrEZhE6haD/yI3AE=; b=V4pFJ9lwZqKTmV97ahbkdxcANM7ct0Yds9sbuKyruQ1jBsj58370BpYL/1ZUGQ/6dN +wdYn4nI4wjnhRHlTOQHbMpeVQMHIpJhE6jeebZF92PISTV8OYG1E+JbCjdg/n7WvbWp xbyucFm4ZZW7LtiLTgwQZQ7gzHIrgSpHAGehyaOiSHdanO0tSHCV2qaFDd48HCBYDFct OTyv+zhyGwZ47crUExsVwHklbVGP5V94JfJf0uRn7TJybLY2OMDABFOFqd/He/tvWF7c FdP6iYQOQ07wZiH97Zdj8LIf3RodkeBgTlAPP24zxkmHjPAKGzcBrqZw/V79Nh9a13bs eevQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=ookzW0jHoh9jRaU8lF/IhvTsxSlTrEZhE6haD/yI3AE=; b=UExxSv6n7txzHQMsgzRxzbt7wUoheYWBP0X0eV5iAMftH7Fv0ff14aTWgcUnNf4ORj +Ys2wbGPLVu9ENOuPHopN1odNSrO2T1K7Gz1QDJM56NLPvo2sW7EHNiYFtOGZuxo3j/Z C563Ay/EFYxgKTGo+Gl85yPNjSZo8u9Izk2g8hNJoIDEDW1jZSrQInx7rs16VyQ2DOxy 6JUN542a7R/odSX/dT3fbrSY7eb1/ugfPx13JjQvhGUuaam9PAN0aNf7Fx9Yt3tMON9W 170iDY0/f8deYaAB9HX7sbAm7+1wejZtUgz3Z39SCvnI3sTEjDe1enr48huuPTt7jSng gzZA== X-Gm-Message-State: APjAAAWhiC3uPjIcbYmVzAlD/cOVkeQWrR6/tC3a9312Dzw0Xjv4CDoV XmLTS3mCXc6/CU7+aormauTLhFCTGK0Mog4= X-Received: by 2002:a1f:1b0a:: with SMTP id b10mr31020990vkb.19.1563927065144; Tue, 23 Jul 2019 17:11:05 -0700 (PDT) Date: Tue, 23 Jul 2019 17:10:53 -0700 Message-Id: <20190724001100.133423-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.22.0.709.g102302147b-goog Subject: [PATCH v7 0/7] Solve postboot supplier cleanup and optimize probe ordering From: Saravana Kannan To: Rob Herring , Mark Rutland , Greg Kroah-Hartman , "Rafael J. Wysocki" , Frank Rowand Cc: Saravana Kannan , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, David Collins , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add device-links to track functional dependencies between devices after they are created (but before they are probed) by looking at their common DT bindings like clocks, interconnects, etc. Having functional dependencies automatically added before the devices are probed, provides the following benefits: - Optimizes device probe order and avoids the useless work of attempting probes of devices that will not probe successfully (because their suppliers aren't present or haven't probed yet). For example, in a commonly available mobile SoC, registering just one consumer device's driver at an initcall level earlier than the supplier device's driver causes 11 failed probe attempts before the consumer device probes successfully. This was with a kernel with all the drivers statically compiled in. This problem gets a lot worse if all the drivers are loaded as modules without direct symbol dependencies. - Supplier devices like clock providers, interconnect providers, etc need to keep the resources they provide active and at a particular state(s) during boot up even if their current set of consumers don't request the resource to be active. This is because the rest of the consumers might not have probed yet and turning off the resource before all the consumers have probed could lead to a hang or undesired user experience. Some frameworks (Eg: regulator) handle this today by turning off "unused" resources at late_initcall_sync and hoping all the devices have probed by then. This is not a valid assumption for systems with loadable modules. Other frameworks (Eg: clock) just don't handle this due to the lack of a clear signal for when they can turn off resources. This leads to downstream hacks to handle cases like this that can easily be solved in the upstream kernel. By linking devices before they are probed, we give suppliers a clear count of the number of dependent consumers. Once all of the consumers are active, the suppliers can turn off the unused resources without making assumptions about the number of consumers. By default we just add device-links to track "driver presence" (probe succeeded) of the supplier device. If any other functionality provided by device-links are needed, it is left to the consumer/supplier devices to change the link when they probe. v1 -> v2: - Drop patch to speed up of_find_device_by_node() - Drop depends-on property and use existing bindings v2 -> v3: - Refactor the code to have driver core initiate the linking of devs - Have driver core link consumers to supplier before it's probed - Add support for drivers to edit the device links before probing v3 -> v4: - Tested edit_links() on system with cyclic dependency. Works. - Added some checks to make sure device link isn't attempted from parent device node to child device node. - Added way to pause/resume sync_state callbacks across of_platform_populate(). - Recursively parse DT node to create device links from parent to suppliers of parent and all child nodes. v4 -> v5: - Fixed copy-pasta bugs with linked list handling - Walk up the phandle reference till I find an actual device (needed for regulators to work) - Added support for linking devices from regulator DT bindings - Tested the whole series again to make sure cyclic dependencies are broken with edit_links() and regulator links are created properly. v5 -> v6: - Split, squashed and reordered some of the patches. - Refactored the device linking code to follow the same code pattern for any property. v6 -> v7: - No functional changes. - Renamed i to index - Added comment to clarify not having to check property name for every index - Added "matched" variable to clarify code. No functional change. - Added comments to include/linux/device.h for add_links() I've also not updated this patch series to handle the new patch [1] from Rafael. Will do that once this patch series is close to being Acked. [1] - https://lore.kernel.org/lkml/3121545.4lOhFoIcdQ@kreacher/ -Saravana Saravana Kannan (7): driver core: Add support for linking devices during device addition driver core: Add edit_links() callback for drivers of/platform: Add functional dependency link from DT bindings driver core: Add sync_state driver/bus callback of/platform: Pause/resume sync state during init and of_platform_populate() of/platform: Create device links for all child-supplier depencencies of/platform: Don't create device links for default busses .../admin-guide/kernel-parameters.txt | 5 + drivers/base/core.c | 168 ++++++++++++++++ drivers/base/dd.c | 29 +++ drivers/of/platform.c | 189 ++++++++++++++++++ include/linux/device.h | 55 +++++ 5 files changed, 446 insertions(+) -- 2.22.0.709.g102302147b-goog