Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8993282ybi; Tue, 23 Jul 2019 19:38:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLq2cfvKpb4ZBidyErLkCISkNtogkNkFLO9Tbps05lFViZxGLfUBy6pzxjMdS6gwgFp0Tg X-Received: by 2002:a62:64d4:: with SMTP id y203mr8824377pfb.91.1563935917662; Tue, 23 Jul 2019 19:38:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935917; cv=none; d=google.com; s=arc-20160816; b=DmqOdDxW+jqlXRnGkaO+K2y28kiE9QD2TGKZ7N4pjTELQmXPNbCuVEo+FHEIcnh6bI wEjD/Ds2cYWBuVEddP0AOgxDY1w29hhDMCcXJ8BAA8Qxyhgr8TGq4fVb04XjYLQ+TzUM +k/5uDrhEUsgYUUkxZSc2jq2KQRGw7a5XrsgzdAdmRquSa1tzvIa6X6XSBcslDcvdIJ2 +E4O3wVnS5KSUmWCPDlygqzvZtwIyD1sKv8jigUceindQ71TFgmRVtmS40opgdsSlZIN 7IDqnIzGRMMew7t9MRuSf/0zLDojs0WlI8KKCeuexnOOxCegNBOQ0vvE8q/EK+Gp+NQY 2o6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=QQbuGZFQICZe1Y2UCIG/poXcgDM2WHVBcxwOztpE0QI=; b=CtYkKiIX1BVFpxz+Oom8OzEdiQGW4DpL3NTGeJeEo6OEAlmDlnUOmLL4ezjezTA51X D1XMOCmMc33IvkDD1APktsOKqMF0KiXyu9qab2+3L9XBwcPVMXJyiyyIG+dsvozBUU7n xpTclv9CtD/+glIGjku9b+m6COCMRyEodgZr6CM/Husd//fW1Y5gWESWYrI1165HnB5H l/Yv3jCGUCVMiA1ncSTydFMnJT7iUtyivzSgEv6FVEl8/joAJSwYF2gqPsANGbsXayUE cz8zkkxNpzaYnVpxUwQINzQOnB0Eh8KkkcNvF4oH3WEJEwsHgNFYg34RLF2FLSB1Xpf3 vzdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b21si15073802plz.21.2019.07.23.19.38.23; Tue, 23 Jul 2019 19:38:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387493AbfGXCZD (ORCPT + 99 others); Tue, 23 Jul 2019 22:25:03 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:50043 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726606AbfGXCZC (ORCPT ); Tue, 23 Jul 2019 22:25:02 -0400 X-IronPort-AV: E=Sophos;i="5.64,300,1559491200"; d="scan'208";a="72058067" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 24 Jul 2019 10:25:00 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id B9FB44CDE933; Wed, 24 Jul 2019 10:15:04 +0800 (CST) Received: from localhost.localdomain (10.167.215.46) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 24 Jul 2019 10:15:04 +0800 From: Yang Xu To: , CC: , Yang Xu Subject: [PATCH v2] sys_prctl(): remove unsigned comparision with less than zero Date: Wed, 24 Jul 2019 10:11:48 +0800 Message-ID: <1563934308-20833-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <20190723094809.GE4832@uranus.lan> References: <20190723094809.GE4832@uranus.lan> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.215.46] X-yoursite-MailScanner-ID: B9FB44CDE933.AECF0 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: xuyang2018.jy@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, when calling prctl(PR_SET_TIMERSLACK, arg2), arg2 is an unsigned long value, arg2 will never < 0. Negative judgment is meaningless, so remove it. Fixes: 6976675d9404 ("hrtimer: create a "timer_slack" field in the task struct") Signed-off-by: Yang Xu Cc: Cyrill Gorcunov --- kernel/sys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sys.c b/kernel/sys.c index 2969304c29fe..701b5f00651d 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -2372,7 +2372,7 @@ SYSCALL_DEFINE5(prctl, int, option, unsigned long, arg2, unsigned long, arg3, error = current->timer_slack_ns; break; case PR_SET_TIMERSLACK: - if (arg2 <= 0) + if (arg2 == 0) current->timer_slack_ns = current->default_timer_slack_ns; else -- 2.18.1