Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp8993892ybi; Tue, 23 Jul 2019 19:39:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkBXNU0ybWIe2PjVTvTfp+/9tJOsvoDMR0zHe2b6qUMzIsXUIj+XIrUuUNX6cju2dCPhQd X-Received: by 2002:a17:902:da4:: with SMTP id 33mr76416070plv.209.1563935956964; Tue, 23 Jul 2019 19:39:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563935956; cv=none; d=google.com; s=arc-20160816; b=ezUrZp1gTERAo7Q/AqednDanQO+4Tt4294KN9izIZLU6JfV6eoMi+vXjqCqS7e/Gaw tP81sJ09ecKReL/+y45p3scYd5Q2pXdGxBrDTgBA99EGdtQcLDVkLvWJiR1vqze0rqS3 167ZhJC+q596spZqm2bLqtBWn9jfYoIdzC8QL80am8kVixJ+yHb+pTcSM4QrAuGLsequ ADATlX2RVxIj+fqV8zyrqA8TojMMPv5L2mPKvpjWuF8+39lFU+CfzbaoWfR6crRBaNDR aVRb4Kg7tOUgJmMJVCyGFESU5q6OdnnBAWiF3fZ2uPitocOpGDTmHzC0NGD1IKHL1G+Z mOdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=wUoL7Z86OEs4qLzhJXZrHf0vot8+kbrUJlufMs9r9h4=; b=kUZENfNGgBqU8jXYFmtQfg/FvYvIC9tfzrRWUtlIhbJfKvmOJTa7kEkcn6UD70GOmS uZEZgwaMNeS+JnGLvgct56u3LcjAP38gWH6jG3DYo4E4c88A6QW3YZApJdx3f/Rj8MYB c7bjoXor0c7lgza+YLhPaJInH2gPPnltS+KvWnb25O7H/oj/rsWiVnTnEHfppUhqJbXX mI5IqyLwaY6x4PGadWPZ8BgpcnvY21Czdu81NjIEXuA+tGT5JdorLPIfDWUPB5TRe/4N fuVvrPEvGxSK1b5v4xErr9+Oj/tlNo4la+4FVmH5PCReW+Ofw/Kj3bbvMezqPSOaL+qg xCZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=tfbt2I4K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y14si18924061pfr.82.2019.07.23.19.39.02; Tue, 23 Jul 2019 19:39:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=tfbt2I4K; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726043AbfGXCPs (ORCPT + 99 others); Tue, 23 Jul 2019 22:15:48 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:34312 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbfGXCPr (ORCPT ); Tue, 23 Jul 2019 22:15:47 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6O2EXn6039333; Wed, 24 Jul 2019 02:15:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=wUoL7Z86OEs4qLzhJXZrHf0vot8+kbrUJlufMs9r9h4=; b=tfbt2I4KTCy+11Ro1lX/a4E4Y06wol9qWrz+6I1aHlmnTVNK76HqaMIWTBtzwwfuTpVj rZkYkENvURhcfbUu2UKdL/GAjW231SqkBSXbrAlrjhefYzaGyCYW2I1JOR7YZ5azFpc+ nlf0cLdgq2n0bRMaUwHi8bam1Eh+5xor4nULCo9NkISeoKRt+oNVgYhe1y5Po2fS2yfj 1oJ3XFdxyrqbSbAhVAK4mP03t6kXxymtj0Y3daFzI5xKs3Q4605egArFmy3DWnj6KaUY UsIy4EEtXjYXvKfdpmLRwjQUGxpQgCU0FukMVrxIAGQe8OyA3Z9iTEWA1iCzFqasMdyS IA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2tx61bt7jk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jul 2019 02:15:45 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x6O2CsSN092226; Wed, 24 Jul 2019 02:15:44 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2tx60xkhtb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 24 Jul 2019 02:15:44 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x6O2FhEn011364; Wed, 24 Jul 2019 02:15:43 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 23 Jul 2019 19:15:42 -0700 To: Junxiao Bi Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kashyap.desai@broadcom.com, sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com, martin.petersen@oracle.com Subject: Re: [PATCH RESEND] scsi: megaraid_sas: fix panic on loading firmware crashdump From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190722161524.23192-1-junxiao.bi@oracle.com> Date: Tue, 23 Jul 2019 22:15:40 -0400 In-Reply-To: <20190722161524.23192-1-junxiao.bi@oracle.com> (Junxiao Bi's message of "Mon, 22 Jul 2019 09:15:24 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9327 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=669 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907240023 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9327 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=735 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1907240023 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Junxiao, > While loading fw crashdump in function fw_crash_buffer_show(), left > bytes in one dma chunk was not checked, if copying size over it, > overflow access will cause kernel panic. Applied to 5.3/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering