Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9194394ybi;
        Tue, 23 Jul 2019 23:42:57 -0700 (PDT)
X-Google-Smtp-Source: APXvYqy/574gbLDgO1+zfLfWso0mnn1GqgUX/5UZXk+Zpx5/S6y38we57qtKUdBhb5j7jjb3DdVq
X-Received: by 2002:a63:b102:: with SMTP id r2mr9818285pgf.370.1563950576902;
        Tue, 23 Jul 2019 23:42:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1563950576; cv=none;
        d=google.com; s=arc-20160816;
        b=mKa3yRhQYvnvogbq7SfCt0vNK3uX84+AqBf5Wb1/aC27fHMLabWQClX5z095i+kT2Z
         1JBJJB2+PAse6UTzsFyKVz0+LxXFUXbcYkYp+QYSbqyCVF15x5tHnqxsFDGAAk8WdODD
         TdU54IFokLOYdIlVJi/djjDiHM+MEIneOyBvbaDxqZci0gm7Mm+QF+BtcGdWDmv4svuF
         x8O7lFeNa6PSXu7nSu51wJbsu+7aEs2RJ2QA8u9DnpkH1bit0HhKlkGC1o7QL8U8O2Wp
         3CH5cqpcKSLIIljiqr2rxOnRtL0sc+BTxrJjCYApg7rR3mwr3AZJjUJwAkDVyuLBQ59B
         lsUA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=g96D4ApIOGkTzcjdy6YtT9b/KtR9E/nksr8Tz76ZlKY=;
        b=b4jx9tMNTkCUSNPSh2HV5VyUX8GRgPsdvsotY4UjQVOUgla5POtvE4btvOYk9hoBMD
         oFWFJRFix7CUN2zOjXrGKMLsROj/Z5VQk24BruT0bFq4aPOXitHDIWm+6P5hniUEWp97
         YJ3Ph5LVa7I2JIwY6vRTIDKQVabrHAGTNEi3Sw4rgHzsz3RFSAV76L4qBUKY9r8EmQOZ
         vYWVcbUWkkiTWuzB4Bei7lFUyin/u/aIE4I78KQ5q8bzk67+NQMy8c0UYKZV0Z0AJ3Il
         hUeUMdFtQhhbyFpSCLlVMt75tXjOEyqzR4tkqoKHSry6MB2aeaL1+pXt48SrhKQftjS5
         /8qg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="IB4B3//Z";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id q1si14940381pgv.58.2019.07.23.23.42.41;
        Tue, 23 Jul 2019 23:42:56 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b="IB4B3//Z";
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726167AbfGXGlU (ORCPT <rfc822;shmalave.kernel@gmail.com>
        + 99 others); Wed, 24 Jul 2019 02:41:20 -0400
Received: from hqemgate16.nvidia.com ([216.228.121.65]:6374 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725909AbfGXGlU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Jul 2019 02:41:20 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5d37fd8d0002>; Tue, 23 Jul 2019 23:41:17 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Tue, 23 Jul 2019 23:41:19 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Tue, 23 Jul 2019 23:41:19 -0700
Received: from [10.24.46.79] (172.20.13.39) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 24 Jul
 2019 06:41:16 +0000
Subject: Re: [PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin
To:     Dmitry Osipenko <digetx@gmail.com>,
        "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
        "airlied@linux.ie" <airlied@linux.ie>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        Jonathan Hunter <jonathanh@nvidia.com>
CC:     "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <1563787632-19762-1-git-send-email-viswanathl@nvidia.com>
 <11288075-f34a-222c-66da-2bfd13db987c@gmail.com>
 <fe7a0f13-4e85-56db-7629-92c6a8f67014@nvidia.com>
 <5281fd84-bbe8-8482-0224-068b87349aaa@gmail.com>
From:   Viswanath L <viswanathl@nvidia.com>
Message-ID: <5142f8d7-a387-a556-8209-536439be4925@nvidia.com>
Date:   Wed, 24 Jul 2019 12:11:13 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <5281fd84-bbe8-8482-0224-068b87349aaa@gmail.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1563950477; bh=g96D4ApIOGkTzcjdy6YtT9b/KtR9E/nksr8Tz76ZlKY=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=IB4B3//Zn56Hj/tus4pf69WYZzx2eWrV1celvtp+CrKNjYMeOQweQI2Gw+JydwvvF
         i+/KcylKF4DPnfQMaYzyGrtW2vQmR/yfr1SGo/rEPrzT8GaXB+HORffU9Q5d2s64XL
         G3eClMqwnORXr15sf2AAV4d7yaEpbYRoxmHNh9Nuaf7BsJROmNyYjr42clgpqdv+mp
         vhHJ4LaZna1plLDmxgMu05ckg1jVvNEbe6SckH4p5uHUEyozNWFkFjQAbjGeqMt4WC
         gh/LFGuMU6JXntxvDrjP8sZY9lXdKJvEE3T4yEJwh4UV2PcFcORU3TgttBX6L9E4UV
         dLAfmyZu4DixA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Dmitry, I have pushed new patch set v3=20
(https://patchwork.ozlabs.org/patch/1135605/). Request you to kindly review=
.

Thanks.

On 7/23/2019 3:48 PM, Dmitry Osipenko wrote:
> 23.07.2019 13:11, Viswanath L =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>> Thanks for your comments, Dmitry. Please see my responses inline.
>>
>> On 7/23/2019 6:00 AM, Dmitry Osipenko wrote:
>>> 22.07.2019 12:27, Viswanath L =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>>> HDMI plugout calls runtime suspend, which clears interrupt registers
>>>> and causes audio functionality to break on subsequent plugin; setting
>>>> interrupt registers in sor_audio_prepare() solves the issue
>>> Hello Viswanath,
>>>
>>> A dot should be in the end of sentence, please. And should be better to
>>> s/plugin/plug-in/ in the commit's message/title because 'plugin' sounds
>>> as a noun.
>> [VL] Yes, I'll make the above changes.
>>> Please don't version patch as v2 if v1 wasn't ever sent out.
>> [VL] Now that I have sent v2, shall I continue with v2 for the next
>> patch? Apologies for this oversight.
> v3 should be good.
>
>>> You should add a stable tag here to get patch backported into stable
>>> kernel versions:
>>>
>>> Cc: <stable@vger.kernel.org>
>> [VL] Yes, will add.
>>>> Signed-off-by: Viswanath L <viswanathl@nvidia.com>
>>> The kernel upstreaming rules require a full name. I'm pretty sure that =
L
>>> isn't yours surname.
>> [VL] My name appears as "Viswanath L" in all company records and email
>> lists. I would strongly prefer to keep it this way, unless that is an
>> absolute no-no.
> I guess it should be okay, but a full name is much more preferable.