Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [Cluster-devel] [BUG] fs: gfs2: possible null-pointer
 dereferences in gfs2_rgrp_bh_get()
To:     Steven Whitehouse <swhiteho@redhat.com>, rpeterso@redhat.com,
        agruenba@redhat.com
Cc:     cluster-devel@redhat.com, linux-kernel@vger.kernel.org
References: <8d270882-54da-365e-1be7-a291a5178b1e@gmail.com>
 <cd7c0bb4-53d2-8a67-0719-c26d043a31fc@redhat.com>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <48547b12-ee4c-4f8c-d004-925d65f672d8@gmail.com>
Date:   Wed, 24 Jul 2019 17:08:47 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <cd7c0bb4-53d2-8a67-0719-c26d043a31fc@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks for the reply :)

On 2019/7/24 17:04, Steven Whitehouse wrote:
> Hi,
>
> On 24/07/2019 09:50, Jia-Ju Bai wrote:
>> In gfs2_rgrp_bh_get, there is an if statement on line 1191 to check 
>> whether "rgd->rd_bits[0].bi_bh" is NULL.
>
> That is how we detect whether the rgrp has already been read in, so 
> the function is skipped in the case that we've already read in the rgrp.
>
>
>> When "rgd->rd_bits[0].bi_bh" is NULL, it is used on line 1216:
>>     gfs2_rgrp_in(rgd, (rgd->rd_bits[0].bi_bh)->b_data);
>
> No it isn't. See line 1196 where bi_bh is set, and where we also bail 
> out (line 1198) in case it has not been set.
>

I overlooked the operation on line 1196...
Thanks for the pointer, I am sorry for the false report...


Best wishes,
Jia-Ju Bai