Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190723104602.3215243-1-arnd@arndb.de>
In-Reply-To: <20190723104602.3215243-1-arnd@arndb.de>
From:   "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Date:   Wed, 24 Jul 2019 11:47:17 +0100
Message-ID: <CA+V-a8uVt5GD=XZuCubFf8ZFacxPLofUdU3HKNZsbU4aQr5X7w@mail.gmail.com>
Subject: Re: [PATCH] media: staging: davinci: remove vpfe driver
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Linux Media Mailing List <linux-media@vger.kernel.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sekhar Nori <nsekhar@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        OSUOSL Drivers <devel@driverdev.osuosl.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 23, 2019 at 11:46 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> The davinci_vpfe driver was merged into staging back in 2012 by Manjunath
> Hadli from TI, with a long TODO list.
>
> For all I can tell, since then it has only seen fixes for compile-time
> issues and global cleanups, but nobody has actually worked on the items
> on the TODO list.
>
> To make things worse, the driver in its current form is incompatible with
> the platform code in arch/arm/mach-davinci, i.e. the driver expects to
> get its platform_data passed to the device as a 'struct vpfe_config',
> but uses a differnet definition for that structure compared to what the

s/differnet/different

> platform uses.
>
> Finally, there is another driver for the same device in
> drivers/media/platform/davinci/vpfe_capture.c. From all I can tell, the
> staging version was originally a copy of a more featureful driver in TI's
> downstream kernels. However, that kernel no longer supports dm365 after
> linux-2.6.37, and the mainline version moved in a different direction.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/staging/media/Kconfig                 |    2 -
>  drivers/staging/media/Makefile                |    1 -
>  drivers/staging/media/davinci_vpfe/Kconfig    |   13 -
>  drivers/staging/media/davinci_vpfe/Makefile   |   11 -
>  drivers/staging/media/davinci_vpfe/TODO       |   38 -
>  .../media/davinci_vpfe/davinci-vpfe-mc.txt    |  154 --
>  .../media/davinci_vpfe/davinci_vpfe_user.h    | 1287 ----------
>  .../staging/media/davinci_vpfe/dm365_ipipe.c  | 1852 ---------------
>  .../staging/media/davinci_vpfe/dm365_ipipe.h  |  174 --
>  .../media/davinci_vpfe/dm365_ipipe_hw.c       | 1038 --------
>  .../media/davinci_vpfe/dm365_ipipe_hw.h       |  556 -----
>  .../media/davinci_vpfe/dm365_ipipeif.c        | 1070 ---------
>  .../media/davinci_vpfe/dm365_ipipeif.h        |  228 --
>  .../media/davinci_vpfe/dm365_ipipeif_user.h   |   90 -
>  .../staging/media/davinci_vpfe/dm365_isif.c   | 2097 -----------------
>  .../staging/media/davinci_vpfe/dm365_isif.h   |  200 --
>  .../media/davinci_vpfe/dm365_isif_regs.h      |  291 ---
>  .../media/davinci_vpfe/dm365_resizer.c        | 1995 ----------------
>  .../media/davinci_vpfe/dm365_resizer.h        |  241 --
>  drivers/staging/media/davinci_vpfe/vpfe.h     |   83 -
>  .../media/davinci_vpfe/vpfe_mc_capture.c      |  716 ------
>  .../media/davinci_vpfe/vpfe_mc_capture.h      |   90 -
>  .../staging/media/davinci_vpfe/vpfe_video.c   | 1646 -------------
>  .../staging/media/davinci_vpfe/vpfe_video.h   |  150 --
>  24 files changed, 14023 deletions(-)
>  delete mode 100644 drivers/staging/media/davinci_vpfe/Kconfig
>  delete mode 100644 drivers/staging/media/davinci_vpfe/Makefile
>  delete mode 100644 drivers/staging/media/davinci_vpfe/TODO
>  delete mode 100644 drivers/staging/media/davinci_vpfe/davinci-vpfe-mc.txt
>  delete mode 100644 drivers/staging/media/davinci_vpfe/davinci_vpfe_user.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipeif.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipeif.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_ipipeif_user.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_isif.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_isif.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_resizer.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/dm365_resizer.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_mc_capture.h
>  delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_video.c
>  delete mode 100644 drivers/staging/media/davinci_vpfe/vpfe_video.h
>

Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

Regards,
--Prabhakar Lad