Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9509003ybi; Wed, 24 Jul 2019 05:24:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqwbBJpvfZ7UEIzJnTWfgxKFRs22f4yZ4nBlsjthHM8cjVwWP7XuweAinbXmnwR4QgnHIQKG X-Received: by 2002:a62:16:: with SMTP id 22mr11486891pfa.151.1563971050949; Wed, 24 Jul 2019 05:24:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563971050; cv=none; d=google.com; s=arc-20160816; b=rMTXARHJtbFKAw5Puj4d1I+Wwkhtx+s+ftX5ZydkERXi2VsMJIqx/LTbJePrK3rQOw RYq+0t0XwPdUHRBaK4EQLGZhCqfNgXBmYX8xmvcqyhRo6E9t1V0HpYF2shx1qM5PWFQ0 PgUDHn5DPdNzo99jbSJfRk960mYr9Z8rggjqM/PpJ242AoJjMU+VXvPLYHjB2jtAY45W A4c0MYBytK+3Jly4QzHTlT7KpU5n8/VV54znsGIYPSXffaygaR+IFB+EWMkB4W6ZDxqE p4dj6A2T0OTIVWOSDUL3z6D8HzBl89whbIhwuyj3Flbxq85RNMaTeYm/M26qPiQv2rkq mmvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=IFe+jDxbDPAMh5mQn2e4hJUl3LINzr9GC6L5Ez1zNn0=; b=JqrsKa08uhUHEMEJsnNME5RhbBEgmn+NdDVNBbRyc9lmRNPlrstidfjumVE7b3rnsU HAxo7RkuFkeg4Uz4La/qvv5IyP7ZQx8bkeuvDTdFTXKMUtUFmnAA7DTKk388gGpShnRv M5xzM81X0DumFI3X1N/WlAtWsvmtK25b6Ic5W2GiZwUKwQMDxBjodIGZt5CAHcn4la4E pilOBiKD5f+BQea63gqxCGW0MxT/D4QLidpDpgq321wmgptAPIqRwmCNUyWNWN3SZDOT elfXBFY3GVbKX5ohmsjWlfbXxpYlj91YlDP1jIxjFPZi1mhel0qZaQAOHJ5lBKZp+nQ/ dGmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6si13075586pge.44.2019.07.24.05.23.56; Wed, 24 Jul 2019 05:24:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727303AbfGXKJM (ORCPT + 99 others); Wed, 24 Jul 2019 06:09:12 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53441 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727137AbfGXKJK (ORCPT ); Wed, 24 Jul 2019 06:09:10 -0400 Received: by mail-wm1-f67.google.com with SMTP id x15so41257159wmj.3; Wed, 24 Jul 2019 03:09:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=IFe+jDxbDPAMh5mQn2e4hJUl3LINzr9GC6L5Ez1zNn0=; b=i2p/M+LAeRvbUKD/68s1cgVD0YtEqDlKcBKcUOyC/tbJRQUhvvkKqYCfsSTAjPesLz +gQ75RPq4quMzyB3yVhjrtKY8tXRFi9hbTIIwD4XGiSH5i3iP9lo+iYebcQBnKsk+wwc NzGbxf90py4HBCmAMupj0N3ro/zBDn4uQ/wuc3KAWhHqB+fn++YjcO+luLtepCNRjzku Cv3FIUldnZAAFytcBF89rpDJOV6lpOelKVujF2O0sLMDiE/W1/9ps7Ls1X/OSnftLQ+f Z27Ppufku+RgxxEPmbTDUU6nHuTgHG89KUnZJJX7zQffHudGzGBZjP3yxcw9zfFY/UW7 4MKA== X-Gm-Message-State: APjAAAUKJ6WQhvt1pDQ6ED+w9uC8r0ftCN8ASDcHbinJuq177VAOZU7T i8Ad0lvM9w5WQhgu6xnSSKFtgFYu X-Received: by 2002:a1c:480a:: with SMTP id v10mr73284060wma.120.1563962947927; Wed, 24 Jul 2019 03:09:07 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::ee2? ([2a0b:e7c0:0:107::ee2]) by smtp.gmail.com with ESMTPSA id c7sm39149158wro.70.2019.07.24.03.09.06 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2019 03:09:07 -0700 (PDT) Subject: Re: [PATCH] tty/isicom: remove redundant assignment to variable word_count To: Colin King , Greg Kroah-Hartman Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190723150314.14513-1-colin.king@canonical.com> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.com; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBxKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jb20+iQI4BBMBAgAiBQJOkujrAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAAKCRC9JbEEBrRwSc1VD/9CxnyCYkBrzTfbi/F3/tTstr3cYOuQlpmufoEjCIXx PNnBVzP7XWPaHIUpp5tcweG6HNmHgnaJScMHHyG83nNAoCEPihyZC2ANQjgyOcnzDOnW2Gzf 8v34FDQqj8CgHulD5noYBrzYRAss6K42yUxUGHOFI1Ky1602OCBRtyJrMihio0gNuC1lE4YZ juGZEU6MYO1jKn8QwGNpNKz/oBs7YboU7bxNTgKrxX61cSJuknhB+7rHOQJSXdY02Tt31R8G diot+1lO/SoB47Y0Bex7WGTXe13gZvSyJkhZa5llWI/2d/s1aq5pgrpMDpTisIpmxFx2OEkb jM95kLOs/J8bzostEoEJGDL4u8XxoLnOEjWyT82eKkAe4j7IGQlA9QQR2hCMsBdvZ/EoqTcd SqZSOto9eLQkjZLz0BmeYIL8SPkgnVAJ/FEK44NrHUGzjzdkE7a0jNvHt8ztw6S+gACVpysi QYo2OH8hZGaajtJ8mrgN2Lxg7CpQ0F6t/N1aa/+A2FwdRw5sHBqA4PH8s0Apqu66Q94YFzzu 8OWkSPLgTjtyZcez79EQt02u8xH8dikk7API/PYOY+462qqbahpRGaYdvloaw7tOQJ224pWJ 4xePwtGyj4raAeczOcBQbKKW6hSH9iz7E5XUdpJqO3iZ9psILk5XoyO53wwhsLgGcrkCDQRO kueGARAAz5wNYsv5a9z1wuEDY5dn+Aya7s1tgqN+2HVTI64F3l6Yg753hF8UzTZcVMi3gzHC ECvKGwpBBwDiJA2V2RvJ6+Jis8paMtONFdPlwPaWlbOv4nHuZfsidXkk7PVCr4/6clZggGNQ qEjTe7Hz2nnwJiKXbhmnKfYXlxftT6KdjyUkgHAs8Gdz1nQCf8NWdQ4P7TAhxhWdkAoOIhc4 OQapODd+FnBtuL4oCG0c8UzZ8bDZVNR/rYgfNX54FKdqbM84FzVewlgpGjcUc14u5Lx/jBR7 ttZv07ro88Ur9GR6o1fpqSQUF/1V+tnWtMQoDIna6p/UQjWiVicQ2Tj7TQgFr4Fq8ZDxRb10 Zbeds+t+45XlRS9uexJDCPrulJ2sFCqKWvk3/kf3PtUINDR2G4k228NKVN/aJQUGqCTeyaWf fU9RiJU+sw/RXiNrSL2q079MHTWtN9PJdNG2rPneo7l0axiKWIk7lpSaHyzBWmi2Arj/nuHf Maxpc708aCecB2p4pUhNoVMtjUhKD4+1vgqiWKI6OsEyZBRIlW2RRcysIwJ648MYejvf1dzv mVweUa4zfIQH/+G0qPKmtst4t/XLjE/JN54XnOD/TO1Fk0pmJyASbHJQ0EcecEodDHPWP6bM fQeNlm1eMa7YosnXwbTurR+nPZk+TYPndbDf1U0j8n0AEQEAAYkCHwQYAQIACQUCTpLnhgIb DAAKCRC9JbEEBrRwSTe1EACA74MWlvIhrhGWd+lxbXsB+elmL1VHn7Ovj3qfaMf/WV3BE79L 5A1IDyp0AGoxv1YjgE1qgA2ByDQBLjb0yrS1ppYqQCOSQYBPuYPVDk+IuvTpj/4rN2v3R5RW d6ozZNRBBsr4qHsnCYZWtEY2pCsOT6BE28qcbAU15ORMq0nQ/yNh3s/WBlv0XCP1gvGOGf+x UiE2YQEsGgjs8v719sguok8eADBbfmumerh/8RhPKRuTWxrXdNq/pu0n7hA6Btx7NYjBnnD8 lV8Qlb0lencEUBXNFDmdWussMAlnxjmKhZyb30m1IgjFfG30UloZzUGCyLkr/53JMovAswmC IHNtXHwb58Ikn1i2U049aFso+WtDz4BjnYBqCL1Y2F7pd8l2HmDqm2I4gubffSaRHiBbqcSB lXIjJOrd6Q66u5+1Yv32qk/nOL542syYtFDH2J5wM2AWvfjZH1tMOVvVMu5Fv7+0n3x/9shY ivRypCapDfcWBGGsbX5eaXpRfInaMTGaU7wmWO44Z5diHpmQgTLOrN9/MEtdkK6OVhAMVenI w1UnZnA+ZfaZYShi5oFTQk3vAz7/NaA5/bNHCES4PcDZw7Y/GiIh/JQR8H1JKZ99or9LjFeg HrC8YQ1nzkeDfsLtYM11oC3peHa5AiXLmCuSC9ammQ3LhkfET6N42xTu2A== Message-ID: <90da3a1d-ff0f-937b-d212-bb5428486768@suse.com> Date: Wed, 24 Jul 2019 12:09:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190723150314.14513-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23. 07. 19, 17:03, Colin King wrote: > From: Colin Ian King > > The variable word_count is being assigned a value that is never read before > a return, the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Looks good, it predates git. Maybe the while loop wanted to use word_count originally. Acked-by: Jiri Slaby > --- > drivers/tty/isicom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/isicom.c b/drivers/tty/isicom.c > index e04a43e89f6b..fc38f96475bf 100644 > --- a/drivers/tty/isicom.c > +++ b/drivers/tty/isicom.c > @@ -553,7 +553,6 @@ static irqreturn_t isicom_interrupt(int irq, void *dev_id) > > tty = tty_port_tty_get(&port->port); > if (tty == NULL) { > - word_count = byte_count >> 1; > while (byte_count > 1) { > inw(base); > byte_count -= 2; > -- js suse labs