Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190723104448.8125-1-nishkadg.linux@gmail.com> <20190723.133856.860402214064308020.davem@davemloft.net>
In-Reply-To: <20190723.133856.860402214064308020.davem@davemloft.net>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Wed, 24 Jul 2019 13:17:52 +0300
Message-ID: <CA+h21hrP7q=NTKW2yukCThW4v4FJH4wqXS2ZQ8u8jJDDKMVeLw@mail.gmail.com>
Subject: Re: [PATCH] net: dsa: sja1105: sja1105_main: Add of_node_put()
To:     David Miller <davem@davemloft.net>
Cc:     nishkadg.linux@gmail.com, Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 23 Jul 2019 at 23:38, David Miller <davem@davemloft.net> wrote:
>
> From: Nishka Dasgupta <nishkadg.linux@gmail.com>
> Date: Tue, 23 Jul 2019 16:14:48 +0530
>
> > Each iteration of for_each_child_of_node puts the previous node, but in
> > the case of a return from the middle of the loop, there is no put, thus
> > causing a memory leak. Hence add an of_node_put before the return.
> > Issue found with Coccinelle.
> >
> > Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>
> Applied.
>
> Again, the semantics of these looping constructs are terrible.

Strange.
Thanks for the fix.

-Vladimir