Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Jul 2019 09:09:29 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Bharath Vedartham <linux.bhar@gmail.com>
Cc:     sivanich@sgi.com, arnd@arndb.de, jhubbard@nvidia.com,
        ira.weiny@intel.com, jglisse@redhat.com,
        gregkh@linuxfoundation.org, william.kucharski@oracle.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in
 atomic_pte_lookup
Message-ID: <20190724160929.GA14052@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I think the atomic_pte_lookup / non_atomic_pte_lookup helpers
should simply go away.  Most of the setup code is common now and should
be in the caller where it can be shared.  Then just do a:

	if (atomic) {
		__get_user_pages_fast()
	} else {
		get_user_pages_fast();
	}

and we actually have an easy to understand piece of code.