Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190724105626.53552-1-steven.price@arm.com>
In-Reply-To: <20190724105626.53552-1-steven.price@arm.com>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 24 Jul 2019 10:27:03 -0600
Message-ID: <CAL_JsqLkxKe=feVQDb3VXqOnA7fvDBEKWgLf2suOHhNLnR704Q@mail.gmail.com>
Subject: Re: [PATCH] drm/panfrost: Export all GPU feature registers
To:     Steven Price <steven.price@arm.com>,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Cc:     Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Adding Alyssa's Collabora email.

On Wed, Jul 24, 2019 at 4:56 AM Steven Price <steven.price@arm.com> wrote:
>
> Midgard/Bifrost GPUs have a bunch of feature registers providing details
> of what the hardware supports. Panfrost already reads these, this patch
> exports them all to user space so that the jobs created by the user space
> driver can be tuned for the particular hardware implementation.
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_device.h |  1 +
>  drivers/gpu/drm/panfrost/panfrost_drv.c    | 38 +++++++++++++++++++--
>  drivers/gpu/drm/panfrost/panfrost_gpu.c    |  2 ++
>  include/uapi/drm/panfrost_drm.h            | 39 ++++++++++++++++++++++
>  4 files changed, 77 insertions(+), 3 deletions(-)

LGTM. I'll give it a bit more time to see if there are any comments
before I apply it.

Rob