Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9838863ybi; Wed, 24 Jul 2019 10:50:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqzjUSKfLK3TlK4anOoojx1OfgV3TDscrCiJU36rhkinfF7pb0ew2yBHpEbROXXLxe26Cr9p X-Received: by 2002:aa7:8108:: with SMTP id b8mr12736260pfi.197.1563990635509; Wed, 24 Jul 2019 10:50:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563990635; cv=none; d=google.com; s=arc-20160816; b=XE9lc3aTGo1ZhjansUbctonCoxJRzFYGjkrlIzqc4ZBl5TGqRTdU47f+32DQOljWCN Cr0hSY/bUxn8RRQd/5A/ArC7r8Qwpuj5E5kwvZUHR9c657uOBBBK5QoE0KJFZHVAtNwo P78D0jnpzSd0upCs2L2QIEIIPXJtwKngHNgwFGYXo7XCJ2bCdF9koaVsouxlrBHOvvp/ 4ApDC2cQcEMOI/dbnInDweEETCQL1uCFV4oRivIoatCq7KGnwHtv2svc2JqO8kqFSI0x MsGF/ZR8uxaP5E1IxIltNYzv4ngr7lk66wZctRfFVLHJxzMOkyWSG4Tzskkdo4NDn+nZ Hzbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=z41DzGtUFzaWWcpQAVjI+8rAtK/VXbLYrGHn+dMjo3I=; b=r4Q4BYxxChZQyJczmbadDTHe82Pr5tVsHpNhjNQjhWcGQ5vWkbw2x0Imzxfxm1iWWi cOojeYf9+Ig9YIHTx0CbDJamGCnB6B2pKox+jBzSd6qg3kwTUIOs75knO7ixSqg4Z5W/ CrJdIRC9Z8fiSbu2a8NtiBbNBh+6YiavaUlsxQ5zxcre0xLIp0Q3X/E/V88AsuzNIV1c r7AnKFZ5wNlDmYLbPoI/uuEyW05lpqeSlAFgQJFd/kI5ZcoWSlvJb6aZiUyE2oCQUpIE ceRL3h7eJRxShS+UbzJpkzrY8Aa9PZvTw8Hz1rg/PpCGBkyJAa7gdltc4MNX3ZJz8XnJ B6Cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=YeeC3awk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h63si13451319pjb.106.2019.07.24.10.50.20; Wed, 24 Jul 2019 10:50:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@wp.pl header.s=1024a header.b=YeeC3awk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=wp.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728653AbfGXRX0 (ORCPT + 99 others); Wed, 24 Jul 2019 13:23:26 -0400 Received: from mx4.wp.pl ([212.77.101.12]:54010 "EHLO mx4.wp.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727313AbfGXRXZ (ORCPT ); Wed, 24 Jul 2019 13:23:25 -0400 X-Greylist: delayed 478 seconds by postgrey-1.27 at vger.kernel.org; Wed, 24 Jul 2019 13:23:25 EDT Received: (wp-smtpd smtp.wp.pl 30481 invoked from network); 24 Jul 2019 19:16:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wp.pl; s=1024a; t=1563988604; bh=z41DzGtUFzaWWcpQAVjI+8rAtK/VXbLYrGHn+dMjo3I=; h=From:To:Cc:Subject; b=YeeC3awkT/FVcvjk+fURFqdyv0r3NGECJaqSruBjt2MEMxHyXyddFZaA64nkaxrka 0lLpbm0O7VZrCjgigBSnZ19v6fCSXRbOMwIZThg3hxH5pulTydVwW1xI4EtrctTXRp wUor382uyQhCqpSoEE8V8sOX195Tb9e+kJQh7ApQ= Received: from 014.152-60-66-biz-static.surewest.net (HELO cakuba.netronome.com) (kubakici@wp.pl@[66.60.152.14]) (envelope-sender ) by smtp.wp.pl (WP-SMTPD) with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP for ; 24 Jul 2019 19:16:43 +0200 Date: Wed, 24 Jul 2019 10:16:36 -0700 From: Jakub Kicinski To: Navid Emamdoost Cc: kvalo@codeaurora.org, emamd001@umn.edu, kjlu@umn.edu, smccaman@umn.edu, secalert@redhat.com, "David S. Miller" , Matthias Brugger , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt7601u: null check the allocation Message-ID: <20190724101636.4699c30a@cakuba.netronome.com> In-Reply-To: <20190724141736.29994-1-navid.emamdoost@gmail.com> References: <87d0i00z4t.fsf@kamboji.qca.qualcomm.com> <20190724141736.29994-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-WP-MailID: fe13a5d9e194338bda75b16965620f67 X-WP-AV: skaner antywirusowy Poczty Wirtualnej Polski X-WP-SPAM: NO 000000A [QTPk] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 24 Jul 2019 09:17:36 -0500, Navid Emamdoost wrote: > devm_kzalloc may fail and return NULL. So the null check is needed. > > Signed-off-by: Navid Emamdoost Ah, I replied to the wrong one.. Acked-by: Jakub Kicinski