Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 24 Jul 2019 16:47:01 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc:     lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: of: Add of_node_put() before return in
 function
Message-ID: <20190724154701.GA4524@sirena.org.uk>
References: <20190724083231.10276-1-nishkadg.linux@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm"
Content-Disposition: inline
In-Reply-To: <20190724083231.10276-1-nishkadg.linux@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 24, 2019 at 02:02:31PM +0530, Nishka Dasgupta wrote:
> The local variable search in regulator_of_get_init_node takes the value
> returned by either of_get_child_by_name or of_node_get, both of which
> get a node. If this node is not put before returning, it could cause a
> memory leak. Hence put search before a mid-loop return statement.
> Issue found with Coccinelle.

> -		if (!strcmp(desc->of_match, name))
> +		if (!strcmp(desc->of_match, name)) {
> +			of_node_put(search);
>  			return of_node_get(child);
> +		}

Why not just remove the extra of_node_get() and a comment explaining why
it's not needed?

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl04fXIACgkQJNaLcl1U
h9BzAQf/ZfWikyCjkNyf2y3H8tRh9hTsozRRPTDoKv5OA0kXowXCRiDKEAethice
kw8J6gLF/zAM7fUi6I/ykCaUH1dZyj3a1y9CzA+Evr3GGd2YmzrgWWtdXlozaW1V
lCz0csOupoL+snIKL1tC91H44TSha1DFUNPP7Uup358cR3kTrZMItdtU6fuUVxG1
QsIdMw4b5ug4tzvZCvt/ZVytb32z4KA3Uq3o2i0LeSvJ9HlhNgzoLD8ii62kt9v0
Y5owkpGEZx/4BuEuz+nWtElBr81jNnUASu3mmwCfUDY3520yteS12/y1wAY/s19/
u2AucDlyR4q5gq5UuuxoCYD8f/oh3w==
=2N6g
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--