Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9928012ybi; Wed, 24 Jul 2019 12:29:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqx6wKJc4RsXTryMyAyqRr/4wsl44GC7XEcDzPbg3btTR5g/Z+/XDGoY2mFYf6h4Me0JTCAQ X-Received: by 2002:a63:e901:: with SMTP id i1mr66284599pgh.451.1563996566509; Wed, 24 Jul 2019 12:29:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563996566; cv=none; d=google.com; s=arc-20160816; b=Vi/bCyj/4l35vQOI0TLfhwpka4HJXMRTuqbw5FcbiLCWlP7xHWwIZeu193Cl88hsNq pB1fsoRNUaYMLn/sL4FWWRWA9WiiqKJfEAtzhEF/Zk81Q8ca1PYPv2loGgQIZojy9xur FQ+q/srhd448R0r+8Fe1Fidh0wjLn9h0wiLtZXwxuSHHX/DV+zJXfZqMrV2tcs7evGHg LL7Vx8z/VXaPjctkXqBK9RG76RvBBGa2m53nOPM5rr9d654lOTHMXx+Phf8MsROni2mw pbKTyld4rx3RWgp2K27Ap+AM9Neu4846fnj1m6jlvSJXBa8DBbN3CBcDLrTG+MP213lV lTbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W4LtVB8xkUCIQ/Fs7QhV/w4dJyc3R+hnJ1GYICunX/c=; b=M6n9DMptfVVfqZiKdakPPex0ML2TE9IV3sHrmktejHKGbue1YXayNR+ZYoMQHUz7DV OyTcIeUHQtD3nojlTDoXR+tR9tZ2Twt4fjlcwYUBvsu5AuuyZLgjzkgzrOnva5VKxcap zBSTHlfdlflCjPQnI9PUrGP/pSPwJ3LKUFsYj/o/NQzW1dpZEnx4uDs+ZG9ovKEBxJKv C/8xdGl1kP6YJ6WBRP1c4dTjjv+G/WqkYJTJ9EB3JfsFSAVZZ7U6nxxFInxmxIFGTY+1 AwCRJxeNmasZ1C3aTSo2dQ32udU1hSnd4lP6H0lU0Eh0LhdQIph03Au9oPkolQWEC2v/ yN2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PQBo2xgE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c137si15533208pga.80.2019.07.24.12.29.11; Wed, 24 Jul 2019 12:29:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=PQBo2xgE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388059AbfGXTZk (ORCPT + 99 others); Wed, 24 Jul 2019 15:25:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:42346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388029AbfGXTZb (ORCPT ); Wed, 24 Jul 2019 15:25:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29336229ED; Wed, 24 Jul 2019 19:25:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996330; bh=4rXGb2R6EyZ9Mx+KiWyRg97meu2sfPYTAiAJSzPbv7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PQBo2xgE15D5ZyAJpf3Ub0i8SnfZAcpZ4J3hIbMa6L53SE8FfwfPD/mQ+Df2/fSIW dGhmdzCWDUhEvCCvgXGsSxgGeaZTrMunfyIjGk6bSud6xaA6Y+zR9NondwJuXJwekq eVv6mT/FsWC6DI4rpfGn/auANBIl5QTiB+dVgO5E= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Neil Armstrong , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.2 059/413] media: platform: ao-cec-g12a: disable regmap fast_io for cec bus regmap Date: Wed, 24 Jul 2019 21:15:50 +0200 Message-Id: <20190724191739.541651408@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 9f7406d6b56b4b71a12480b68221755ea7b3e0ee ] With fast_io enabled, spinlock_irq is used for read/write operations, thus leading to : BUG: sleeping function called from invalid context at [snip]/ao-cec-g12a.c:379 in_atomic(): 1, irqs_disabled(): 128, pid: 1451, name: irq/14-ff800280 [snip] Call trace: dump_backtrace+0x0/0x180 show_stack+0x14/0x1c dump_stack+0xa8/0xe0 ___might_sleep+0xf4/0x104 __might_sleep+0x4c/0x80 meson_ao_cec_g12a_read+0x7c/0x164 regmap_read+0x16c/0x1b0 meson_ao_cec_g12a_irq_thread+0xcc/0x200 irq_thread_fn+0x2c/0x60 irq_thread+0x14c/0x1fc kthread+0x11c/0x12c ret_from_fork+0x10/0x18 Simply remove fast_io to use mutexes instead. Fixes: b7778c46683c ("media: platform: meson: Add Amlogic Meson G12A AO CEC Controller driver") Signed-off-by: Neil Armstrong Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/meson/ao-cec-g12a.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/meson/ao-cec-g12a.c b/drivers/media/platform/meson/ao-cec-g12a.c index 3620a1e310f5..ddfd060625da 100644 --- a/drivers/media/platform/meson/ao-cec-g12a.c +++ b/drivers/media/platform/meson/ao-cec-g12a.c @@ -415,7 +415,6 @@ static const struct regmap_config meson_ao_cec_g12a_cec_regmap_conf = { .reg_read = meson_ao_cec_g12a_read, .reg_write = meson_ao_cec_g12a_write, .max_register = 0xffff, - .fast_io = true, }; static inline void -- 2.20.1