Received: by 2002:a25:ad19:0:0:0:0:0 with SMTP id y25csp9932808ybi; Wed, 24 Jul 2019 12:34:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqw9dF3UDjCQcMYm56rj6IqTFC0sonw4qpqMgGq9+NdoX43QGeMFE4r3Za65l3tUCbpHFyHv X-Received: by 2002:a63:ee0c:: with SMTP id e12mr84055491pgi.184.1563996872587; Wed, 24 Jul 2019 12:34:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563996872; cv=none; d=google.com; s=arc-20160816; b=xydrIfD8J3++Dyx6tsBG0S/4tV/AlZNvKdLULQyGa3zUHnY1Xp/E+pjdCWmssnwLs2 wLm4MOqFk5Elrpp1Tj0DI/ba+bgjoTNTubTwKDop8q3xN74QjPqBxdRQqPFTGXbGQ4P5 OBv+kRD9er1jUHpATOaOnr0T5sWMlvhMr0Td6Aw0uvn6mBSRDoeAKYUjNd9qFfaFb6FC tA7MQMIYEOdUDtfS6YC/e7ljQ4Jw96YpRbcLDPi2Y0EWJYgsIJVktlLA7ukF9kcP/NTI FOuqpkmMKIgumaM8232S8UlDqVkOA134uGN9+5d34QdE+PCYyLzlplbvjrfmjvGO+7do CluA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zqxF+uMT6W7sa1+ymz37xA7hBLL8fvLkjYrXXhQldZk=; b=D5pZzY8q+Ngd2PApe3RvmkvsNCJwECYVavxTpADqFpecdhv2YsXAX8yhKihUUM3gd9 XU2nOqEi77swG+L2nN4qH61RupSmMXy6N6tokG3KYm4pdLGL2erkud094/xVzhXXctt9 RDgj3GRQlZ8RsceKRvVVSoQVZG4HMPAFW8hve54RbOHhFA3hSQVc6R5jZ9KGM10lpiZg Ss7Y1UMfgFcRlx0p+pDC0fP43BwpiygIKU1clPT7HMReRvTmbfhscEYENJIYfVlTXMND PeCuOwUhUcPl1hco3bSfCg60TgnmBXFpzvm/vHvlpN/Sku7yjL+ls5wb97C2S2acHH92 nekA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2pjTSHRS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j8si14920092plt.303.2019.07.24.12.34.17; Wed, 24 Jul 2019 12:34:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2pjTSHRS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387961AbfGXTcN (ORCPT + 99 others); Wed, 24 Jul 2019 15:32:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:53458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388589AbfGXTcL (ORCPT ); Wed, 24 Jul 2019 15:32:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 527192238C; Wed, 24 Jul 2019 19:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563996730; bh=WehsvQN0BP1fhg4h0wIjyNdGiJvwusZzVCJnALS/tbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2pjTSHRSe8HYdkUCP6+8QbXZYml125+8AyCwuGydk+dCgUHDmTIm3gFoixEWo1ED3 UJlqyfnEmCL9Qe8VHxm1Ic41EWWHxTX8NN3nEAFoc+kt0sSST0YV47pgUkA/ZBeBIu 6+Mx3/mtMc5daYPDVj1WTIdxoyyrTgaYYJ2LcxLQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wen Gong , Kalle Valo , Sasha Levin Subject: [PATCH 5.2 196/413] ath10k: destroy sdio workqueue while remove sdio module Date: Wed, 24 Jul 2019 21:18:07 +0200 Message-Id: <20190724191748.629895530@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190724191735.096702571@linuxfoundation.org> References: <20190724191735.096702571@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 3ed39f8e747a7aafeec07bb244f2c3a1bdca5730 ] The workqueue need to flush and destory while remove sdio module, otherwise it will have thread which is not destory after remove sdio modules. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00007-QCARMSWP-1. Signed-off-by: Wen Gong Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath10k/sdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 73ef3e75d199..28bdf0212538 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -2081,6 +2081,9 @@ static void ath10k_sdio_remove(struct sdio_func *func) cancel_work_sync(&ar_sdio->wr_async_work); ath10k_core_unregister(ar); ath10k_core_destroy(ar); + + flush_workqueue(ar_sdio->workqueue); + destroy_workqueue(ar_sdio->workqueue); } static const struct sdio_device_id ath10k_sdio_devices[] = { -- 2.20.1