Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 25 Jul 2019 01:04:19 +0530
From:   Bharath Vedartham <linux.bhar@gmail.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     sivanich@sgi.com, arnd@arndb.de, jhubbard@nvidia.com,
        ira.weiny@intel.com, jglisse@redhat.com,
        gregkh@linuxfoundation.org, william.kucharski@oracle.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 3/3] sgi-gru: Use __get_user_pages_fast in
 atomic_pte_lookup
Message-ID: <20190724193418.GA19421@bharath12345-Inspiron-5559>
References: <20190724160929.GA14052@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190724160929.GA14052@infradead.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 24, 2019 at 09:09:29AM -0700, Christoph Hellwig wrote:
> I think the atomic_pte_lookup / non_atomic_pte_lookup helpers
> should simply go away.  Most of the setup code is common now and should
> be in the caller where it can be shared.  Then just do a:
> 
> 	if (atomic) {
> 		__get_user_pages_fast()
> 	} else {
> 		get_user_pages_fast();
> 	}
> 
> and we actually have an easy to understand piece of code.

That makes sense. I ll do that and send v3. I ll probably cut down on a
patch and try to fold all the changes into a single patch removing the
*pte_lookup helpers.